From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web08.7522.1607043939311270479 for ; Thu, 03 Dec 2020 17:05:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=LceSUV9a; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B4134QD191040; Thu, 3 Dec 2020 20:05:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=UYTH6x4t87rqMHwiuhWMsJ1OyQAJtk+maKqzNJTDzDE=; b=LceSUV9a8qNMYgfgcW+fd34ZdbaBkA/ubRjR7kdm+s59OeCAg98vSsWIo1CPdBY7PXcw HUGsRFQggb3KIUTjQct6aim9OgIxOgoI8yallH+RDHBPxEfw6TrAxkhMzJUMhpiVVg84 b6NF0YpI6LfSgRcC33wvf+CM7ymEt6jV01PEsiaCI95nrx4tPftM70ggA4uAJuR5Xqkz Jg+ZEfAOauqsp1G7XJamlWaCKn0ig3TLGRmbDL/+R9obX24FbN7Pl85MYT6cuND0BdKs sZrmCoJpu7+4fxEAt/EmtNNAmVnlHTe3vU5/fF4cWjyEZfWSHWJ0dlbH272RT6mwmNIm Cw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 35789amx4a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Dec 2020 20:05:32 -0500 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0B415VK3009322; Thu, 3 Dec 2020 20:05:31 -0500 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 35789amx3q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Dec 2020 20:05:31 -0500 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0B411ZSt023060; Fri, 4 Dec 2020 01:05:30 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma01dal.us.ibm.com with ESMTP id 355rf812m2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Dec 2020 01:05:30 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0B415RUl22020486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 4 Dec 2020 01:05:27 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 682907805C; Fri, 4 Dec 2020 01:05:27 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE8C17805E; Fri, 4 Dec 2020 01:05:24 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.80.201.242]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 4 Dec 2020 01:05:24 +0000 (GMT) Message-ID: <762be18c6132f0f55e029879931ba6bca79323cd.camel@linux.ibm.com> Subject: Re: [edk2-devel] [PATCH v3 0/6] SEV Encrypted Boot for Ovmf From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: Laszlo Ersek , devel@edk2.groups.io Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" , Jordan Justen , Ard Biesheuvel Date: Thu, 03 Dec 2020 17:05:23 -0800 In-Reply-To: References: <20201130202819.3910-1-jejb@linux.ibm.com> <0805f171-b5c2-a556-3e64-c700aaf06d85@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-12-03_15:2020-12-03,2020-12-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 clxscore=1015 adultscore=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 mlxscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012040002 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2020-12-04 at 01:46 +0100, Laszlo Ersek wrote: > On 12/03/20 15:27, James Bottomley wrote: > > On Thu, 2020-12-03 at 13:26 +0100, Laszlo Ersek wrote: > > > Hi James, > > > > > > On 11/30/20 21:28, James Bottomley wrote: > > > > v3: > > > > > > > > - More grub and boot stripping (I think I got everything out, > > > > but there may be something that strayed in the boot panic > > > > resolution). > > > > - grub.sh tidy up with tabs->spaces. > > > > - Move the reset vector GUIDisation patch to the front so it > > > > can be applied independently > > > > - Update the .dsc and .fdf files for variable policy > > > > > > In preparation for submitting the github PR for merging this > > > series, I first ran PatchCheck.py locally. > > > > > > It doesn't like that I converted "OvmfPkg/AmdSev/Grub/grub.cfg" > > > to LF, in addition to "OvmfPkg/AmdSev/Grub/grub.sh". > > > > > > PatchCheck.py recognizes the ".sh" suffix, so it's not > > > complaining about "OvmfPkg/AmdSev/Grub/grub.sh". But, the config > > > file is a problem. > > > > > > Can you please confirm that grub works fine if the config file > > > has CRLF line terminators? Because then I'll just convert the > > > config file back to CRLF, and merge the series. > > > > I converted the entire file with unix2dos and grub does seem to be > > fine with the CRLF line endings (probably because it wants to be a > > boot loader beyond linux), so I think converting the file to CRLF > > is the right way to go. > > I submitted PR ;, but it > was rejected due to ECC failures. > > I think we all need to have a serious talk about ECC. I'll send a > separate email. > > I'm really sorry. Is it just complaining that gGrubFileGuid is the same as the FILE_GUID in Grub.inf (as the comment in Grub.inf says) but it shouldn't be, so the fix is to remove the comment and generate a new FILE_GUID for Grub.inf? James