From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>, devel@edk2.groups.io
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Thomas Abraham <thomas.abraham@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH edk2-platforms 4/4] Platform/ARM: switch to local version of NorFlashDxe drivers
Date: Wed, 19 Oct 2022 13:53:32 +0100 [thread overview]
Message-ID: <7630476e-2984-eb98-230d-a0eb698cfe8e@arm.com> (raw)
In-Reply-To: <20221019103555.493477-5-ardb@kernel.org>
Hi Ard,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 19/10/2022 11:35 am, Ard Biesheuvel wrote:
> Drop the dependency on the ArmPlatformPkg version of NorFlashDxe and
> NorFlashStandaloneMm, which will be going away soon. Instead, depend on
> the local version under Platform/ARM.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 2 +-
> Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 2 +-
> Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
> Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 2 +-
> Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 2f5dadfaefc6..81764368a0b7 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -256,7 +256,7 @@ [Components.common]
> !if $(ENABLE_GOP) == TRUE
>
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
>
> !endif
>
> - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>
> EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
>
> MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> index 68fc3ad93a5f..ae0ff7247a6a 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> @@ -122,7 +122,7 @@ [Components.common]
> [Components.AARCH64]
>
> StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf
>
> !if $(SECURE_STORAGE_ENABLE) == TRUE
>
> - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
>
> + Platform/ARM/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
>
> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf
>
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf {
>
> <LibraryClasses>
>
> diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
> index f7ce397633f6..a00b866c5e9a 100644
> --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> @@ -277,7 +277,7 @@ [Components.common]
> MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
>
>
>
> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
>
> - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> ArmPkg/Drivers/TimerDxe/TimerDxe.inf
>
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf
>
>
>
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> index cb9d2d4287e3..9c5e78d6275d 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> @@ -229,7 +229,7 @@ [Components.common]
> MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
>
>
>
> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
>
> - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
>
> ArmPkg/Drivers/TimerDxe/TimerDxe.inf
>
> ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
>
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> index 8561c21fab5a..dc081794cf98 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> @@ -289,7 +289,7 @@ [Components.common]
> }
>
>
>
> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
>
> - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> ArmPkg/Drivers/TimerDxe/TimerDxe.inf
>
> !ifdef EDK2_ENABLE_PL111
>
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
>
> diff --git a/Platform/ARM/JunoPkg/ArmJuno.fdf b/Platform/ARM/JunoPkg/ArmJuno.fdf
> index c9d51c65ffdb..fca5a78cee6c 100644
> --- a/Platform/ARM/JunoPkg/ArmJuno.fdf
> +++ b/Platform/ARM/JunoPkg/ArmJuno.fdf
> @@ -136,7 +136,7 @@ [FV.FvMain]
> INF ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf
>
>
>
> # NOR Flash driver
>
> - INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + INF Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
>
>
> # Versatile Express FileSystem
>
> INF Platform/ARM/Drivers/BootMonFs/BootMonFs.inf
>
> diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf
> index c1c24b747fa5..653aae8285a6 100644
> --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf
> +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf
> @@ -50,7 +50,7 @@ [FV.FVMAIN_COMPACT]
>
>
> INF StandaloneMmPkg/Core/StandaloneMmCore.inf
>
> !if $(SECURE_STORAGE_ENABLE) == TRUE
>
> - INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
>
> + INF Platform/ARM/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
>
> INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf
>
> INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
>
> !endif
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> index 4018480b424c..7e55214c2001 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> @@ -149,7 +149,7 @@ [FV.FvMain]
> INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf
>
>
>
> # NOR Flash driver
>
> - INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + INF Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> INF OvmfPkg/VirtioBlkDxe/VirtioBlk.inf
>
>
>
> # Graphics Output Protocol
>
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf
> index 8ca70a248d09..73c4ddb0995b 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf
> @@ -90,7 +90,7 @@ [FV.FvMain]
>
>
> INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
>
> INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf
>
> - INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + INF Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
>
> INF ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
>
>
>
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
> index a7d048273b37..e836691ddf6f 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
> @@ -112,7 +112,7 @@ [FV.FvMain]
>
>
> INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
>
> INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf
>
> - INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> + INF Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf
>
> !ifdef EDK2_ENABLE_PL111
>
> INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
>
> !endif
>
next prev parent reply other threads:[~2022-10-19 12:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 10:35 [PATCH edk2-platforms 0/4] Platform/ARM: clone ArmPlatformPkg's NorFlashDxe Ard Biesheuvel
2022-10-19 10:35 ` [PATCH edk2-platforms 1/4] Platform/ARM/BootMonFs: drop spurious dependency on ArmPlatformPkg Ard Biesheuvel
2022-10-19 12:46 ` Sami Mujawar
2022-10-19 10:35 ` [PATCH edk2-platforms 2/4] Platform/ARM: create local definition of NorFlashPlatformLib Ard Biesheuvel
2022-10-19 12:51 ` [edk2-devel] " Sunil V L
2022-10-19 12:52 ` Sami Mujawar
2022-10-19 12:56 ` [edk2-devel] " Ard Biesheuvel
2022-10-19 13:26 ` Sunil V L
2022-10-19 10:35 ` [PATCH edk2-platforms 3/4] Platform/ARM: clone NorFlashDxe from ArmPlatformPkg Ard Biesheuvel
2022-10-19 12:52 ` Sami Mujawar
2022-10-19 10:35 ` [PATCH edk2-platforms 4/4] Platform/ARM: switch to local version of NorFlashDxe drivers Ard Biesheuvel
2022-10-19 12:53 ` Sami Mujawar [this message]
2022-10-19 15:12 ` [PATCH edk2-platforms 0/4] Platform/ARM: clone ArmPlatformPkg's NorFlashDxe Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7630476e-2984-eb98-230d-a0eb698cfe8e@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox