public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Darbin Reyes" <darbin.reyes@intel.com>
To: devel@edk2.groups.io
Cc: Darbin Reyes <darbin.reyes@intel.com>,
	Jacob Narey <jacob.narey@intel.com>
Subject: [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception
Date: Tue,  7 Mar 2023 15:04:03 -0800	[thread overview]
Message-ID: <7649d8fa34ad6b7f893fdd49efd4c3a7f2125fb6.1678229331.git.darbin.reyes@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4360

An incorrect format specifier is being used in a DEBUG print,
specifically, a variable of type EFI_STATUS was being printed with
the %a format specifier (pointer to an ASCII string), thus the value of
the Status variable was being treated as the address of a string,
leading to a CPU exception, when encountered this bug manifests itself
as a hang near "Ready to Boot Event", with the last DEBUG print being
"INFO: Got MicrocodePatchHob with microcode patches starting address"
followed by a CPU Exception dump.

Signed-off-by: Darbin Reyes <darbin.reyes@intel.com>
Reviewed-by: Jacob Narey <jacob.narey@intel.com>
---
 UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
index 762ca159ff..5fd3b3365c 100644
--- a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
+++ b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
@@ -238,7 +238,7 @@ MeasureMicrocodePatches (
        TotalMicrocodeSize)
       );
   } else {
-    DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %a!\n", Status));
+    DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %r!\n", Status));
   }
 
   FreePool (Offsets);
-- 
2.38.1.windows.1


             reply	other threads:[~2023-03-07 23:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 23:04 Darbin Reyes [this message]
2023-03-07 23:16 ` [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception Michael D Kinney
2023-03-07 23:23 ` Ni, Ray
2023-03-07 23:52   ` Michael D Kinney
2023-03-07 23:59     ` Ni, Ray
2023-03-10  4:46 ` Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7649d8fa34ad6b7f893fdd49efd4c3a7f2125fb6.1678229331.git.darbin.reyes@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox