From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.1267.1610094900205383771 for ; Fri, 08 Jan 2021 00:35:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CgsGzNGz; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610094899; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XG4pNbFfgqHXWRSqlfKgHCE8hI8p24WJCuGbQsMNisA=; b=CgsGzNGzxCkBT/9ZgcvvB7XJLVVsNDwgfmB3CQVmkrq/hIjD/RVTibqmtR7B8dCGIMc91s taa+/z/GT/QQZHxC8hGyIfJTib2o0rcNOF8AhDHTTz8WLzCS+iKSGT6B4v8AYB2XHiwnpy Y+kiwPv85IaiD4hecLMhxZPVOUg4eYY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-CR8WPjmDNVqGzKbrCEpBSQ-1; Fri, 08 Jan 2021 03:34:49 -0500 X-MC-Unique: CR8WPjmDNVqGzKbrCEpBSQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 228DE107ACE4; Fri, 8 Jan 2021 08:34:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-111.ams2.redhat.com [10.36.113.111]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46F7A5D9C0; Fri, 8 Jan 2021 08:34:44 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements From: "Laszlo Ersek" To: edk2-devel-groups-io , Ray Ni , Zhichao Gao Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall , Leif Lindholm , Peter Grehan , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Rebecca Cran , Sami Mujawar Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20210104154235.31785-1-lersek@redhat.com> Message-ID: <76573f0b-0782-b5cb-9323-12cdafb84f84@redhat.com> Date: Fri, 8 Jan 2021 09:34:43 +0100 MIME-Version: 1.0 In-Reply-To: <20210104154235.31785-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Zhichao, Ray, can you please start reviewing the ShellPkg patches in this series? (#1, #4, #5, #6.) Thanks, Laszlo On 01/04/21 16:42, Laszlo Ersek wrote: > Repo: https://pagure.io/lersek/edk2.git > Branch: shell_usability_improvements > > This series addresses various usability shortcomings that I've recently > run into, while working with large directory trees on FAT and/or > virtio-fs in the UEFI shell. > > * add file buffering to the COMP command > https://bugzilla.tianocore.org/show_bug.cgi?id=3123 > > * ArmVirtPkg, OvmfPkg: set PcdShellFileOperationSize to 0x20000 > https://bugzilla.tianocore.org/show_bug.cgi?id=3125 > > * Shell: pathname / filename sorting > https://bugzilla.tianocore.org/show_bug.cgi?id=3151 > > * ArmVirtPkg, OvmfPkg: disable list length checks in NOOPT and DEBUG > builds > https://bugzilla.tianocore.org/show_bug.cgi?id=3152 > > Beyond testing the series locally, I've also heavily subjected it to > local CI runs, including ECC (relevant for ShellPkg). > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Ray Ni > Cc: Rebecca Cran > Cc: Sami Mujawar > Cc: Zhichao Gao > > Thanks > Laszlo > > Laszlo Ersek (8): > ShellPkg/Comp: add file buffering > OvmfPkg: raise PcdShellFileOperationSize to 128KB > ArmVirtPkg: raise PcdShellFileOperationSize to 128KB > ShellPkg/ShellCommandLib: add ShellSortFileList() > ShellPkg/Ls: sort output by FileName in non-SFO mode > ShellPkg/ShellProtocol: sort files by FullName in > RemoveDupInFileList() > OvmfPkg: disable list length checks in NOOPT and DEBUG builds > ArmVirtPkg: disable list length checks in NOOPT and DEBUG builds > > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/Bhyve/BhyveX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 3 + > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > OvmfPkg/OvmfPkgX64.dsc | 3 + > OvmfPkg/OvmfXen.dsc | 1 + > ShellPkg/Application/Shell/ShellProtocol.c | 16 + > ShellPkg/Include/Library/ShellCommandLib.h | 81 +++++ > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 312 ++++++++++++++++++++ > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h | 19 ++ > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf | 1 + > ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c | 127 +++++++- > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 1 + > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 14 + > ShellPkg/ShellPkg.dsc | 1 + > 18 files changed, 584 insertions(+), 4 deletions(-) > > > base-commit: 0785c619a58a450091d2bf6755591012533b80b8 >