public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Sai Chaganty <rangasai.v.chaganty@intel.com>,
	Bibo Mao <maobibo@loongson.cn>, Chao Li <lichao@loongson.cn>,
	Xianglai li <lixianglai@loongson.cn>,
	Sunil V L <sunilvl@ventanamicro.com>,
	USER0FISH <libing1202@outlook.com>,
	caiyuqing379 <caiyuqing_hz@outlook.com>,
	dahogn <dahogn@hotmail.com>, meng-cz <mengcz1126@gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules
Date: Fri, 08 Mar 2024 01:20:49 -0800	[thread overview]
Message-ID: <765a353d-ef08-9117-e249-a35279592abd@redhat.com> (raw)
In-Reply-To: <20240305120126.70259-1-lersek@redhat.com>

On 3/5/24 13:01, Laszlo Ersek wrote:
> Bugzilla:
> - https://bugzilla.tianocore.org/show_bug.cgi?id=990
> 
> This patch series puts the recent BaseTools feature to use in which
> AutoGen generates the ProcessLibraryConstructorList() declaration in
> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at
> least 1.30. The BaseTools feature is present in both edk2 [1] and
> edk2-basetools [2], and has been documented in the Build spec [3] and
> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools
> release [5] [6] with the new feature.
> 
> [1] edk2 commit bac9c74080cf
> [2] edk2-basetools commit 5b7161de22ee
> [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199
> [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe
> [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51
> [6] https://pypi.org/project/edk2-basetools/0.1.51/
> 
> The edk2-basetools part is adopted in the first patch (for
> "pip-requirements.txt") of the edk2 series
> 
>   [edk2-devel] [PATCH v2 00/10]
>   clean up ProcessLibraryConstructorList() declarations in SEC modules
> 
>   https://edk2.groups.io/g/devel/message/116367
>   msgid <20240305113843.68812-1-lersek@redhat.com>
> 
> The rest of the patches clean up -- superfluous, or even incorrect --
> ProcessLibraryConstructorList() declarations (and, in some cases,
> incorrect calls), together with raising the INF_VERSIONs in the related
> SEC module INF files to 1.30.
> 
> Comparing this version to v1 is not useful, as the compatibility
> approach is different, and so this version is structured differently.
> Please review any patches for your subsystem from scratch (they are not
> difficult or large).
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> Cc: dahogn <dahogn@hotmail.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (4):
>   BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>   SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList()
>     decl
>   LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList()
>     decl
>   SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl
> 
>  Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf |  2 +-
>  Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h        |  6 ------
>  Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c      |  3 +--
>  Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf    |  2 +-
>  Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c         |  3 +--
>  Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf       |  2 +-
>  Silicon/Sophgo/SG2042Pkg/Sec/Memory.c                    |  1 -
>  Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h                   | 12 ------------
>  Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf                 |  2 +-
>  9 files changed, 6 insertions(+), 27 deletions(-)
> 
> 
> base-commit: fe41713668d42b20a2370dab27de3269e877e454

Merged by Ard as commit range 4e478301f40e..bb44e786e7a7, via
<https://github.com/tianocore/edk2-platforms/pull/130>.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116497): https://edk2.groups.io/g/devel/message/116497
Mute This Topic: https://groups.io/mt/104742756/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2024-03-08  9:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 13:01   ` Ard Biesheuvel
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix " Laszlo Ersek
2024-03-06 21:10   ` Laszlo Ersek
2024-03-06 22:24     ` Michael D Kinney
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: " Laszlo Ersek
2024-03-05 13:05   ` Chao Li
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up " Laszlo Ersek
2024-03-05 14:07   ` Sunil V L
2024-03-08  9:20 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=765a353d-ef08-9117-e249-a35279592abd@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox