From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2B356AC0E45 for ; Fri, 8 Mar 2024 09:20:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wt4NVIvmW7CMNlyweuIoTuUj9JYu+tONy+iG5yEivyg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709889649; v=1; b=0LNl4qRD14u06Fh9e/16g+OaIYBXRdU4F1jreDxvE1fdVaqYVQm0PYx26ub8PVPlm5ng7s+q +Z5qDZ016yUQsSO5fPiEMV7YRCmV9BvPex8ugjjJNMeXADqkAKceNuFWiSkypIWMlUrY6bU1Nvl uofszUPKM6TwesJXX2OZUfxxoFfZfYfAwlr0/6bbbpIPEsRtVUu2sk3gJRqTbr1W6B0zLRCVttT tefgx4fwpnh1kVfw6FBDUNeiYMKTLC/7CtgOGyON0jtuLdrxYOjmwPZsQsJYJbQVJrX9SH8RxlH LDdEAH/02lAluIxwF3A1GlMCOBGkLqRzfvYD9jP4qQ8nQ== X-Received: by 127.0.0.2 with SMTP id j4Y9YY7687511xxzGHGzjQbu; Fri, 08 Mar 2024 01:20:49 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.17916.1709889649184096005 for ; Fri, 08 Mar 2024 01:20:49 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-2p5p4_50M4m1_v5wvBzIqg-1; Fri, 08 Mar 2024 04:20:44 -0500 X-MC-Unique: 2p5p4_50M4m1_v5wvBzIqg-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2248F29AB3F7; Fri, 8 Mar 2024 09:20:44 +0000 (UTC) X-Received: from [10.39.192.88] (unknown [10.39.192.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FE9137F6; Fri, 8 Mar 2024 09:20:41 +0000 (UTC) Message-ID: <765a353d-ef08-9117-e249-a35279592abd@redhat.com> Date: Fri, 08 Mar 2024 01:20:49 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm , Nate DeSimone , Sai Chaganty , Bibo Mao , Chao Li , Xianglai li , Sunil V L , USER0FISH , caiyuqing379 , dahogn , meng-cz Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20240305120126.70259-1-lersek@redhat.com> In-Reply-To: <20240305120126.70259-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1Qdp3u96Fcgpr2rGd33sQzRpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0LNl4qRD; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 3/5/24 13:01, Laszlo Ersek wrote: > Bugzilla: > - https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 >=20 > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at > least 1.30. The BaseTools feature is present in both edk2 [1] and > edk2-basetools [2], and has been documented in the Build spec [3] and > the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools > release [5] [6] with the new feature. >=20 > [1] edk2 commit bac9c74080cf > [2] edk2-basetools commit 5b7161de22ee > [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199 > [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe > [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51 > [6] https://pypi.org/project/edk2-basetools/0.1.51/ >=20 > The edk2-basetools part is adopted in the first patch (for > "pip-requirements.txt") of the edk2 series >=20 > [edk2-devel] [PATCH v2 00/10] > clean up ProcessLibraryConstructorList() declarations in SEC modules >=20 > https://edk2.groups.io/g/devel/message/116367 > msgid <20240305113843.68812-1-lersek@redhat.com> >=20 > The rest of the patches clean up -- superfluous, or even incorrect -- > ProcessLibraryConstructorList() declarations (and, in some cases, > incorrect calls), together with raising the INF_VERSIONs in the related > SEC module INF files to 1.30. >=20 > Comparing this version to v1 is not useful, as the compatibility > approach is different, and so this version is structured differently. > Please review any patches for your subsystem from scratch (they are not > difficult or large). >=20 > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Nate DeSimone > Cc: Sai Chaganty > Cc: Bibo Mao > Cc: Chao Li > Cc: Xianglai li > Cc: Sunil V L > Cc: USER0FISH > Cc: caiyuqing379 > Cc: dahogn > Cc: meng-cz >=20 > Thanks, > Laszlo >=20 > Laszlo Ersek (4): > BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl > SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() > decl > LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList() > decl > SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl >=20 > Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +- > Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h | 6 ------ > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +-- > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +- > Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +-- > Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +- > Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 1 - > Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h | 12 ----------= -- > Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +- > 9 files changed, 6 insertions(+), 27 deletions(-) >=20 >=20 > base-commit: fe41713668d42b20a2370dab27de3269e877e454 Merged by Ard as commit range 4e478301f40e..bb44e786e7a7, via . Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116497): https://edk2.groups.io/g/devel/message/116497 Mute This Topic: https://groups.io/mt/104742756/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-