From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 18796209574E1 for ; Tue, 27 Feb 2018 02:20:50 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A4068D6EA; Tue, 27 Feb 2018 10:26:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-21.rdu2.redhat.com [10.10.120.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id B486C202699A; Tue, 27 Feb 2018 10:26:55 +0000 (UTC) To: Jian J Wang , edk2-devel@lists.01.org Cc: Ruiyu Ni , Eric Dong References: <20180227051914.9892-1-jian.j.wang@intel.com> From: Laszlo Ersek Message-ID: <7667ffac-4090-4489-af73-c9ffedbe1b39@redhat.com> Date: Tue, 27 Feb 2018 11:26:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180227051914.9892-1-jian.j.wang@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 27 Feb 2018 10:26:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 27 Feb 2018 10:26:56 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: fix incorrect init of exception stack X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 10:20:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/27/18 06:19, Jian J Wang wrote: > The field KnownGoodStackTop in CPU_EXCEPTION_INIT_DATA is initialized to > the start address of array mNewStack. This is wrong. It must be the end > of mNewStack. This patch fixes this mistake. > > Cc: Ruiyu Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- > UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c > index 6d1b54d31d..2a090782fc 100644 > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c > @@ -270,7 +270,7 @@ InitializeCpuExceptionHandlersEx ( > AsmReadGdtr (&Gdtr); > > EssData.X64.Revision = CPU_EXCEPTION_INIT_DATA_REV; > - EssData.X64.KnownGoodStackTop = (UINTN)mNewStack; > + EssData.X64.KnownGoodStackTop = (UINTN)mNewStack + sizeof (mNewStack); > EssData.X64.KnownGoodStackSize = CPU_KNOWN_GOOD_STACK_SIZE; > EssData.X64.StackSwitchExceptions = CPU_STACK_SWITCH_EXCEPTION_LIST; > EssData.X64.StackSwitchExceptionNumber = CPU_STACK_SWITCH_EXCEPTION_NUMBER; > Can you add the following to the commit message? Fixes: 0ff5aa9cae1ea276668fa4398d047aa9fda3c2c7 With that, Reviewed-by: Laszlo Ersek Thanks Laszlo