From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.33685.1661270230127944440 for ; Tue, 23 Aug 2022 08:57:10 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5DEA0113E; Tue, 23 Aug 2022 08:57:13 -0700 (PDT) Received: from [10.34.100.116] (pierre123.nice.arm.com [10.34.100.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA49E3F718; Tue, 23 Aug 2022 08:57:08 -0700 (PDT) Message-ID: <768047aa-f65e-b21f-1780-db2dcc341610@arm.com> Date: Tue, 23 Aug 2022 17:57:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [PATCH 0/6] ArmPkg/SMBIOS fixes and improvements To: devel@edk2.groups.io, nhi@os.amperecomputing.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> From: "PierreGondois" In-Reply-To: <20220823105926.1379824-1-nhi@os.amperecomputing.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Some of the patches are modifying: ArmPkg/Universal/Smbios/SmbiosMiscDxe/ This folder has been ignored by the EccCheck done in the CI in order to enable uncrustify: https://edk2.groups.io/g/devel/topic/87268735#83984 Indeed, the EccCheck is only run on the code which is modified, and a lot of code was modified to enable uncrustify, ignoring this folder was the easiest solution. The EccCheck doesn't support the declaration of functions with macros. For intance at: https://github.com/tianocore/edk2/blob/dfdba857a6b6a708e754ddb1a04086a3402acdef/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c#L38 the following errors should normally be triggered: - "The body of a function should be contained by open and close braces that must be in the first column" - "Function name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters" - "Any optional functional modifiers should exist and next to the return type" This is just to be sure everyone is aware of the situation, Regards, Pierre On 8/23/22 12:59, Nhi Pham via groups.io wrote: > This patchset is to update the ArmPkg/SMBIOS for fixes and improvements. > > Minh Nguyen (5): > ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib > ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call > ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" > ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 > ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib > > Nhi Pham (1): > ArmPkg/SmbiosMiscDxe: Support fetching System UUID > > ArmPkg/Include/Library/OemMiscLib.h | 37 +++++++++++++++- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 46 ++++++++++++++++++++ > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 8 +++- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 6 +-- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 32 +++++++++----- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 3 +- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +----- > 7 files changed, 117 insertions(+), 28 deletions(-) >