public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: edk2-devel@lists.01.org
Subject: Re: [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
Date: Wed, 18 Jul 2018 10:38:58 +0800	[thread overview]
Message-ID: <7680a57a-2b1e-8ed9-c454-01ead4648d09@Intel.com> (raw)
In-Reply-To: <20180717105925.42044-1-Alexei.Fedorov@arm.com>

On 7/17/2018 6:59 PM, AlexeiFedorov wrote:
> This patch adds UefiShellAcpiViewCommandLib INF file into
> [Components] section of ShellPkg.dsc so this library can be built
> in ShellPkg level build.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
> ---
> All the changes can be reviewed at
> https://github.com/AlexeiFedorov/edk2/tree/298_add_acpiview_lib_v1
> 
> Notes:
>      v1:
>      - add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> 
>   ShellPkg/ShellPkg.dsc | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> index 21038ae8d596a9b5a520aca704494280cf8afd55..cb2a2422edd7b5ea6279ea81fe0ba9cc78511216 100644
> --- a/ShellPkg/ShellPkg.dsc
> +++ b/ShellPkg/ShellPkg.dsc
> @@ -2,6 +2,7 @@
>   # Shell Package
>   #
>   # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2018, Arm Limited. All rights reserved.<BR>
>   #
>   #    This program and the accompanying materials
>   #    are licensed and made available under the terms and conditions of the BSD License
> @@ -90,6 +91,7 @@ [Components]
>     # This helps developers test changes and how they affect the package.
>     #
>     ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> +  ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
>     ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>     ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>     ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray


  reply	other threads:[~2018-07-18  2:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 10:59 [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc AlexeiFedorov
2018-07-18  2:38 ` Ni, Ruiyu [this message]
2018-07-25 16:29   ` Alexei Fedorov
2018-07-25 20:47     ` Carsey, Jaben
2018-07-25 21:00       ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7680a57a-2b1e-8ed9-c454-01ead4648d09@Intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox