From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7063E2097F544 for ; Tue, 17 Jul 2018 19:38:29 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2018 19:38:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,368,1526367600"; d="scan'208";a="72251253" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by fmsmga004.fm.intel.com with ESMTP; 17 Jul 2018 19:38:27 -0700 To: edk2-devel@lists.01.org References: <20180717105925.42044-1-Alexei.Fedorov@arm.com> From: "Ni, Ruiyu" Message-ID: <7680a57a-2b1e-8ed9-c454-01ead4648d09@Intel.com> Date: Wed, 18 Jul 2018 10:38:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <20180717105925.42044-1-Alexei.Fedorov@arm.com> Subject: Re: [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 02:38:29 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/17/2018 6:59 PM, AlexeiFedorov wrote: > This patch adds UefiShellAcpiViewCommandLib INF file into > [Components] section of ShellPkg.dsc so this library can be built > in ShellPkg level build. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > --- > All the changes can be reviewed at > https://github.com/AlexeiFedorov/edk2/tree/298_add_acpiview_lib_v1 > > Notes: > v1: > - add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc > > ShellPkg/ShellPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc > index 21038ae8d596a9b5a520aca704494280cf8afd55..cb2a2422edd7b5ea6279ea81fe0ba9cc78511216 100644 > --- a/ShellPkg/ShellPkg.dsc > +++ b/ShellPkg/ShellPkg.dsc > @@ -2,6 +2,7 @@ > # Shell Package > # > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2018, Arm Limited. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -90,6 +91,7 @@ [Components] > # This helps developers test changes and how they affect the package. > # > ShellPkg/Library/UefiShellLib/UefiShellLib.inf > + ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > Reviewed-by: Ruiyu Ni -- Thanks, Ray