From: Andrew Fish <afish@apple.com>
To: Mike Kinney <michael.d.kinney@intel.com>
Cc: edk2-devel@lists.01.org, Star Zeng <star.zeng@intel.com>,
Eric Dong <eric.dong@intel.com>
Subject: Re: [Patch 0/2] MdeModulePkg: Fix XCODE5 build failures
Date: Wed, 24 May 2017 16:42:38 -0700 [thread overview]
Message-ID: <76AAB3B2-D00B-41F5-A3E5-33EF979044AC@apple.com> (raw)
In-Reply-To: <1495581027-18592-1-git-send-email-michael.d.kinney@intel.com>
Reviewed-by: Andrew Fish <afish@apple.com <mailto:afish@apple.com>>
> On May 23, 2017, at 4:10 PM, Michael Kinney <michael.d.kinney@intel.com> wrote:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=572
>
> Fix local variable type in RegularExpressionDxe and an X64
> GAS(.S) file assembly instructon format in DebugSupportDxe.
> Both of these are generatingf build failures with the
> XCODE5 tool chain when building MdeModulePkg.dsc.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Michael Kinney (2):
> MdeModulePkg/RegularExpressionDxe: Fix XCODE5 build failure
> MdeModulePkg/DebugSupportDxe: Fix XCODE5 build failure
>
> MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.S | 4 ++--
> MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.6.3.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-05-24 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 23:10 [Patch 0/2] MdeModulePkg: Fix XCODE5 build failures Michael Kinney
2017-05-23 23:10 ` [Patch 1/2] MdeModulePkg/RegularExpressionDxe: Fix XCODE5 build failure Michael Kinney
2017-05-23 23:10 ` [Patch 2/2] MdeModulePkg/DebugSupportDxe: " Michael Kinney
2017-05-24 0:58 ` [Patch 0/2] MdeModulePkg: Fix XCODE5 build failures Zeng, Star
2017-05-24 23:42 ` Andrew Fish [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-05-23 23:03 Michael Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76AAB3B2-D00B-41F5-A3E5-33EF979044AC@apple.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox