From: "GuoMinJ" <newexplorerj@gmail.com>
To: devel@edk2.groups.io
Cc: GuoMinJ <newexplorerj@gmail.com>
Subject: [PATCH] CryptoPkg: ECC issue.
Date: Tue, 25 Feb 2020 09:53:29 +0800 [thread overview]
Message-ID: <76a4ba530dea866c743b2f8f85a1672a34a35e52.1582595594.git.newexplorerj@gmail.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
Some issue is reported by ECC tool, correct it.
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
.../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++
CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
index 34d5f410b0..b503a5708b 100644
--- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
+++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
@@ -32,6 +32,15 @@ GetCryptoServices (
return (VOID *)mCryptoProtocol;
}
+/**
+ Locate the valid Crypto Protocol.
+
+ @param ImageHandle The firmware allocated handle for the EFI image.
+ @param SystemTable A pointer to the EFI System Table.
+
+ @retval EFI_SUCCESS The constructor executed correctly.
+ @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
+**/
EFI_STATUS
EFIAPI
DxeCryptLibConstructor (
diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
index b4d8675ddd..046320353b 100644
--- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
+++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
@@ -17,7 +17,7 @@
FILE_GUID = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
MODULE_TYPE = BASE
VERSION_STRING = 1.0
- LIBRARY_CLASS = BaseHashApiLib
+ LIBRARY_CLASS = HashApiLib
#
# The following information is for reference only and not required by the build tools.
--
2.17.1
next reply other threads:[~2020-02-25 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 1:53 GuoMinJ [this message]
2020-03-04 8:29 ` [edk2-devel] [PATCH] CryptoPkg: ECC issue Zhang, Shenglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76a4ba530dea866c743b2f8f85a1672a34a35e52.1582595594.git.newexplorerj@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox