[PATCH] CryptoPkg: ECC issue.

[PATCH] CryptoPkg: ECC issue.

[GuoMinJ]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552

Some issue is reported by ECC tool, correct it.

Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
 .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c      | 9 +++++++++
 CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf      | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
index 34d5f410b0..b503a5708b 100644
--- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
+++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
@@ -32,6 +32,15 @@ GetCryptoServices (
   return (VOID *)mCryptoProtocol;
 }
 
+/**
+  Locate the valid Crypto Protocol.
+
+  @param  ImageHandle   The firmware allocated handle for the EFI image.
+  @param  SystemTable   A pointer to the EFI System Table.
+
+  @retval EFI_SUCCESS   The constructor executed correctly.
+  @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
+**/
 EFI_STATUS
 EFIAPI
 DxeCryptLibConstructor (
diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
index b4d8675ddd..046320353b 100644
--- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
+++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
@@ -17,7 +17,7 @@
   FILE_GUID                      = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = BaseHashApiLib
+  LIBRARY_CLASS                  = HashApiLib
 
 #
 # The following information is for reference only and not required by the build tools.
-- 
2.17.1

Re: [edk2-devel] [PATCH] CryptoPkg: ECC issue.

[Zhang, Shenglei]

Hi Guomin,

Please update the subject and let us know the brief change through it.
The details could be placed in commit message.

When sending a patch of next version,  you can update the subject prefix like
"[PATCH v2] CryptoPkg: *** ".

Thanks,
Shenglei

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Tuesday, February 25, 2020 9:53 AM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH] CryptoPkg: ECC issue.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> Some issue is reported by ECC tool, correct it.
> 
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c      | 9 +++++++++
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf      | 2 +-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> index 34d5f410b0..b503a5708b 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> @@ -32,6 +32,15 @@ GetCryptoServices (
>    return (VOID *)mCryptoProtocol;
>  }
> 
> +/**
> +  Locate the valid Crypto Protocol.
> +
> +  @param  ImageHandle   The firmware allocated handle for the EFI image.
> +  @param  SystemTable   A pointer to the EFI System Table.
> +
> +  @retval EFI_SUCCESS   The constructor executed correctly.
> +  @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
> +**/
>  EFI_STATUS
>  EFIAPI
>  DxeCryptLibConstructor (
> diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> index b4d8675ddd..046320353b 100644
> --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> @@ -17,7 +17,7 @@
>    FILE_GUID                      = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = BaseHashApiLib
> +  LIBRARY_CLASS                  = HashApiLib
> 
>  #
>  # The following information is for reference only and not required by the
> build tools.
> --
> 2.17.1
> 
> 
>