From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7A56821A02937 for ; Tue, 27 Nov 2018 04:53:24 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AEB480F88; Tue, 27 Nov 2018 12:53:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-96.rdu2.redhat.com [10.10.120.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91E675C6B1; Tue, 27 Nov 2018 12:53:22 +0000 (UTC) To: Jeremiah Cox , stephano Cc: "edk2-devel@lists.01.org" References: <4330857f-4e27-632f-6f82-6fc6ec636b2e@linux.intel.com> From: Laszlo Ersek Message-ID: <76cb4d25-7eff-b19b-0dd5-2fcc3a1e7d82@redhat.com> Date: Tue, 27 Nov 2018 13:53:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 27 Nov 2018 12:53:24 +0000 (UTC) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [edk2-announce] Research Request X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 12:53:24 -0000 X-Groupsio-MsgNum: 33067 Content-Type: multipart/mixed; boundary="------------B2AD4A78D8A02A210017A064" Content-Language: en-US --------------B2AD4A78D8A02A210017A064 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 11/26/18 22:43, Jeremiah Cox via edk2-devel wrote: > Feedback on GitHub as follows… > > >> 1. No Lock-In - What automated data export is available? >> We want to be able to leave and take all our data with us. "Data" here >> includes: review comments, pull requests / patches (including metadata), >> old (rejected) pull requests and metadata, issue tracker entries and >> comments (if issue tracker included). This archiving should be >> automated, not something we do by hand. > > Untested, but might these all be easily satisfied by subscribing a mailing list to GitHub notifications? > https://help.github.com/articles/about-notifications/#watching-notifications > https://help.github.com/articles/about-email-notifications/ No, they are insufficient. Following the last link above ("about-email-notifications"), one finds several other links; and one of those is: https://help.github.com/articles/about-notifications/ This article says, GitHub sends participating notifications when you're directly involved in activities or conversations within a repository or a team you're a member of. You'll receive a notification when: [...] - You open, comment on, or close an issue or pull request. [...] This is demonstrably false. I'm a member of the TianoCore organization, I have commented on, and closed (rejected): https://github.com/tianocore/edk2/pull/133 and I *never* received an email notification about my *own* comment / action. I only received the initial email, about the pull request being opened (attached for reference). * Another pull request, demonstrating the same issue (original email also attached): https://github.com/tianocore/edk2/pull/127 * And here's the same problem, just in a different situation: someone made a comment on a commit, using the github WebUI: https://github.com/tianocore/edk2/commit/253d81c71f67e1ab218450b87370abd3bf01d571#commitcomment-27830037 I responded there. I received an email -- attached -- only about that other person's initial comment, and never received an email about my own. So, no. I'm already subscribed to github notofications, and their coverage is insufficient. > > Alternatively, the GitHub REST API appear to offer full export capability of all information & metadata: > https://developer.github.com/v3/git/commits/#get-a-commit > https://developer.github.com/v3/pulls/#list-pull-requests > https://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request > https://developer.github.com/v3/issues/events/#list-events-for-a-repository > https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue > https://developer.github.com/v3/activity/events/#list-repository-events > https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment > * the above allows you to export all of the thumbs up/down, smileys, hearts ... that users have given to pull request & issue comments :) This is again insufficient. We shouldn't have to cobble together our own archival soluion from low-level APIs. GitHub has extremely good availability. I doubt that any hack we could come up with (and that we'd have to run ourselves, elsewhere), could muster the same service level. This means that sooner or later our mirroring hack would go down, while GitHub would stay up, and then we'd start losing updates to our "mirror". The offline & full coverage audit trail has to be generated by a core part of the service. [...] >> 3. Flexible Workflow - Can we use email patches / email review as well >> as pull requests / web UI review?** >> 3a. Can we can attach review comments to specific code *and* commit >> message locations? >> 3b. Are the comments faithfully translated to notification emails >> (including the locations in code the comment is addressing)? >> 3c. Are old topic branches (rejected or updated pull requests) >> available even after being rejected? (i.e. are they ever deleted?) >> 3d. Is plain text supported in code review comments? >> **To be clear, it is acceptable if the system handles only pull requests >> and a web UI. We do require, however, a *read-only* email notification >> system that thoroughly documents our process. > > We propose that all review & issue tracking are through GitHub web, REST, or Graph APIs. Email becomes read-only for notification and archival only. > 3A: Yes. > 3B: From our testing this appears to be yes. > 3C: GitHub can be configured to keep rejected and updated pull requests. > 3D: Both plain text and markdown work This sounds good, but can you please clarify 3C? In particular, what does an "updated pull request" mean? Here's the specific workflow I care about. * Alice implements a new feature for edk2 and opens a pull request. The pull request refers to her branch that is called "alices-grand-feature", with the branch HEAD at commit FOO. * Brenda reviews the commits on that branch, and makes some comments on various patches: - she attaches some requests for clarification to specific lines of some commit messages (i.e., not code), - she also attaches some suggestions to specific code lines. * A few days later Alice comes back with the reworked patch set. In her own repository, she rebased the "alices-grand-feature" branch, and now the HEAD points at commit BAR. In Alice's own repository, the original HEAD commit FOO is now lost (no branch references it). So are all the commits on the original (v1) topic branch that used to lead up to FOO. * Brenda gets an email notification that Alice refreshed her pull request, with the remote topic branch -- which is offered under the same name "alices-grand-feature" -- now pointing at commit BAR. Brenda has since forgotten some of the comments she had made under v1, and now she scrolls up to see the original v1 commits (culminating in FOO) from Alice, and her own v1 comments. GitHub supports this -- i.e., the complete git history leading up to now-unreferenced commit FOO will be preserved for eternity, together with all location-sensitive comments made for it -- because: [[please fill in]]. > Some additional questions we feel are important: > > > * Does the workflow facilitate automated validation & PR-Gates? > GitHub: Yes > Phabricator: https://secure.phabricator.com/T9456 : “Writing lots of integrations for third-party software is broadly something the upstream is not well equipped for.” > Travis-CI further declined support for Phabricator: https://github.com/travis-ci/travis-ci/issues/2143#issuecomment-124150608 “we have no immediate plans to add this feature” > > > * Does workflow allow easy contribution process? > GitHub: Yes, well-known and well-documented > > > * Does it have comprehensive documentation? > GitHub: Yes > > > * Does it have a comprehensive programmatic API that enables extensibility, with numerous online examples? > GitHub: Yes > > > * Does workflow facilitate different server-enforced policies for different branches? > GitHub: Yes Right, those are good and important features. Thanks, Laszlo --------------B2AD4A78D8A02A210017A064 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Attached Message" Return-Path: noreply@github.com Received: from zmta04.collab.prod.int.phx2.redhat.com (LHLO zmta04.collab.prod.int.phx2.redhat.com) (10.5.81.11) by zmail17.collab.prod.int.phx2.redhat.com with LMTP; Thu, 30 Aug 2018 01:31:51 -0400 (EDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by zmta04.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id CE902DA80A for ; Thu, 30 Aug 2018 01:31:51 -0400 (EDT) Received: by smtp.corp.redhat.com (Postfix) id C993EC1F67; Thu, 30 Aug 2018 05:31:51 +0000 (UTC) Delivered-To: lersek@redhat.com Received: from mx1.redhat.com (ext-mx20.extmail.prod.ext.phx2.redhat.com [10.5.110.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF816C1F66 for ; Thu, 30 Aug 2018 05:31:51 +0000 (UTC) Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FACF308624C for ; Thu, 30 Aug 2018 05:31:50 +0000 (UTC) Date: Wed, 29 Aug 2018 22:31:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1535607109; bh=trbFlDL75KRaTAFfviln7s72KJeoo9uBhDqoCrRPWo4=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=tCyaRLr1VOphsdXBmZjwsQXEtOcbJd/JkIYFUcrczEe0bk0UikXzAG4RuggUULvQ5 pJoKrJRJTJi74i/kU/EHZVgudKWSon7zkoKMoywPTzRKsEtQtDfXHH2aKYbHnkyAcn aGzfwRjbrQ2U5dta1RquUIsydqvZoN0M5/+D7Aqg= From: Henri Yandell Reply-To: tianocore/edk2 To: tianocore/edk2 Cc: Subscribed Message-ID: Subject: [tianocore/edk2] Adding missing 'or' (#133) Mime-Version: 1.0 Precedence: list X-GitHub-Sender: hyandell X-GitHub-Recipient: lersek X-GitHub-Reason: subscribed List-ID: tianocore/edk2 List-Archive: https://github.com/tianocore/edk2 List-Post: List-Unsubscribe: , X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: lersek@redhat.com X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 212 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 30 Aug 2018 05:31:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 30 Aug 2018 05:31:50 +0000 (UTC) for IP:'192.30.252.195' DOMAIN:'out-4.smtp.github.com' HELO:'out-4.smtp.github.com' FROM:'noreply@github.com' RCPT:'' X-RedHat-Spam-Score: -6.11 (DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_PASS,T_DKIMWL_WL_HIGH) 192.30.252.195 out-4.smtp.github.com 192.30.252.195 out-4.smtp.github.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.49 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit When the CLA was created from the Apache ICLA, the option for a CCLA was removed. When this was done the 'or' was lost in the text. This puts it back in so that you represent that you have received permission __or__ your employer has waived such rights. You can view, comment on, or merge this pull request online at: https://github.com/tianocore/edk2/pull/133 -- Commit Summary -- * Adding missing 'or' -- File Changes -- M Contributions.txt (2) -- Patch Links -- https://github.com/tianocore/edk2/pull/133.patch https://github.com/tianocore/edk2/pull/133.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tianocore/edk2/pull/133 --------------B2AD4A78D8A02A210017A064 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Attached Message" Return-Path: noreply@github.com Received: from zmta04.collab.prod.int.phx2.redhat.com (LHLO zmta04.collab.prod.int.phx2.redhat.com) (10.5.81.11) by zmail17.collab.prod.int.phx2.redhat.com with LMTP; Wed, 6 Jun 2018 11:06:06 -0400 (EDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by zmta04.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id C2295D0DBF for ; Wed, 6 Jun 2018 11:06:06 -0400 (EDT) Received: by smtp.corp.redhat.com (Postfix) id A8BFE1001F45; Wed, 6 Jun 2018 15:06:06 +0000 (UTC) Delivered-To: lersek@redhat.com Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F0FF1062244 for ; Wed, 6 Jun 2018 15:06:06 +0000 (UTC) Received: from out-13.smtp.github.com (out-13.smtp.github.com [192.30.254.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9668881122 for ; Wed, 6 Jun 2018 15:05:50 +0000 (UTC) Date: Wed, 06 Jun 2018 08:05:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528297550; bh=dhzZ6NLT0jgl3NMH31i4qZf7Sv6SyFLtksv9zTFvX8Q=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=f4/VGiaz0w+gtCrapYKfNGCFBRHGqWGYRnclVHlpRiV+qEMEZG5DztyVu5CAOaNtZ Hyot8Anp8e1DawpoUJDG5mQfXABtnxQhp6a+9g3g/iPCVJApk1b9GBR40oI1ktJEV8 rRExqaFA1S87GblrR8ZpMhTwWrCuVvEvIfvBC2NQ= From: Anton Filatov Reply-To: tianocore/edk2 To: tianocore/edk2 Cc: Subscribed Message-ID: Subject: [tianocore/edk2] Fix for Microsoft Visual Studio 2017 (#127) Mime-Version: 1.0 Precedence: list X-GitHub-Sender: ya-enot X-GitHub-Recipient: lersek X-GitHub-Reason: subscribed List-ID: tianocore/edk2 List-Archive: https://github.com/tianocore/edk2 List-Post: List-Unsubscribe: , X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: lersek@redhat.com X-Greylist: Sender passed SPF test, ACL 227 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 06 Jun 2018 15:05:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 06 Jun 2018 15:05:50 +0000 (UTC) for IP:'192.30.254.196' DOMAIN:'out-13.smtp.github.com' HELO:'out-13.smtp.github.com' FROM:'noreply@github.com' RCPT:'' X-RedHat-Spam-Score: -0.89 (DKIM_SIGNED,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID) 192.30.254.196 out-13.smtp.github.com 192.30.254.196 out-13.smtp.github.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit bin files for different architectures are now located in SDK version specific sub folder You can view, comment on, or merge this pull request online at: https://github.com/tianocore/edk2/pull/127 -- Commit Summary -- * Fix for Microsoft Visual Studio 2017 -- File Changes -- M BaseTools/Conf/tools_def.template (2) -- Patch Links -- https://github.com/tianocore/edk2/pull/127.patch https://github.com/tianocore/edk2/pull/127.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tianocore/edk2/pull/127 --------------B2AD4A78D8A02A210017A064 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Attached Message" Return-Path: noreply@github.com Received: from zmta01.collab.prod.int.phx2.redhat.com (LHLO zmta01.collab.prod.int.phx2.redhat.com) (10.5.81.8) by zmail17.collab.prod.int.phx2.redhat.com with LMTP; Wed, 28 Feb 2018 01:13:34 -0500 (EST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by zmta01.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id 63C2418669F for ; Wed, 28 Feb 2018 01:13:34 -0500 (EST) Received: by smtp.corp.redhat.com (Postfix) id 5ECC760C8B; Wed, 28 Feb 2018 06:13:34 +0000 (UTC) Delivered-To: lersek@redhat.com Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 57DBD60BE3 for ; Wed, 28 Feb 2018 06:13:34 +0000 (UTC) Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext6.iad.github.net [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55BE27FEA3 for ; Wed, 28 Feb 2018 06:13:33 +0000 (UTC) Date: Tue, 27 Feb 2018 22:13:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1519798412; bh=fU5OY7Qvt6XsmKyIsBqw+0hBvYbV+VR0dwImqr1H/z4=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mRZzVBKPF5vTttAMeFTR3Y9nFjL2g765v3J/PARGrVJhkZ7cRbE4d3vluVzkySNNj bHztU/bP/TmMLd8xDwxZc8MlPvCUZd7tflOZMcQf+e3oDzMXm1Xe27Uve/OEWEav2m AqlpjELg2O480wLPZLvtEr2lloD/Q75gH3KlsEDE= From: 992548897 Reply-To: tianocore/edk2 To: tianocore/edk2 Cc: Laszlo Ersek , Author Message-ID: In-Reply-To: References: Subject: Re: [tianocore/edk2] OvmfPkg: update -D E1000_ENABLE from Intel PROEFI v.07 to BootUtil v.22 (253d81c) Mime-Version: 1.0 Precedence: list X-GitHub-Sender: 992548897 X-GitHub-Recipient: lersek X-GitHub-Reason: author List-ID: tianocore/edk2 List-Archive: https://github.com/tianocore/edk2 List-Post: List-Unsubscribe: , X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: lersek@redhat.com X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 207 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 28 Feb 2018 06:13:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 28 Feb 2018 06:13:33 +0000 (UTC) for IP:'192.30.252.197' DOMAIN:'github-smtp2-ext6.iad.github.net' HELO:'github-smtp2b-ext-cp1-prd.iad.github.net' FROM:'noreply@github.com' RCPT:'' X-RedHat-Spam-Score: -3.818 (DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_IMAGE_ONLY_24,HTML_MESSAGE,RCVD_IN_DNSWL_HI,SPF_PASS) 192.30.252.197 github-smtp2-ext6.iad.github.net 192.30.252.197 github-smtp2-ext6.iad.github.net X-Scanned-By: MIMEDefang 2.83 on 10.5.110.25 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, I'd learned that currently only 1024*768 resolution is supported for win7, however, i'd like to know why and is there any plan for further support for other resolutions on win7 system. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/tianocore/edk2/commit/253d81c71f67e1ab218450b87370abd3bf01d571#commitcomment-27830037 --------------B2AD4A78D8A02A210017A064--