From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.45]) by mx.groups.io with SMTP id smtpd.web08.382.1661273893246314937 for ; Tue, 23 Aug 2022 09:58:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DdXHOXnk; spf=pass (domain: arm.com, ip: 40.107.8.45, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EuHONFrkGiNSXX4udNyD9aoDv2ozJeyBxx7m7eCiY2ldFUV+9WjQx1nJAa8sGWct4qySTDOq6HEfRGETcT6TnN85VddTI1CTYgtwGibZcf1yVnhlpbe781IsAbrhJISVUDR5l2Z+dDSNG4Lflf8h57Teua1dQeDB+t+PDs3Pcne13MRBhaIt5wNC6PvAcgahil3m4uOc/nNaYinvFammvtEfrLCdN39xOBXz4SK3U7bgb+w5Um+iojVmyo+urT9vJeBRLFHBtDt7TlIm27PUPOGTlgc/OsF1MToqT1/7j/RpGGWnakHBzGepBTm0Ne7+r3L2hSdDCt644jC+/xjnAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ea1L+fg3T2QSUUiPNV88Pjy9vkA1W8TgJglDFOb2ccc=; b=Lojy6ag5Aj31hHru6j5gngO+dZ2lrOtBbKMAz5mXnDoXtxgxZJVSFBG2usjM6hCcKiG2VOybXzu619phf52EQmUaceAXAQBf/CYpGjWPYTFWKoUi6GfBuIoE12owom+lPuH8xtN0tsBQpLeb9vGwTlUxGDsXdQiNbN3ed7bFIHMFFFhSiepLso872NjR+bL8gZ0rXEjEkHVoQKebIV62x5/2dwRQfpzRiVPu8gZIXzrNNHw0ea1fqCa2t/HQaGYsCBFl4QNfXSFW4Wwf/jDgj7+RAEq0LgZnMthufDs+Nlj5Q0gP1oOaHkXofjzCqHXMtqpOxCzW6ObLdSCfCVwUvg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ea1L+fg3T2QSUUiPNV88Pjy9vkA1W8TgJglDFOb2ccc=; b=DdXHOXnkVWFyYSJ6qG51EgFDUsRgUARIcz56o1N36ycS+2KelyFhQGamIDgsrcYgu3mV0Y/dQSiyyzy3ldJDISjHp9wvrlw9ritxmRhY9DkG9T8ShUKTEaAOj9oEIIgtPJnjhhuw4v68HQurTCV8BYyFgxHO4EmrM/6+yVTxKq4= Received: from AM6P191CA0023.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::36) by AM9PR08MB6083.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.19; Tue, 23 Aug 2022 16:58:08 +0000 Received: from AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::7f) by AM6P191CA0023.outlook.office365.com (2603:10a6:209:8b::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14 via Frontend Transport; Tue, 23 Aug 2022 16:58:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT021.mail.protection.outlook.com (100.127.140.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Tue, 23 Aug 2022 16:58:07 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 23 Aug 2022 16:58:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: bfc3b3bea7b2fb82 X-CR-MTA-TID: 64aa7808 Received: from f22a15e20d6a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F4429568-987C-4050-A5A0-4C3073E3BE38.1; Tue, 23 Aug 2022 16:58:01 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f22a15e20d6a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 Aug 2022 16:58:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEQIpQxZgB2axptr7bj9vxCQT0C67eu/ynNskAi/0PwfSGE6HtKRuaJrqedKVL2y2Xo5oPTsBwHCG/6y9XUK6Roa7penXOwh8K8jmLvfA/LA4k8FrtWt+mZNWrtAJU3ZoVefNS1tL3JncSZ1mhqyX7QxF5U1DzjQ9hhqsFE6g9sqGgMvEE0NwaCOV3FI12wx2ADdCANkL/72WhhzOM7a1SAdlLgrzmqNJ0DxHLGzNTw0iX3zpTCPpzMa4iIY9CXKaKhZruGYAl2P/Q/8Vg8i8bk3ENL3EbKnyNuD3mPu5nXtaJXvabhdcwqyH7Dn7Kn/EMoJkTKtwHdaHc5+2CP9QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ea1L+fg3T2QSUUiPNV88Pjy9vkA1W8TgJglDFOb2ccc=; b=CD9H2oS6F2aCOuBJBkQLnDEbPr9BjgRebYjz4o31g2wouRaXiLmb5OfcjlUsCdFToU+dJEc7mT4NecYfvV8nofGaPBSSssnKd+FrHHSLAsCAr1L0AVNyYCw6cX/gsvDWUFAAzfw1Xpppy7Xwkyr5kkJoMVrB7tKbFjgrMA360rmbzNiEYJEvPZ2mevbgFVxipOVGhZZRVXZ3xS+8GdweY8gGabVeqCEgcXLR8dsy+955Uxg7t05EW74Bt1+Fd8GjHkCTB1ZfHvMV537++rhy+55CzBZRBsDTe6RT3nibs3rjDrAodyUQETOuWAzSnGIIlc5PyLh5RXzYzNCUdqLB3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ea1L+fg3T2QSUUiPNV88Pjy9vkA1W8TgJglDFOb2ccc=; b=DdXHOXnkVWFyYSJ6qG51EgFDUsRgUARIcz56o1N36ycS+2KelyFhQGamIDgsrcYgu3mV0Y/dQSiyyzy3ldJDISjHp9wvrlw9ritxmRhY9DkG9T8ShUKTEaAOj9oEIIgtPJnjhhuw4v68HQurTCV8BYyFgxHO4EmrM/6+yVTxKq4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM4PR08MB2658.eurprd08.prod.outlook.com (2603:10a6:205:a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.21; Tue, 23 Aug 2022 16:57:57 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%6]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 16:57:57 +0000 Message-ID: <76d4e559-356b-a898-604c-0160d7c59d72@arm.com> Date: Tue, 23 Aug 2022 17:57:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib To: Nhi Pham , devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , "nd@arm.com" References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> <20220823105926.1379824-7-nhi@os.amperecomputing.com> From: "Sami Mujawar" In-Reply-To: <20220823105926.1379824-7-nhi@os.amperecomputing.com> X-ClientProxiedBy: LO2P123CA0015.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::27) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 921f90aa-9c34-4e0b-1243-08da8528a76e X-MS-TrafficTypeDiagnostic: AM4PR08MB2658:EE_|AM7EUR03FT021:EE_|AM9PR08MB6083:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kPxyhr7cTh4E2ccUgO8Qo9yzDZ6rr4Bs+iiOxC1wUz2C40/aDCjxkh7MEEMa41RX8H7VTNZDuKHVOJrpx+ED7DsO4oLn1wF5z75xF8z3xFp/+9wP95a033+D8+lcNrHVAtBpWzJHoLJErr3/mZLGKJ71rDUiqifWIZtrr6sv7TpC401wfhGql21wOdOd6JaqpO5wWT2Yw+waKAyvO6x9llNiA+zeIg2Ybo95q6V1WnE7HdNjMu/8Coc0l2EBfws+pm/tsVlSsvDzgcfj8yoAzAccpPE2yp6gx0I6Zv4kRY4PRTc4kqyOcTD7HWGzgc//c5glgA4qh8UwjjdRiHFLP8/W1mElQtCEUunqKgj15OFvgS83lhgZTSu0gKnF9qurCvsDWG2n8KMhfE80H9HBPCbD8FSOMDfmmt2mCZBplCnGHJf3Ffuanw8yMn19xpuMOvwuAvRYu1mLu98jPiEp7QAewd7sp6FMq+5IthZDyW1vt/6ovC7segcJUihuciLvlOfYnYg29fECXFk9V4sGMVS6sxsxEmoZhwlGTt5jUVRAP8WjqRHwVOEKe6QCD7CyAoFCjN5F3Zo6COh6WQxaxMB/aamT8/C78LTaChl17i9b7AtK3c5wejeYIzv5uItyVx8aeKGeJV61A9G/b1Xoq/h1eBjWwYypmRnHsemsMlsy4t0+V4mHgTa2K2kEsQGMU5NyxeMr8lrt8FojU12qLWNw5xXYIC4XoYFyBoNZvbCKXkfDrg4KmLq4y0ORZpV9/ikrpRWcAq8b03lTm30j+cCgU9Q0RGnVzaKetpYeIMn77kcS9QeFMX2aP6nbmtoFBb5NAqCCCznrxn5i4u0avA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(346002)(39860400002)(376002)(83380400001)(86362001)(31696002)(8676002)(38100700002)(66476007)(4326008)(66556008)(66946007)(6486002)(8936002)(478600001)(54906003)(316002)(26005)(6506007)(186003)(2906002)(53546011)(2616005)(44832011)(6512007)(31686004)(41300700001)(5660300002)(36756003)(45980500001)(43740500002)(44824005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2658 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 34405de0-61b8-4ca7-4971-08da8528a127 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KtUdmJ5lL8Fvk710+TRAVxzXxIG1Z5CVwwFV8gO+rrdBAqYs38Vx1VI1VkKq74QnI0eA6CwCjlDCkdjhUIOO4sv8BkU1E1xa5GCopHhf2z43g9vkccLr1C+2p2XdBc0LJACl5gm+H1I0gLDVzrqGoXkmWoVsGQYVBpmHwwCSG8lJesQz6Tc2scaWfV+3Uk8lNqSjXlMXjRpaSmkDCmjCBMslrPQWCWAHjMGT4q93sCI+z2fvuppCNE5z0K4LvHTnjIPHB+Z86GWYDgmaSK6FJ6XFBKJQvalS61qaKI5Y1ECHz9hLx+ieGHdlQIdhiMVpIpsn9/949N312AYfW8bm16ASgUjqf175Az7S8qILE300pVHLnYCofbFs2OdxbRPHhVsACsLPH2sPz/xJhV9mJlYhxB8Mq2GWBago5RWK12Q6ZjABF9vGwQgAWWGv8jkws5pNPxlMWv5YhIK3U0q9I+yc1ab8LajyWmpT08gtQi+eW3EbYriYHsl9w5POTfvnewvQzWqyYF6Y00gB3WBXrE1iBsgyl34V3N4RGjBbDKDgDR9MtZTcldJVntJF1Dz46hhv8chPNoHF07ndU3sI6dWdaVb0qqMnH9lNG0aad2LOQieYfAUplh+FxOsI1i/XslrEHHOZclUrsOpTAbqI1A8NT+SK8folOaxcbvtxXMfxNf5CEneds5WZLHIYfO1pOOFN3ELLe84iOsAmE25FvqX3B8a1+VkssPPEhZgJqiyHPlv8vAJnI+8M2UExux0AXuxjW5eU/y/0hMecRyrBZKRsSUEYVZkfvwqx/JUHWtZPfYYZkapQF+OkxwFaNj78QMIqT9prUdVHqVhhR6oVIQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(36840700001)(46966006)(40470700004)(41300700001)(5660300002)(6486002)(8936002)(478600001)(31696002)(53546011)(2906002)(6506007)(44832011)(40460700003)(26005)(6512007)(81166007)(82740400003)(356005)(86362001)(40480700001)(82310400005)(36860700001)(186003)(336012)(2616005)(47076005)(83380400001)(70586007)(8676002)(70206006)(31686004)(4326008)(316002)(36756003)(54906003)(43740500002)(44824005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 16:58:07.9760 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 921f90aa-9c34-4e0b-1243-08da8528a76e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6083 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: > From: Minh Nguyen > > In some scenarios, the information of Bios Version, Bios Release > and Embedded Controller Firmware Release are fetched during UEFI > booting. This patch supports updating those fields dynamically > when the PCDs are empty. > > Signed-off-by: Nhi Pham > --- > ArmPkg/Include/Library/OemMiscLib.h | 21 +++++++++++++ > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 28 +++++++++++++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 32 +++++++++++++------- > 3 files changed, 70 insertions(+), 11 deletions(-) > > diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h > index 1936619d9b5b..541274999e5c 100644 > --- a/ArmPkg/Include/Library/OemMiscLib.h > +++ b/ArmPkg/Include/Library/OemMiscLib.h > @@ -37,6 +37,7 @@ typedef struct { > } OEM_MISC_PROCESSOR_DATA; > > > > typedef enum { > > + BiosVersionType00, > > ProductNameType01, > > SerialNumType01, > > UuidType01, > > @@ -247,4 +248,24 @@ OemGetSystemUuid ( > OUT GUID *SystemUuid > > ); > > > > +/** Fetches the BIOS release. > > + > > + @return The BIOS release. > > +**/ > > +UINT16 > > +EFIAPI > > +OemGetBiosRelease ( > > + VOID > > + ); > > + > > +/** Fetches the embedded controller firmware release. > > + > > + @return The embedded controller firmware release. > > +**/ > > +UINT16 > > +EFIAPI > > +OemGetEmbeddedControllerFirmwareRelease ( > > + VOID > > + ); > > + > > #endif // OEM_MISC_LIB_H_ > > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > index 32f6d55c1a9a..788ccab9e8c1 100644 > --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > @@ -254,3 +254,31 @@ OemGetSystemUuid ( > ASSERT (FALSE); > > CopyGuid (SystemUuid, &gZeroGuid); > > } > > + > > +/** Fetches the BIOS release. > > + > > + @return The BIOS release. > > +**/ > > +UINT16 > > +EFIAPI > > +OemGetBiosRelease ( > > + VOID > > + ) > > +{ > > + ASSERT (FALSE); > > + return 0xFFFF; > > +} > > + > > +/** Fetches the embedded controller firmware release. > > + > > + @return The embedded controller firmware release. > > +**/ > > +UINT16 > > +EFIAPI > > +OemGetEmbeddedControllerFirmwareRelease ( > > + VOID > > + ) > > +{ > > + ASSERT (FALSE); > > + return 0xFFFF; > > +} > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > index b49c4b754cab..e9106a8a2fec 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > @@ -1,5 +1,6 @@ > /** @file > > > > + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
> > Copyright (c) 2021, NUVIA Inc. All rights reserved.
> > Copyright (c) 2009, Intel Corporation. All rights reserved.
> > Copyright (c) 2015, Hisilicon Limited. All rights reserved.
> > @@ -13,6 +14,7 @@ > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -191,11 +193,11 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { > TokenToUpdate = STRING_TOKEN (STR_MISC_BIOS_VERSION); > > HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); > > } else { > > - Version = (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString); > > - if (StrLen (Version) > 0) { > > - TokenToUpdate = STRING_TOKEN (STR_MISC_BIOS_VERSION); > > - HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); > > - } > > + OemUpdateSmbiosInfo ( > > + mSmbiosMiscHiiHandle, > > + STRING_TOKEN (STR_MISC_BIOS_VERSION), > > + BiosVersionType00 > > + ); > > } > > > > Char16String = GetBiosReleaseDate (); > > @@ -251,13 +253,21 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { > } > > } > > > > - SmbiosRecord->SystemBiosMajorRelease = (UINT8)(PcdGet16 (PcdSystemBiosRelease) >> 8); > > - SmbiosRecord->SystemBiosMinorRelease = (UINT8)(PcdGet16 (PcdSystemBiosRelease) & 0xFF); > > + if (PcdGet16 (PcdSystemBiosRelease) != 0xFFFF) { > > + SmbiosRecord->SystemBiosMajorRelease = (UINT8)(PcdGet16 (PcdSystemBiosRelease) >> 8); > > + SmbiosRecord->SystemBiosMinorRelease = (UINT8)(PcdGet16 (PcdSystemBiosRelease) & 0xFF); > > + } else { > > + SmbiosRecord->SystemBiosMajorRelease = (UINT8)(OemGetBiosRelease () >> 8); > > + SmbiosRecord->SystemBiosMinorRelease = (UINT8)(OemGetBiosRelease () & 0xFF); > > + } > > > > - SmbiosRecord->EmbeddedControllerFirmwareMajorRelease = (UINT16) > > - (PcdGet16 (PcdEmbeddedControllerFirmwareRelease) >> 8); > > - SmbiosRecord->EmbeddedControllerFirmwareMinorRelease = (UINT16) > > - (PcdGet16 (PcdEmbeddedControllerFirmwareRelease) & 0xFF); > > + if (PcdGet16 (PcdEmbeddedControllerFirmwareRelease) != 0xFFFF) { > > + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease = (UINT16)(PcdGet16 (PcdEmbeddedControllerFirmwareRelease) >> 8); > > + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease = (UINT16)(PcdGet16 (PcdEmbeddedControllerFirmwareRelease) & 0xFF); > > + } else { > > + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease = (UINT16)(OemGetEmbeddedControllerFirmwareRelease () >> 8); > > + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease = (UINT16)(OemGetEmbeddedControllerFirmwareRelease () & 0xFF); > > + } > > > > OptionalStrStart = (CHAR8 *)(SmbiosRecord + 1); > > UnicodeStrToAsciiStrS (Vendor, OptionalStrStart, VendorStrLen + 1); >