From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.14562.1589211484690320302 for ; Mon, 11 May 2020 08:38:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L5oR5bNa; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589211483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lzzImU3NrTwJIxySYJeZTEVRLHS6YBE8NTDduUl2I+8=; b=L5oR5bNaQshmPysooH8w33r2mMqd3kL5htP8sPK7wZtIGUz+jGC8ci85yqs3TXWse47wsO niaYFwSUOleKbNsWXIyIUn+eutB1y8cFYLYs70sTUiRknxC2clvRVeRHmH2L8Kkd7fAW2k qDxDtWdiMqvff3fbzft6iOIzbSoR5y8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-u2A2mIQrOD6hH2juFP4a4A-1; Mon, 11 May 2020 11:38:02 -0400 X-MC-Unique: u2A2mIQrOD6hH2juFP4a4A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70CFD107ACCA; Mon, 11 May 2020 15:37:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-11.ams2.redhat.com [10.36.113.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 495446E6E0; Mon, 11 May 2020 15:37:56 +0000 (UTC) Subject: Re: [PATCH v7 00/43] SEV-ES guest support To: Tom Lendacky , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh , Benjamin You , Dandan Bi , Guo Dong , Hao A Wu , Jian J Wang , Maurice Ma References: <4da69262-e6a8-1374-2853-dab2a8f193d3@amd.com> From: "Laszlo Ersek" Message-ID: <76eaf23a-2ccb-a03e-9cfd-7b1f99d28512@redhat.com> Date: Mon, 11 May 2020 17:37:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4da69262-e6a8-1374-2853-dab2a8f193d3@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/08/20 21:16, Tom Lendacky wrote: > I was able to use the pull request method that Laszlo documented and > fixed up all of the issues identified by the VS compiler. > > An additional change I'm planning to make for the next version (v8) of > the patches is to create a NULL library instance of the VmgExitLib that > will also include the #VC handler function. This will reduce the amount > of code associated with this feature for platforms that don't > use/support SEV-ES. > > Laszlo, this will mean that I will introduce a version of the VmgExitLib > under OvmfPkg that will provide the majority of the functionality that > is present today in UefiCpuPkg. In essence, the functionality in v7 > patches 8 and 11 - 25 will now live under OvmfPkg instead of UefiCpuPkg. > I think this is the better way to do this. Let me know if you have any > concerns. That's OK with me. I'll have to spend more time to review those patches, of course. I think I'll go for Acked-by tags only, as these modules should be well-contained. In the next version, please consider introducing a new section to the "Maintainers.txt" file, and listing yourself and Brijesh in "R" roles for the (new) VmgExitLib and CpuExceptionHandlerLib instances under OvmfPkg. Best would be to list all the new files and modules introcuced by this patch set under OvmfPkg -- maybe Eric and Ray would prefer that for UefiCpuPkg as well. That's their call; for OvmfPkg I'd like this additional reviewership spelled out. Recent examples: - 335644f90f15 ("Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers", 2020-04-01) - feec20b28dd0 ("OvmfPkg/MptScsiDxe: Create empty driver", 2020-05-05) Thanks! Laszlo