From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.2462.1580716834012788624 for ; Mon, 03 Feb 2020 00:00:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 00:00:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,397,1574150400"; d="scan'208";a="429364869" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 03 Feb 2020 00:00:33 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 00:00:33 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Feb 2020 16:00:29 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 3 Feb 2020 16:00:29 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "vit9696@protonmail.com" Subject: Re: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler Thread-Topic: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler Thread-Index: AQHV2HvWLWOfv6VgQUG8Qv1lPMMLg6gJE0MQ Date: Mon, 3 Feb 2020 08:00:29 +0000 Message-ID: <76f4dee34c9c4cf4b876dcd1c6776a73@intel.com> References: <20200131211705.18511-1-vit9696@protonmail.com> In-Reply-To: <20200131211705.18511-1-vit9696@protonmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Vitaly: This change will cause CryptoPkg openssl build failure, because OpensslLi= b.inf undefines _MSC_VER macro to make sure openssl source code be built in= edk2 project without using MS VS functions. =20 Now, I have no good solution to fix this issue. One way is to use defined= (_MSC_EXTENSIONS) && !defined(__clang__), another way is to investigate whe= ther we can remove -fms-compatibility option in CLANGPDB. Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Vitaly Che= ptsov via Groups.Io > Sent: Saturday, February 1, 2020 5:17 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler >=20 > Patch details are explained in https://bugzilla.tianocore.org/show_bug.cg= i?id=3D2397. > We request this to be merged in edk2-stable202002. >=20 > Vitaly Cheptsov (1): > MdePkg: Use _MSC_VER to determine MSVC compiler >=20 > MdePkg/Include/AArch64/ProcessorBind.h | 2 +- > MdePkg/Include/Arm/ProcessorBind.h | 8 ++++---- > MdePkg/Include/Base.h | 10 +++++----- > MdePkg/Include/Ia32/ProcessorBind.h | 6 +++--- > MdePkg/Include/X64/ProcessorBind.h | 6 +++--- > 5 files changed, 16 insertions(+), 16 deletions(-) >=20 > -- > 2.21.1 (Apple Git-122.3) >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#53623): https://edk2.groups.io/g/devel/message/53623 > Mute This Topic: https://groups.io/mt/70882954/1759384 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D