From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.48]) by mx.groups.io with SMTP id smtpd.web12.9068.1633099714860886277 for ; Fri, 01 Oct 2021 07:48:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=sRI33P8f; spf=pass (domain: arm.com, ip: 40.107.13.48, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=knKguIYlpoPcXW12pBhOhsoR1MWJ5iKZtIjloEVAmDg=; b=sRI33P8fTFcpywQ+HZ3Sn+r0JBHcx0wnvMyUaXbKdR8jM6+TBbhRgIxAoySX9VnAppXh2Ns8HHuH3KwVMYhixEDzL3j9sUOEIaAaiwzfmCTasvYnJF9ax2OPsPzqwEc2R05phfp+VH/JguKRPftCJOufw9WBI9fITAp9qW7LxIk= Received: from AS8PR04CA0039.eurprd04.prod.outlook.com (2603:10a6:20b:312::14) by AM5PR0801MB1858.eurprd08.prod.outlook.com (2603:10a6:203:47::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.21; Fri, 1 Oct 2021 14:48:31 +0000 Received: from AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::4e) by AS8PR04CA0039.outlook.office365.com (2603:10a6:20b:312::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend Transport; Fri, 1 Oct 2021 14:48:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT062.mail.protection.outlook.com (10.152.17.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 14:48:31 +0000 Received: ("Tessian outbound c21c48fbc857:v103"); Fri, 01 Oct 2021 14:48:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d36ddac73ce6f0b9 X-CR-MTA-TID: 64aa7808 Received: from 12f6bf20c852.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 70E19DED-0028-43E0-BBFD-6CB4A161F2C8.1; Fri, 01 Oct 2021 14:48:19 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 12f6bf20c852.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Oct 2021 14:48:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMb4A8111gP3vXcmU79iYamMQAA71hIDvA2RvJy5rEdpagtGZ/6X9sf4aCx3dWMov6OFsHWJr3opjYZite08YIlrlRYwZ6tHRb/RIQxGMBjTeu/588CmbK1jGhW3VodZ7hP0wya9rHrVcrNzRbEbPbjGVv+8/4p2q8ei3TrnWy7buGzE3ad4G0c2u7j+Qn102HFUa6y3LcpulTOw2XNPQXN0VDf6eeGrjPqAinIB8cKNp6+pD66ddauSE1FHubs4Ka03b3a1LTpguCwShdmaj4sx2LipDEYUIxU3vVz1XPctDKKvkIKSBVoHG11zzVki+MWaNb0D5FqdMZ+IrF+L7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=knKguIYlpoPcXW12pBhOhsoR1MWJ5iKZtIjloEVAmDg=; b=iu/EHQL2x+EAdzXOMJRzJ7HqxmprTTGBO2HHL6fy84KaG6xnDD+mVo5rYEEu0w+N6SzAZYrl3WvHnGvIfxUrIcuQV6/XMO6pf5ps3yBpQ1gwAl8jVFq0jcwuWAiXkig1/2i3Ps1YBP2bXQdN8G+u1WVLcVMogd9izOETME13/mP81LCLgjjYqYHpfnBrV0v+8Mql0KVIy45VkDE3EQe+YA5ScX7hFl0Rs8PBNQ4e5o/JnD0PCE4ND+yfvODajB5vMACAQXGVLpHlsUrJMdulTfdNX64QTmKkuZ8c6Bn9HdBCiWgCp6Tg8s5HOe0/ad1S3MvB4ffi5t//kL8VnE78VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=knKguIYlpoPcXW12pBhOhsoR1MWJ5iKZtIjloEVAmDg=; b=sRI33P8fTFcpywQ+HZ3Sn+r0JBHcx0wnvMyUaXbKdR8jM6+TBbhRgIxAoySX9VnAppXh2Ns8HHuH3KwVMYhixEDzL3j9sUOEIaAaiwzfmCTasvYnJF9ax2OPsPzqwEc2R05phfp+VH/JguKRPftCJOufw9WBI9fITAp9qW7LxIk= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6995.eurprd08.prod.outlook.com (2603:10a6:20b:34d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct 2021 14:48:17 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::c8a5:672a:9ff2:e554]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::c8a5:672a:9ff2:e554%6]) with mapi id 15.20.4566.019; Fri, 1 Oct 2021 14:48:17 +0000 Subject: Re: [PATCH v1 01/13] DynamicTablesPkg: Make AmlNodeGetIntegerValue public To: Pierre.Gondois@arm.com, devel@edk2.groups.io, Alexei Fedorov Cc: Akanksha Jain , Alexandru Elisei , nd References: <20210623114039.24491-1-Pierre.Gondois@arm.com> <20210623114039.24491-2-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: <77333e5e-15f7-9d5a-67f6-b75075be3539@arm.com> Date: Fri, 1 Oct 2021 15:48:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210623114039.24491-2-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P265CA0194.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0194.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 14:48:16 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86cb2ae7-f01d-4b6c-e1c6-08d984ea89bb X-MS-TrafficTypeDiagnostic: AS8PR08MB6995:|AM5PR0801MB1858: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3044;OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rDQGe6G7k7rujnq3ISZb9AQRBmFLIegsn1M8iNJYYmkaBqCxT7RCBUtRu9XFQUiiPvJSR3pfGNdZSUr00+SWzM7OoOvW/m/f6wp/Hq3qnSI2j1qd4wcgwRJlEDvpYi/v9D2egta7ePTayvPaIGOsaiPKLsKOltkNaSBDT3yuw4PMjmcYlN/QWu4dzfz9bPqiELMw3kQhvFolvCmdRxs8zXyggudDA0S0MEECF3xDIyAwnxE/4FSO2oxAuHDl55IWCNEZ2mYnBBmbbGntepwMAdOSeDPruC4fQkaCekS8qqMDUSWYHhna/moLEGSlYRojyRYKDUDXuIixSYm0EwbFaDpzMNVIFHwaaZT9l+//H+tIeWNnRIbTYD+3x4egqjTQjtR4dfzjdkaqCMVwvsoeKTSP/ab2kvqat/wsl7hweDNzgftscOz4DwLDkAHdnRMn/jlOFDbzLTtQV0ZZL1V+RQ8ga8B/BBj7SLyxQBiVVt7+7B+k4iW9MdnWYNEYHbF3sqHRd2y5c22cg2QSYrJlSAc7XAL3chENHSqdGHT0Evax6cqGOg3Z0PsZ/YnWisgrPCNHGrsCnNqjjdBN+l6D4xrIc00eEGCW481EzK6trmH3wBgjI6gDQwxcmc6OCT3rkJkXUSXWFSv2X/4FJDu+hLsK8HRhzFIcSBY5jvj4YCjf7Du4+K6MSdnQYat7e5r2R/RvgvolTFTK9s1eSIfGYG3MfcMc4KFiOdQgP2ETuF84rwyemwOfz0dISniYbyZY8tsVYBCjE59QB7NRelHWMRpok6RfzH3LUd1N0n3DnMQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(52116002)(53546011)(66946007)(8676002)(37006003)(16576012)(508600001)(5660300002)(6636002)(316002)(66476007)(54906003)(83380400001)(44832011)(36756003)(4326008)(31696002)(66556008)(31686004)(2616005)(956004)(2906002)(26005)(38100700002)(38350700002)(186003)(6862004)(86362001)(6486002)(213903007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6995 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f94460b7-c3c1-48b7-22ed-08d984ea80e5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tge6nsihSisl2dqnyRbFfAU84mLlru3sE1+MH0fLysHA6iv5WHCfncuxIASpvLbytHE/XwpnJWr3I8B4Iu3PP5s3dEgFAZDkNOwE9ozrZ+Qf16asJWhJq1S1MzYlXjMlMB0JdLPqL8uaeMci5z+ZuNAc9C+ZcbRAoCUqCc19iC9n4bzx3IUel+vi48mQPHMw9dskD35++w6FCx+uB7hZbG86H5GU99Hkd9O0V4pxzkbsb81K67KEv4jPjjRuDbh5nWJ9qQvlpsr9t7Fs0/ditZJtlDwmPb2yZe2tQetDFPEkuu/WfofD4loPunhdSDuWKUOQUMJnDZJlN95V0BmS/KpI/zlcrRgpDJPMW1UfM4yRH/zXNMdS25QVSzY9G5J4v30NDykSnP+u0Lr+28GlkMt09aiHSnTUoKemeXPnKQcPlea+azbNbTJwa3AEKBbCeYkb+mqKiwcHyW+pikZdEQX587Oy4UrFmmkWqAoR6JQodUwib5oTzR8eb0pmkh5cUmYZokTSu7+H46tetw2fwluN37uUx6VIsBNqu4++m1yImcqUzEqxyLS3/ZCVcITIA7NLKgsPg+MDoH6jduMixcaUlK2tOKBqLjSeXIUsS+GY3OsyvA+HR438t9bA2ZAoQSUGXchnOPxw7BCPnPvopl2sNO9KfRGhLR3N176vcvB5WOk/p1CJjmM6Z9Z8qM98qRX34I4qUs9cefw0FjKVoJHrhmiRJ/oYHVtATIoy0cMGpWFzb82CQ0DYbcWefio7J4TwRHVOQDBxwQt74oGN0A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2616005)(36756003)(956004)(82310400003)(8936002)(31686004)(53546011)(44832011)(31696002)(70586007)(70206006)(36860700001)(316002)(47076005)(6636002)(54906003)(8676002)(86362001)(5660300002)(356005)(186003)(2906002)(16576012)(4326008)(336012)(83380400001)(37006003)(6862004)(26005)(6486002)(508600001)(81166007)(213903007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 14:48:31.7021 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86cb2ae7-f01d-4b6c-e1c6-08d984ea89bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1858 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pierre, Thank you for this patch. This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/06/2021 12:40 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Remove the STATIC qualifier for the AmlUtility function > AmlNodeGetIntegerValue() and add the definition to the > header file so that it can be used by other AmlLib > sub-modules. > > Signed-off-by: Pierre Gondois > --- > .../Library/Common/AmlLib/Utils/AmlUtility.c | 3 +-- > .../Library/Common/AmlLib/Utils/AmlUtility.h | 18 +++++++++++++++++- > 2 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c > index 7ebd08f945c0..3c8927acda6a 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c > @@ -1,7 +1,7 @@ > /** @file > AML Utility. > > - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -192,7 +192,6 @@ AmlComputeSize ( > @retval EFI_SUCCESS The function completed successfully. > @retval EFI_INVALID_PARAMETER Invalid parameter. > **/ > -STATIC > EFI_STATUS > EFIAPI > AmlNodeGetIntegerValue ( > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h > index c57d780140d4..5013bfb81d2d 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h > +++ b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h > @@ -1,7 +1,7 @@ > /** @file > AML Utility. > > - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -39,6 +39,22 @@ AmlComputeSize ( > IN OUT UINT32 * Size > ); > > +/** Get the value contained in an integer node. > + > + @param [in] Node Pointer to an integer node. > + Must be an object node. > + @param [out] Value Value contained in the integer node. > + > + @retval EFI_SUCCESS The function completed successfully. > + @retval EFI_INVALID_PARAMETER Invalid parameter. > +**/ > +EFI_STATUS > +EFIAPI > +AmlNodeGetIntegerValue ( > + IN AML_OBJECT_NODE * Node, > + OUT UINT64 * Value > + ); > + > /** Set the value contained in an integer node. > > The OpCode is updated accordingly to the new value