From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
 by mx.groups.io with SMTP id smtpd.web10.6143.1582711998957145512
 for <devel@edk2.groups.io>;
 Wed, 26 Feb 2020 02:13:19 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Uk1maGZe;
 spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1582711998;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=E5Wp6R0yjwy4avnMvTTae4hLqxQcA3WfcQCKXfXluaw=;
	b=Uk1maGZeYbiBiVyw6u7ferfodbWbBii9pIubIZJ/QsGVemTInV7nzc0C0NkBO45P0Tg/Gu
	vYQCKkjZBkWaVTtosd1XlKVcR9vC1QtO7+v0z7cpZ4/uIqpec+VxKNt8+qNaaeVWQnT9/7
	W9s3S3EfzMHsjAw54S9bsJnkwVPWDwg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-426-iuKI3bJrNV-V0Y3xE61OCw-1; Wed, 26 Feb 2020 05:13:14 -0500
X-MC-Unique: iuKI3bJrNV-V0Y3xE61OCw-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B5758017CC;
	Wed, 26 Feb 2020 10:13:13 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-185.ams2.redhat.com [10.36.116.185])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 1CCB590514;
	Wed, 26 Feb 2020 10:13:11 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export StandardSignatureIsAuthenticAMD function
To: devel@edk2.groups.io, eric.dong@intel.com, "Duran, Leo"
 <leo.duran@amd.com>
Cc: "Ni, Ray" <ray.ni@intel.com>
References: <1582659566-9893-1-git-send-email-leo.duran@amd.com>
 <1582659566-9893-2-git-send-email-leo.duran@amd.com>
 <ED077930C258884BBCB450DB737E662259FD1510@shsmsx102.ccr.corp.intel.com>
 <BN6PR12MB192234CC43CB821F82A3D928F9EA0@BN6PR12MB1922.namprd12.prod.outlook.com>
 <ED077930C258884BBCB450DB737E662259FD16CA@shsmsx102.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <7748cd85-7255-6319-e1a4-c6d12260b4b0@redhat.com>
Date: Wed, 26 Feb 2020 11:13:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <ED077930C258884BBCB450DB737E662259FD16CA@shsmsx102.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 02/26/20 06:05, Dong, Eric wrote:
> Hi Leo,
> 
> Yes, I means you also change the cod position in the c file, so in the patch file, it seems like it has other changes. 
> My recommendation is to refine the patch to not change the code postion.

Indeed I noticed that too. I figured this change -- moving the code
around, beyond purely making it public -- was intentional. I assumed the
new position of the function within the source code made more sense to Leo.

I agree the code movement should be explained at least in the commit
message.

Thanks
Laszlo