From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mx.groups.io with SMTP id smtpd.web08.3387.1639992585027458994 for ; Mon, 20 Dec 2021 01:29:45 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.188, mailfrom: xiewenyi2@huawei.com) Received: from kwepemi100002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JHZ6S1xBlzbjRW; Mon, 20 Dec 2021 17:29:20 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by kwepemi100002.china.huawei.com (7.221.188.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec 2021 17:29:42 +0800 Received: from [10.174.253.58] (10.174.253.58) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec 2021 17:29:41 +0800 From: "wenyi,xie" Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec To: Sami Mujawar , Ard Biesheuvel , edk2-devel-groups-io CC: Pierre Gondois , nd , Leif Lindholm , Ard Biesheuvel References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-4-Pierre.Gondois@arm.com> <1d258442-24c4-c155-36f9-f8f42edbefa0@arm.com> <2b637dc0-b36e-abf7-c514-c0bf568ce735@arm.com> <239BEFA8-F587-46F6-9B19-BEBA2A1B8AFA@arm.com> Message-ID: <77544f83-0cae-20a7-0b83-812031e95d93@huawei.com> Date: Mon, 20 Dec 2021 17:29:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: <239BEFA8-F587-46F6-9B19-BEBA2A1B8AFA@arm.com> X-Originating-IP: [10.174.253.58] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2021/12/18 0:39, Sami Mujawar wrote: > Hi Ard, >=20 >=20 > =EF=BB=BFOn 17/12/2021, 16:34, "Ard Biesheuvel" wrote: >=20 > On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wro= te: > > > > Hi Leif, Ard, Wenyi, > > > > Is it possible to review and provde feedback for this change, pleas= e? > > Sorry to reply late, it's OK to update the GUID in ArmPlatformLibSec.inf. Regards Wenyi >=20 > I agree that this should be resolved, and I don't think it matters > which one we change. The INF GUIDs of libraries are never used anyway= , > as far as I know. > In that case I will update this patch to modify the ArmVExpressLibRTSM ve= rsion. >=20 > Regards, >=20 > Sami Mujawar >=20 > > > > > > On 17/12/2021 02:15 PM, Pierre Gondois wrote: > > > Hi Sami, > > > > > > You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatfo= rmLibHisilicon/ArmPlatformLibSec.inf: > > > > > > "Based on the files under ArmPlatformPkg/ArmVExpressPkg/Library/A= rmVExpressLibRTSM/" > > > > > > Thanks for updating the commit, > > > > > > Regards, > > > > > > Pierre > > > > > > > > > > > > On 12/17/21 2:59 PM, Sami Mujawar wrote: > > >> Hi Pierre, > > >> > > >> Please find my response inline marked [SAMI]. > > >> > > >> Regards, > > >> > > >> Sami Mujawar > > >> > > >> > > >> On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: > > >>> From: Pierre Gondois > > >>> > > >>> The two following modules have the same GUID: > > >>> - Platform/ARM/VExpressPkg/Library/ > > >>> ArmVExpressLibRTSM/ArmVExpressLibSec.inf > > >>> - Silicon/Hisilicon/Library/ > > >>> ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > > >>> > > >>> The inf file in the Platform/ARM/ folder is based > > >>> on the one in Silicon/Hisilicon/. Modify the one > > >> [SAMI] I believe you want to say the inf file in Silicon/Hisilic= on/is based on the one in Platform/ARM and therefore you are modifying the = inf file in Silicon/Hisilicon. > > >> Please let me know if this is correct, and I will update this in= the commit message before merging the change. > > >> [/SAMI] > > >>> in the Silicon/Hisilicon/. > > >>> > > >>> Signed-off-by: Pierre Gondois > > >>> --- > > >>> .../Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf = | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/= ArmPlatformLibSec.inf b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/A= rmPlatformLibSec.inf > > >>> index ac587deedfd8..7fd7b5183e5b 100644 > > >>> --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlat= formLibSec.inf > > >>> +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlat= formLibSec.inf > > >>> @@ -12,7 +12,7 @@ > > >>> [Defines] > > >>> INF_VERSION =3D 0x00010005 > > >>> BASE_NAME =3D ArmPlatformLibSec > > >>> - FILE_GUID =3D a79eed97-4b98-4974-9690-3= 7b32d6a5b56 > > >>> + FILE_GUID =3D ABF3B82B-892F-438F-901F-F= 148C2DF89E6 > > >>> MODULE_TYPE =3D BASE > > >>> VERSION_STRING =3D 1.0 > > >>> LIBRARY_CLASS =3D ArmPlatformLib > > >>> -- > > >>> 2.25.1 > > > > IMPORTANT NOTICE: The contents of this email and any attachments ar= e confidential and may also be privileged. If you are not the intended reci= pient, please notify the sender immediately and do not disclose the content= s to any other person, use it for any purpose, or store or copy the informa= tion in any medium. Thank you. > > > > > >=20 > > > > >=20