From: "Matthew Carlson" <macarl@microsoft.com>
To: Michael D Kinney <michael.d.kinney@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch v2 0/2] Use RngLib instead of TimerLib for OpensslLib
Date: Fri, 31 Jul 2020 13:15:45 -0700 [thread overview]
Message-ID: <7762.1596226545346567006@groups.io> (raw)
In-Reply-To: <MN2PR11MB4461E82610EA05EF8F90579AD2710@MN2PR11MB4461.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
Hey Mike!
Thanks for the comments. I've addressed the feedback below.
1. All good comments. I think I've addressed them all. New patch series should be coming soon.
2. This is a problem for BaseCryptLibOnProtocol. We can't use a null lib for RngLib since it explodes when it tries to seed OpenSSL with entropy. I think for now, let's stick with established dependencies and figure this out at a later date. I added an RngLib that uses the DXE RNG Protocol.
3. I don't see a typo?
Calls RandomNumber64 to fill
a buffer of arbitrary size with random bytes.
@param [in] Length Size of the buffer, in bytes, to fill with.
@param [out] RandBuffer Pointer to the buffer to store the random result.
@retval True Random bytes generation succeeded.
@retval False Failed to request random bytes.
--
- Matthew Carlson
[-- Attachment #2: Type: text/html, Size: 2236 bytes --]
next prev parent reply other threads:[~2020-07-31 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 17:21 [Patch v2 0/2] Use RngLib instead of TimerLib for OpensslLib Matthew Carlson
2020-07-30 17:21 ` [Patch v2 1/2] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool Matthew Carlson
2020-07-30 17:21 ` [Patch v2 2/2] MdePkg: TimerRngLib: Added RngLib that uses TimerLib Matthew Carlson
2020-07-30 22:25 ` [edk2-devel] [Patch v2 0/2] Use RngLib instead of TimerLib for OpensslLib Michael D Kinney
2020-07-31 20:15 ` Matthew Carlson [this message]
2020-07-31 20:39 ` Michael D Kinney
2020-07-31 22:24 ` Matthew Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7762.1596226545346567006@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox