From: "Rebecca Cran" <rebecca@bsdio.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, osteffen@redhat.com,
Anthony Perard <anthony.perard@citrix.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line
Date: Mon, 17 Apr 2023 08:23:30 -0600 [thread overview]
Message-ID: <77727247-9639-c973-4f9c-24826be42a05@bsdio.com> (raw)
In-Reply-To: <6sqoamwfqxkm35ff7zu4cnrta6utsgoet5ai3jt6truy6rcez3@2at3rzewmg2q>
On 4/17/23 4:17 AM, Gerd Hoffmann wrote:
> On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote:
>> Sorry for not commenting on this earlier.
>>
>> Would it be better to have people use the build `--pcd` option instead? e.g.
>> build --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302".
> Possible, but the syntax is not that simple, you need 'L' prefix (so
> CHAR16 not CHAR8 is used) and '\0' postfix (so the string is properly
> terminated), i.e. --pcd=PcdFirmwareVersionString="L${version}\\0".
>
> Providing a shorter and less error prone way to specify the version
> looks sensible to me.
Agreed. Thanks.
--
Rebecca Cran
next prev parent reply other threads:[~2023-04-17 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 8:33 [PATCH v4 0/2] Set Firmware Version from build command line Oliver Steffen
2023-04-14 8:33 ` [PATCH v4 1/2] OvmfPkg: allow setting " Oliver Steffen
2023-04-14 8:33 ` [PATCH v4 2/2] ArmVirtPkg: " Oliver Steffen
2023-04-14 12:13 ` [edk2-devel] [PATCH v4 0/2] Set " Rebecca Cran
2023-04-17 10:17 ` Gerd Hoffmann
2023-04-17 14:23 ` Rebecca Cran [this message]
2023-05-04 10:13 ` Gerd Hoffmann
2023-05-04 10:55 ` [edk2-devel] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77727247-9639-c973-4f9c-24826be42a05@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox