From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mx.groups.io with SMTP id smtpd.web11.56182.1681741415018196628 for ; Mon, 17 Apr 2023 07:23:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=z3L4zdsO; spf=pass (domain: bsdio.com, ip: 64.147.123.21, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 71BD6320092B; Mon, 17 Apr 2023 10:23:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 17 Apr 2023 10:23:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681741413; x=1681827813; bh=9YNQf7xCsnzj17yymoDNGF1S0I2wOmVFxIT A6PuuC04=; b=z3L4zdsONig2MhVZmINL/9uLfsovTX3Ei2TYYDcjwErl1MQ/jWi KWPAa6oXIg1lT1mBfIovzAwz796ZfoDCrbvAWdVRf1QreDHqn6mZpmLc/YUAQP9+ cpgobOPoG43zJn30YHK7CQ0fXYeFR9CIMdA2jvv1MgAg8vQuvCSjgkvCtzjBgnY1 Ki0hSbcZaMuVhEycfID439B0/VKuZh6rcF6Yr5hZUup4DL1w1Bf26HUicvBM+dvP +9Eq64J3fnRXHUcsHG7RBAd4uwqO8hjpT81RiAZlBJfYJoyLNxgAeN8CIuJK/X7x QmsDlR3Z+7ysVD1FSZelfOz/S0apnx5iy3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681741413; x=1681827813; bh=9YNQf7xCsnzj17yymoDNGF1S0I2wOmVFxIT A6PuuC04=; b=P6bb0ziiyxylmEUk7GUEoVwgn4yu9YVrAaNZ/bYslOFZwpW8HK/ YArsIUSpBMxh2HNJiIQn5pEOP+whCC96BpovgBvCcncEGGmFbb4gyYHSKoU2N6Ot y8Vly5UgBBqqEx2y68k1UI2b1YjwalmFAmUoR7CIIY4NDJy4VELtnLZ+FtDAaR2A BeEACrnpRIHDsdlW81cfUyqHN6dTSACJD1hEMdGY+6bIomY+0Mi++oe60LX28Qm6 yyQC/r9WCszYy56qTk9Wm5PqQzxL9eDFwZP4jG72/27jRbZF6ZTjDvLV6QLgaXJC rWX8MNNhQcT9ZwJvP1qTC3X2t0AVPO9ofjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeliedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Apr 2023 10:23:31 -0400 (EDT) Message-ID: <77727247-9639-c973-4f9c-24826be42a05@bsdio.com> Date: Mon, 17 Apr 2023 08:23:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line To: Gerd Hoffmann Cc: devel@edk2.groups.io, osteffen@redhat.com, Anthony Perard , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Ray Ni , Sami Mujawar , Zhichao Gao References: <20230414083323.153731-1-osteffen@redhat.com> <45cf5684-fb48-abf7-a3d6-997f4b9c108d@bsdio.com> <6sqoamwfqxkm35ff7zu4cnrta6utsgoet5ai3jt6truy6rcez3@2at3rzewmg2q> From: "Rebecca Cran" In-Reply-To: <6sqoamwfqxkm35ff7zu4cnrta6utsgoet5ai3jt6truy6rcez3@2at3rzewmg2q> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/17/23 4:17 AM, Gerd Hoffmann wrote: > On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote: >> Sorry for not commenting on this earlier. >> >> Would it be better to have people use the build `--pcd` option instead? e.g. >> build --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302". > Possible, but the syntax is not that simple, you need 'L' prefix (so > CHAR16 not CHAR8 is used) and '\0' postfix (so the string is properly > terminated), i.e. --pcd=PcdFirmwareVersionString="L${version}\\0". > > Providing a shorter and less error prone way to specify the version > looks sensible to me. Agreed. Thanks. -- Rebecca Cran