From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 332AA210C9998
 for <edk2-devel@lists.01.org>; Thu, 31 May 2018 02:34:50 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 9105A7D83A;
 Thu, 31 May 2018 09:34:49 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-203.rdu2.redhat.com
 [10.10.120.203])
 by smtp.corp.redhat.com (Postfix) with ESMTP id D22B42026DEF;
 Thu, 31 May 2018 09:34:48 +0000 (UTC)
To: "Guo, Mang" <mang.guo@intel.com>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yuan, Xuemin" <xuemin.yuan@intel.com>, "Wei, David" <david.wei@intel.com>
References: <22D2C85ED001C54AA20BFE3B0E4751D15268D792@SHSMSX103.ccr.corp.intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <77773a95-3e79-3a18-84d0-6b8052db932f@redhat.com>
Date: Thu, 31 May 2018 11:34:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <22D2C85ED001C54AA20BFE3B0E4751D15268D792@SHSMSX103.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.2]); Thu, 31 May 2018 09:34:49 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]);
 Thu, 31 May 2018 09:34:49 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change SMM stack size
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2018 09:34:51 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 05/31/18 08:43, Guo, Mang wrote:
> Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable.
> Changed SMM stack size from 0x2000 to 0x4000 to fix this issue.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=964

You can thank me for commit 509f8425b75d ;)

(Obviously the credit goes to the folks that implemented the stack guard
in the first place! Alas, its usefulness was much limited until we
enabled it by default.)

I'm happy you didn't have to track down the SMM stack overflow the hard
way, like we needed to do before 509f8425b75d.

Laszlo