From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA6EA22283529 for ; Mon, 12 Mar 2018 05:04:16 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6587D1425; Mon, 12 Mar 2018 12:10:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-97.rdu2.redhat.com [10.10.120.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 79FCA2026E03; Mon, 12 Mar 2018 12:10:35 +0000 (UTC) To: Jordan Justen , Ard Biesheuvel Cc: edk2-devel-01 , Anthony Perard , Brijesh Singh , Julien Grall , Phil Dennis-Jordan References: <20180311014926.3049-1-lersek@redhat.com> <20157fd6-a776-fe10-6492-55e85ec03b3f@redhat.com> <152084420932.3437.8016565917691204369@jljusten-skl> From: Laszlo Ersek Message-ID: <77845e91-fa4e-ebcf-ddcb-6414ea223aee@redhat.com> Date: Mon, 12 Mar 2018 13:10:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <152084420932.3437.8016565917691204369@jljusten-skl> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 12 Mar 2018 12:10:36 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 12 Mar 2018 12:10:36 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 00/45] ArmVirtPkg, OvmfPkg: list module-internal headers in INF files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 12:04:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/12/18 09:43, Jordan Justen wrote: > On 2018-03-11 04:54:51, Ard Biesheuvel wrote: >> I am merely saying that it is not always necessary to share your >> personal journey resulting in the patches at this level of detail, >> simply because it doesn't scale. > > True. Message received, loud and clear. :) > Originally I was going to suggest that it might be worth making > 1 patch per package, but after looking over the changes, it seems that > scope is maybe a bit to large for that. > >> In any case, I am happy with this to go in as is, if you prefer. > > Also after looking it over, it appears that Laszlo put quite a bit of > information into each commit message. I agree that it might be sliced > a little too finely, but I guess after seeing the effort he put into > it, I prefer Laszlo go ahead and keep the separate commits. > > Series Reviewed-by: Jordan Justen Thank you both for putting up with the excessive detail. I'll attempt to do better next time. Laszlo