* Can you set a PCD value DSC default per ModuleType?
@ 2018-03-02 4:05 Andrew Fish
2018-03-02 4:07 ` Andrew Fish
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Fish @ 2018-03-02 4:05 UTC (permalink / raw)
To: edk2-devel
Can you set a PCD value DSC default per ModuleType? If not why not?
Thanks,
Andrew Fish
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Can you set a PCD value DSC default per ModuleType?
2018-03-02 4:05 Can you set a PCD value DSC default per ModuleType? Andrew Fish
@ 2018-03-02 4:07 ` Andrew Fish
2018-03-02 5:43 ` Kinney, Michael D
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Fish @ 2018-03-02 4:07 UTC (permalink / raw)
To: edk2-devel
Sorry for a FeatureFlag, obviously anything dynamic needs to be generic.
Thanks,
Andrew Fish
> On Mar 1, 2018, at 8:05 PM, Andrew Fish <afish@apple.com> wrote:
>
> Can you set a PCD value DSC default per ModuleType? If not why not?
>
> Thanks,
>
> Andrew Fish
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Can you set a PCD value DSC default per ModuleType?
2018-03-02 4:07 ` Andrew Fish
@ 2018-03-02 5:43 ` Kinney, Michael D
2018-03-02 5:54 ` Andrew Fish
0 siblings, 1 reply; 4+ messages in thread
From: Kinney, Michael D @ 2018-03-02 5:43 UTC (permalink / raw)
To: Andrew Fish, edk2-devel, Kinney, Michael D
Andrew,
DSC does not support module type specific syntax.
Just arch specific syntax.
https://edk2-docs.gitbooks.io/edk-ii-dsc-specification/content/2_dsc_overview/29_pcd_sections.html#29-pcd-sections
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Andrew Fish
> Sent: Thursday, March 1, 2018 8:07 PM
> To: edk2-devel <edk2-devel@lists.01.org>
> Subject: Re: [edk2] Can you set a PCD value DSC default
> per ModuleType?
>
> Sorry for a FeatureFlag, obviously anything dynamic
> needs to be generic.
>
> Thanks,
>
> Andrew Fish
>
> > On Mar 1, 2018, at 8:05 PM, Andrew Fish
> <afish@apple.com> wrote:
> >
> > Can you set a PCD value DSC default per ModuleType?
> If not why not?
> >
> > Thanks,
> >
> > Andrew Fish
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Can you set a PCD value DSC default per ModuleType?
2018-03-02 5:43 ` Kinney, Michael D
@ 2018-03-02 5:54 ` Andrew Fish
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Fish @ 2018-03-02 5:54 UTC (permalink / raw)
To: Mike Kinney; +Cc: edk2-devel
> On Mar 1, 2018, at 9:43 PM, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
>
> Andrew,
>
> DSC does not support module type specific syntax.
> Just arch specific syntax.
>
> https://edk2-docs.gitbooks.io/edk-ii-dsc-specification/content/2_dsc_overview/29_pcd_sections.html#29-pcd-sections
>
Mike,
I understand. My question is why?
Actually I have a module with some shared code and a shared INF and I was looking at a way of conditionally including code. So I tried this. Which I notice is no longer in the tree.
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf:40: X64/VirtualMemory.c ||||gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode
The reason for conditionally including the code is the library can run in a lot of different module types, but I need to call one line that is module specific and I was trying to figure out if I could do that conditionally? Do I really need a new Library class to abstract one line of code? Or do I need to clone the INF. The problem is my library gets include in the DXE CORE and SMM CORE and I'm have one line of DXE CORE only magic I was trying to abstract.
Is there a way short of a new library class for one line of code to do this? The PCD worked, but I had to use the <> override to every place the DXE Core was referenced, which is not ideal.
Thanks,
Andrew Fish
> Mike
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-
>> bounces@lists.01.org] On Behalf Of Andrew Fish
>> Sent: Thursday, March 1, 2018 8:07 PM
>> To: edk2-devel <edk2-devel@lists.01.org>
>> Subject: Re: [edk2] Can you set a PCD value DSC default
>> per ModuleType?
>>
>> Sorry for a FeatureFlag, obviously anything dynamic
>> needs to be generic.
>>
>> Thanks,
>>
>> Andrew Fish
>>
>>> On Mar 1, 2018, at 8:05 PM, Andrew Fish
>> <afish@apple.com> wrote:
>>>
>>> Can you set a PCD value DSC default per ModuleType?
>> If not why not?
>>>
>>> Thanks,
>>>
>>> Andrew Fish
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-02 5:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-02 4:05 Can you set a PCD value DSC default per ModuleType? Andrew Fish
2018-03-02 4:07 ` Andrew Fish
2018-03-02 5:43 ` Kinney, Michael D
2018-03-02 5:54 ` Andrew Fish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox