Re: [edk2-devel] [PATCH v1 1/2] OvmfPkg: Add no hardcode version of FtdNorFlashQemuLib

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]

Hi Gerd, Ard and other maintainers,

So, Could you help to review this patch set and give me the R-B?


Thanks,
Chao
On 2024/5/27 14:38, Gerd Hoffmann wrote:
> On Fri, May 24, 2024 at 11:11:41AM GMT, Marcin Juszkiewicz wrote:
>> W dniu 17.05.2024 o 09:17, Chao Li via groups.io pisze:
>>> This library is copied from ArmVirtPkg, in the Arm version, the value of
>>> PcdFlashNvStorageVariableBase, PcdFlashNvStorageFtwWorkingBase and
>>> PcdFlashNvStorageFtwSpareBase are hardcoded in INC file.
>>>
>>> This version will calculate them from FDT resource and using the set PCD
>>> to store when the NorFlashInitialise is called. By default, the first
>>> available flash(not used for storage UEFI code) as NV variable storage
>>> medium.
>>>
>>> In this way, UEFI can better handle the change of flash base address,
>>> which is suitable for different cpu architecture board implementation.
>>>
>>> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4770
>>>
>>> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
>>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>>> Cc: Sami Mujawar<sami.mujawar@arm.com>
>>> Cc: Gerd Hoffmann<kraxel@redhat.com>
>>> Cc: Jiewen Yao<jiewen.yao@intel.com>
>>> Signed-off-by: Chao Li<lichao@loongson.cn>
>>> Signed-off-by: Xianglai Li<lixianglai@loongson.cn>
>> Can you split it into driver itself and part which uses DT data to setup
>> parameters?
> Hmm?  This split exists already.  This is a library for flash detection,
> which is used by the flash driver (VirtNorFlashDxe) to find flash.  If
> using fdt doesn't work for sbsa-ref you can implement an alternative
> without rewriting the driver itself.
>
> take care,
>    Gerd


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119285): https://edk2.groups.io/g/devel/message/119285
Mute This Topic: https://groups.io/mt/106149595/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3970 bytes --]