From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 25584D80520 for ; Tue, 28 May 2024 01:43:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RKPqZPnawad2mI6oCbCdRzxJJF1QE4tHHJEUSJ2G8GQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1716860613; v=1; b=Kf/pdc6iPuZ/IefzOpdrFWKzGna5lmaoKEEjU3aYaG6N1khh0YE5VvC698pK5kVCVLtesLY2 d2jwC8r0bZUKC10J7YVIMmSz22VQrypR6yRvd35lTTVmqRYtdmk35Dp3fnUg9B/8LgKvG3xkYxX wyN9LPSCQCtzPPWctUqgrbWBAUvu76RWsLDLNVvlNHG7n1UcTLNJq29/mIIlc+K7zaYJrw0ABD1 RjrZLytEmOjEbbYWmt1YIXUut9SfO+UtSBgGSTVgQmiLad8U2pWNGmhzaoMv7Z8LG0QgOJ3bjdA iIO50eFFRMTBGIUWVsexPO7PEK0DCrY7lr9jRizscoWnQ== X-Received: by 127.0.0.2 with SMTP id yRctYY7687511xFotyO8wDty; Mon, 27 May 2024 18:43:32 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.12590.1716860606039165932 for ; Mon, 27 May 2024 18:43:26 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxSuq4NlVmtIIAAA--.2095S3; Tue, 28 May 2024 09:43:21 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxosS0NlVmWJkLAA--.19664S3; Tue, 28 May 2024 09:43:16 +0800 (CST) Message-ID: <77a0ba6c-2be1-4a84-b8d4-9f8d9326e11f@loongson.cn> Date: Tue, 28 May 2024 09:43:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/2] OvmfPkg: Add no hardcode version of FtdNorFlashQemuLib To: Gerd Hoffmann , Marcin Juszkiewicz Cc: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Jiewen Yao , Xianglai Li References: <20240517071729.188409-1-lichao@loongson.cn> <20240517071754.188521-1-lichao@loongson.cn> <314a58cc-9add-493e-a3d7-fd77edf77999@linaro.org> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8CxosS0NlVmWJkLAA--.19664S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAKCGZT5xIFfgAQso X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 27 May 2024 18:43:26 -0700 Resent-From: lichao@loongson.cn Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: a3FYCkLB37Sfr5Ll2YwfzRkFx7686176AA= Content-Type: multipart/alternative; boundary="------------oBMXeiXcz99skdvsy0Sg8B7i" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="Kf/pdc6i"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------oBMXeiXcz99skdvsy0Sg8B7i Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Gerd, Ard and other maintainers, So, Could you help to review this patch set and give me the R-B? Thanks, Chao On 2024/5/27 14:38, Gerd Hoffmann wrote: > On Fri, May 24, 2024 at 11:11:41AM GMT, Marcin Juszkiewicz wrote: >> W dniu 17.05.2024 o 09:17, Chao Li via groups.io pisze: >>> This library is copied from ArmVirtPkg, in the Arm version, the value of >>> PcdFlashNvStorageVariableBase, PcdFlashNvStorageFtwWorkingBase and >>> PcdFlashNvStorageFtwSpareBase are hardcoded in INC file. >>> >>> This version will calculate them from FDT resource and using the set PCD >>> to store when the NorFlashInitialise is called. By default, the first >>> available flash(not used for storage UEFI code) as NV variable storage >>> medium. >>> >>> In this way, UEFI can better handle the change of flash base address, >>> which is suitable for different cpu architecture board implementation. >>> >>> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4770 >>> >>> Cc: Ard Biesheuvel >>> Cc: Leif Lindholm >>> Cc: Sami Mujawar >>> Cc: Gerd Hoffmann >>> Cc: Jiewen Yao >>> Signed-off-by: Chao Li >>> Signed-off-by: Xianglai Li >> Can you split it into driver itself and part which uses DT data to setup >> parameters? > Hmm? This split exists already. This is a library for flash detection, > which is used by the flash driver (VirtNorFlashDxe) to find flash. If > using fdt doesn't work for sbsa-ref you can implement an alternative > without rewriting the driver itself. > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119285): https://edk2.groups.io/g/devel/message/119285 Mute This Topic: https://groups.io/mt/106149595/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------oBMXeiXcz99skdvsy0Sg8B7i Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Gerd, Ard and other maintainers,

So, Could you help to review this patch set and give me the R-B?


Thanks,
Chao
On 2024/5/27 14:38, Gerd Hoffmann wrote:
On Fri, May 24, 2024 at 11:11:41AM GMT, Marcin Juszkiewicz wrote:

W dniu 17.05.2024 o 09:17, Chao Li via groups.io pisze:

This library is copied from ArmVirtPkg, in the Arm version, the value of
PcdFlashNvStorageVariableBase, PcdFlashNvStorageFtwWorkingBase and
PcdFlashNvStorageFtwSpareBase are hardcoded in INC file.

This version will calculate them from FDT resource and using the set PCD
to store when the NorFlashInitialise is called. By default, the first
available flash(not used for storage UEFI code) as NV variable storage
medium.

In this way, UEFI can better handle the change of flash base address,
which is suitable for different cpu architecture board implementation.

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4770

Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
Cc: Leif Lindholm<quic_llindhol@quicinc.com>
Cc: Sami Mujawar<sami.mujawar@arm.com>
Cc: Gerd Hoffmann<kraxel@redhat.com>
Cc: Jiewen Yao<jiewen.yao@intel.com>
Signed-off-by: Chao Li<lichao@loongson.cn>
Signed-off-by: Xianglai Li<lixianglai@loongson.cn>

Can you split it into driver itself and part which uses DT data to setup
parameters?

Hmm?  This split exists already.  This is a library for flash detection,
which is used by the flash driver (VirtNorFlashDxe) to find flash.  If
using fdt doesn't work for sbsa-ref you can implement an alternative
without rewriting the driver itself.

take care,
  Gerd
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#119285) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------oBMXeiXcz99skdvsy0Sg8B7i--