From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mx.groups.io with SMTP id smtpd.web12.351.1639766416872329355 for ; Fri, 17 Dec 2021 10:40:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=qRjbyqWB; spf=pass (domain: nuviainc.com, ip: 209.85.210.172, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f172.google.com with SMTP id v13so3000445pfi.3 for ; Fri, 17 Dec 2021 10:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=bVFnZJJvnZt2xDxPcJ6EoFYzVwhOLxx9G7et9nWmpMY=; b=qRjbyqWBolyi9cFBZwHfiQ5hZOKsmXKM/C0pAiit9twX0vWRYLENI85YD9//CH63s7 ZRhMppZZ6Rkumyk2gX4xXFw7mx+o04451Io1DIjasRKfzxP1kotJdKeBfT21OpRryN1a iGWdhUr685HpY8GPq74sml0uuXq3MNY8/hozQMCBsgi8WbfV8F07ggtc7eSVWcKz5YC6 DMYIjdvFceXT1mi0K/X8ACkX8vNM9aunhmiR1RPrHjs5vg8v8Ka8u7WHVsE9EFEAowRL 4emTsCE2WBaq69AtPAp2kYPNmt/aNz9aQ7ZNOiS4XGHYTbJjv5cIpwM1TxzVXRZkh7H3 uItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=bVFnZJJvnZt2xDxPcJ6EoFYzVwhOLxx9G7et9nWmpMY=; b=LpGRq5J5WfOwd+RovNUY4fzF4LZ36is4GXuo1bcMdjrcpZTTHgxZZ9RcBz0mxU4Ak7 EpcePeK5cpbd77Q4tvN9LkRe4G7cb4UqBpfozJWPMb+nfMzm+GyjUw8oh0qlZDOj09TD VJRhSLKn8HZH692as515AvRlMmTAbbxqlwUepzQKdVQlA+8LllhqihV8WLr9xttBSeoA CH5nhmbNWqH7UyQOLvOKHbNGod57FfJHekP8l+n2opZHGdi4kZwjCOw5R3Bxh51OXA4r en/9dwlOJbvo8ZE4Tz5pOyJDALzIABR7PGzcxdfpzhZAdtwAPUmHanKxiQQbOikSsEtt j0ww== X-Gm-Message-State: AOAM533sfkmvu2shjne+TojyuwmxdAp8UEApd0qUgN/rFGdvOyVqyMWz qvhPDP4FnQIntYgnVZ0vLpFpyQ== X-Google-Smtp-Source: ABdhPJyW4HpgkK68YOjB8NgbrTCggpku99S23QIx5EF3WaSlRZ/pUATQ0D47CD7Pioo+BLVLuzJANA== X-Received: by 2002:a62:2503:0:b0:4a2:b772:25ac with SMTP id l3-20020a622503000000b004a2b77225acmr4315495pfl.53.1639766416421; Fri, 17 Dec 2021 10:40:16 -0800 (PST) Return-Path: Received: from ?IPv6:2601:681:4300:69e:9e7b:efff:fe2b:884c? ([2601:681:4300:69e:9e7b:efff:fe2b:884c]) by smtp.gmail.com with ESMTPSA id l16sm6589467pfu.115.2021.12.17.10.40.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 10:40:15 -0800 (PST) Subject: Re: [PATCH v3 0/4] ArmPkg,ArmVirtPkg: Add support EFI_MP_SERVICES_PROTOCOL on AARCH64 To: Ard Biesheuvel Cc: edk2-devel-groups-io , Ard Biesheuvel , Gerd Hoffmann , Samer El-Haj-Mahmoud , Leif Lindholm , Sami Mujawar References: <20211216034634.15468-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: <77bc0d79-e543-9503-f326-bd59c15d1b51@nuviainc.com> Date: Fri, 17 Dec 2021 11:40:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 12/17/21 11:08 AM, Ard Biesheuvel wrote: > OK, this looks good to me in principe, and I am quite happy with the > implementation of the MpInitLib and the new ability to dispatch > execution to other cores. > > However, looking at ArmPkg/Include/Guid/ArmMpCoreInfo.h, I was > seriously shocked at how much cruft has accumulated there: > - headers under Guid/ shouldn't carry that many vaguely related > definitions anyway > - the mailbox stuff is obsolete > - the pseudo-ACPI table (ACPI style header but published as a EFI > config table) is highly dubious as well, and should really just be > removed. > > I don't want to derail this series further, so I''ll have a stab at > cleaning this up on top, unless there are any reasons for keeping this > stuff? Thanks. I'm not familiar enough with it to know if it should be kept or not. But similarly, I have a task on my list to clean up ArmPlatformPkg - PrePeiCore, PrePi etc. since they have obsolete code to handle secondary cores from before TF-A. -- Rebecca Cran