From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 904E9740034 for ; Wed, 7 Aug 2024 10:56:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4lxrVu346ZUb2tYPbOso8Iw0meDz90XTPVV/mcaWNVE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1723028208; v=1; b=427WP+j3swh0CSwCYCFx08Gf4OsKa67fa+3ghvPZ+OusKkK21aIsLyH3rx+Jgmm4HYufSNRb DIDuIpU95lbT+XGGc5XFQ4pleEsPJ5k43EvH91LjTGHC5fgZzFnWKNzpOKsYs6lZymNOaY9P+4D J8ARmhqef56zrkNMco0RnqYM2Y0xvIPRx2EoobqeOQ9l33wYMugzrPgF4NAaqdKZ1EL2E6NJzyZ f5dcYRppzP2pmfw7vxWvpsd3EXEqQwEPk2PTBQc8RLtKml/FSP0f3omVuCTySq9uBGum/ESiD7k u2IxglIjYkCRNm+9xQDQG2F4JaR/0z2x9ZlrLzwjuU45g== X-Received: by 127.0.0.2 with SMTP id df04YY7687511xfImPwYn1uf; Wed, 07 Aug 2024 03:56:41 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.30565.1723028201465990409 for ; Wed, 07 Aug 2024 03:56:41 -0700 X-Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4778AwU2019000; Wed, 7 Aug 2024 10:56:39 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40u4cpndbd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Aug 2024 10:56:39 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 477AucDf027179 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Aug 2024 10:56:38 GMT X-Received: from [10.111.137.42] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 7 Aug 2024 03:56:36 -0700 Message-ID: <77c22ddd-b415-428b-8eeb-3a529979e7c9@quicinc.com> Date: Wed, 7 Aug 2024 11:56:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support To: , , "nhi@os.amperecomputing.com" CC: "chuong@os.amperecomputing.com" , "rebecca@os.amperecomputing.com" References: <20240807064731.4049764-1-nhi@os.amperecomputing.com> <79e9a70e-ec9c-45c7-a797-36890a8e7fc9@quicinc.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: UPLxkmdk-1QDOLCrkf-2JuxXX6MQe95E X-Proofpoint-GUID: UPLxkmdk-1QDOLCrkf-2JuxXX6MQe95E X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 4778AwU2019000 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 07 Aug 2024 03:56:41 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ciug7rqfmyeKNHzMaduaLkAHx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=427WP+j3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io I'm honestly not too fussed, but maybe hold off on telling people we've=20 switched until Rebecca's set is actually merged, so that the PR=20 assignment is working? Regards, Leif On 2024-08-07 11:45, Chang, Abner via groups.io wrote: > [AMD Official Use Only - AMD Internal Distribution Only] >=20 >=20 > So Leif, what's your preference? AMD already switched to use PR on=20 > edk2-platforms, shall we get back to the email review? >=20 > Thanks > Abner >=20 > Get Outlook for Android > ------------------------------------------------------------------------ > *From:* Leif Lindholm > *Sent:* Wednesday, August 7, 2024 6:23:46 PM > *To:* Chang, Abner ; devel@edk2.groups.io=20 > ; nhi@os.amperecomputing.com=20 > > *Cc:* chuong@os.amperecomputing.com ;=20 > rebecca@os.amperecomputing.com > *Subject:* Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF= =20 > support > Caution: This message originated from an External Source. Use proper=20 > caution when opening attachments, clicking links, or responding. >=20 >=20 > Err, no we haven't. >=20 > Although we're in the process of doing that. >=20 > / > =C2=A0=C2=A0=C2=A0=C2=A0 Leif >=20 > On 2024-08-07 08:16, Chang, Abner wrote: >> [AMD Official Use Only - AMD Internal Distribution Only] >> >> Hi Pham, >> We already move edk2-platforms review through GitHub PR. Could you pleas= e send the PR against edk2-platforms? >> >> Thanks >> Abner >> >>> -----Original Message----- >>> From: devel@edk2.groups.io On Behalf Of Nhi Pham >>> via groups.io >>> Sent: Wednesday, August 7, 2024 2:47 PM >>> To: devel@edk2.groups.io >>> Cc: quic_llindhol@quicinc.com; chuong@os.amperecomputing.com; >>> rebecca@os.amperecomputing.com; nhi@os.amperecomputing.com >>> Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF supp= ort >>> >>> Caution: This message originated from an External Source. Use proper ca= ution >>> when opening attachments, clicking links, or responding. >>> >>> >>> This updates the I2C library and implements SMBUS PEI/DXE drivers to >>> support IPMI SSIF in the Mt. Jade platform. >>> >>> v2: >>> - Refine the changes of the DwI2cLib per Leif's comments and update the >>>=C2=A0=C2=A0=C2=A0 commit message accordingly. >>> - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. >>> >>> NOTE: Regarding the controller/target terminology, the function >>> prototype and comment are derived from edk2/MdePkg. In this patch set, = I >>> am trying to avoid misusing the terms in the implementation instead of >>> altering the function prototype and comment with the PPI and Protocol. >>> >>> Nhi Pham (5): >>>=C2=A0=C2=A0=C2=A0 AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC op= eration >>>=C2=A0=C2=A0=C2=A0 AmpereSiliconPkg: Define PCDs for SMBUS and BMC >>>=C2=A0=C2=A0=C2=A0 AmpereAltraPkg: Add SmbusHc PEI and DXE drivers >>>=C2=A0=C2=A0=C2=A0 JadePkg: Add PlatformBmcReadyLib to support BMC ready= check >>>=C2=A0=C2=A0=C2=A0 Ampere/Jade: Enable IPMI SSIF >>> >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 15 +- >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 23 ++ >>>=C2=A0=C2=A0 Platform/Ampere/JadePkg/Jade.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0=C2=A0 2 + >>>=C2=A0=C2=A0 Platform/Ampere/JadePkg/Jade.fdf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 17 ++ >>> >>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >>> Lib.inf |=C2=A0 29 ++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.in= f=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | >>> 43 +++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.in= f=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | >>> 43 +++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon= .h >>> |=C2=A0 95 +++++++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 11 +- >>>=C2=A0=C2=A0 Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PC= F85063.c >>> |=C2=A0=C2=A0 6 +- >>> >>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >>> Lib.c=C2=A0=C2=A0 |=C2=A0 30 +++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon= .c >>> | 261 ++++++++++++++++++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> 277 ++++++++++++++++++++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> 263 +++++++++++++++++++ >>>=C2=A0=C2=A0 Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 129 >>> ++++++++- >>>=C2=A0=C2=A0 15 files changed, 1227 insertions(+), 17 deletions(-) >>>=C2=A0=C2=A0 create mode 100755 >>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >>> Lib.inf >>>=C2=A0=C2=A0 create mode 100644 >>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf >>>=C2=A0=C2=A0 create mode 100644 >>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf >>>=C2=A0=C2=A0 create mode 100644 >>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h >>>=C2=A0=C2=A0 create mode 100644 >>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >>> Lib.c >>>=C2=A0=C2=A0 create mode 100644 >>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c >>>=C2=A0=C2=A0 create mode 100644 >>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c >>>=C2=A0=C2=A0 create mode 100644 >>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c >>> >>> -- >>> 2.25.1 >>> >>> >>> >>>=20 >>> >> >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120273): https://edk2.groups.io/g/devel/message/120273 Mute This Topic: https://groups.io/mt/107765352/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-