Re: [PATCH v5 01/21] ArmPkg: PCD to select conduit for monitor calls

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On 2022-09-19 12:21, Pierre.Gondois@arm.com wrote:
> From: Sami Mujawar <sami.mujawar@arm.com>
> 
> Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for
> monitor calls. PcdMonitorConduitHvc is defined as FALSE by default,
> meaning the SMC conduit is enabled as default.
> 
> Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used
> by virtual firmware implementations.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>

Actually, revoke my Reviewed-by for this patch.

The patch needs to be signed off by the contributor (you), and no one 
else. You cannot make legal statements on their behalf, and you must 
make the statement on your own behalf.

/
     Leif

> ---
>   ArmPkg/ArmPkg.dec | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index 9da1bbc9f216..bb5cbecbc228 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -2,7 +2,7 @@
>   # ARM processor package.
>   #
>   # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
> -# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved.
> +# Copyright (c) 2011 - 2022, ARM Limited. All rights reserved.
>   # Copyright (c) 2021, Ampere Computing LLC. All rights reserved.
>   #
>   #    SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -132,6 +132,11 @@ [PcdsFeatureFlag.common]
>     # Define if the GICv3 controller should use the GICv2 legacy
>     gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042
>   
> +  ## Define the conduit to use for monitor calls.
> +  # Default PcdMonitorConduitHvc = FALSE, conduit = SMC
> +  # If PcdMonitorConduitHvc = TRUE, conduit = HVC
> +  gArmTokenSpaceGuid.PcdMonitorConduitHvc|FALSE|BOOLEAN|0x00000047
> +
>   [PcdsFeatureFlag.ARM]
>     # Whether to map normal memory as non-shareable. FALSE is the safe choice, but
>     # TRUE may be appropriate to fix performance problems if you don't care about