From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web09.14931.1664305189223056750 for ; Tue, 27 Sep 2022 11:59:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=DSr2apJR; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28RHdCVY014045; Tue, 27 Sep 2022 18:59:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=137+2+pjNUoW6e/uOwKyR0qXzGywgBhjjElNvPmtYK4=; b=DSr2apJR0Mx9S3f+T5KxYtWVmKzVC8wkjsT5ygoUtIT3sqrZyLCLpW92CVj71ZR5IG98 KaxLmfSh8VbvbxQEiIzUYBSxzm9/esSRuVBNGsBCy4ArU7Vrainrn2MdmOhBkGXCpFuc ILPr/PZFxR45yY7vifvLTXuE3QvRYFcYCP8GBTIG4LT4FTxHVdygJsc0r0Wa5pvccCOB EDtFPrKcTULSvf2/Lsu1jZa458mAVM0Hq20ge3kCy4tIUTjKx8FsPgyB41POFiMPxQ2v C2+nvEH8981CF/f9C7gS80BUrCVGKM2zI3mvChNhztKUHC2xtu19io69OK3lu2NhSAwG 4g== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3juh0hux03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 18:59:38 +0000 Received: from nasanex01c.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28RIxblu027890 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 18:59:37 GMT Received: from [10.110.17.52] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 27 Sep 2022 11:59:36 -0700 Message-ID: <77d2ef34-d950-fc63-29a9-fb2ebd1005f0@quicinc.com> Date: Tue, 27 Sep 2022 11:59:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v5 01/21] ArmPkg: PCD to select conduit for monitor calls To: , CC: Sami Mujawar , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , Jiewen Yao , Jian J Wang References: <20220919192207.637786-1-Pierre.Gondois@arm.com> <20220919192207.637786-2-Pierre.Gondois@arm.com> From: "Leif Lindholm" In-Reply-To: <20220919192207.637786-2-Pierre.Gondois@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: YFc1_fA7mafipdDLxWT0mio2VX7UFJC4 X-Proofpoint-ORIG-GUID: YFc1_fA7mafipdDLxWT0mio2VX7UFJC4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_09,2022-09-27_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209270119 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2022-09-19 12:21, Pierre.Gondois@arm.com wrote: > From: Sami Mujawar > > Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for > monitor calls. PcdMonitorConduitHvc is defined as FALSE by default, > meaning the SMC conduit is enabled as default. > > Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used > by virtual firmware implementations. > > Signed-off-by: Sami Mujawar Actually, revoke my Reviewed-by for this patch. The patch needs to be signed off by the contributor (you), and no one else. You cannot make legal statements on their behalf, and you must make the statement on your own behalf. / Leif > --- > ArmPkg/ArmPkg.dec | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index 9da1bbc9f216..bb5cbecbc228 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -2,7 +2,7 @@ > # ARM processor package. > # > # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
> -# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved. > +# Copyright (c) 2011 - 2022, ARM Limited. All rights reserved. > # Copyright (c) 2021, Ampere Computing LLC. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -132,6 +132,11 @@ [PcdsFeatureFlag.common] > # Define if the GICv3 controller should use the GICv2 legacy > gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042 > > + ## Define the conduit to use for monitor calls. > + # Default PcdMonitorConduitHvc = FALSE, conduit = SMC > + # If PcdMonitorConduitHvc = TRUE, conduit = HVC > + gArmTokenSpaceGuid.PcdMonitorConduitHvc|FALSE|BOOLEAN|0x00000047 > + > [PcdsFeatureFlag.ARM] > # Whether to map normal memory as non-shareable. FALSE is the safe choice, but > # TRUE may be appropriate to fix performance problems if you don't care about