Re: [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl

["Laszlo Ersek" <lersek@redhat.com>]

Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.

Thank you,
Laszlo

On 3/5/24 12:38, Laszlo Ersek wrote:
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
> 
> Build-tested with:
> 
>   build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCore.inf \
>     -p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5
> 
>   build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCoreNative.inf \
>     -p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5
> 
> Cc: Catharine West <catharine.west@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  UefiCpuPkg/SecCore/SecCore.inf       |  2 +-
>  UefiCpuPkg/SecCore/SecCoreNative.inf |  2 +-
>  UefiCpuPkg/SecCore/SecMain.h         | 12 ------------
>  3 files changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/UefiCpuPkg/SecCore/SecCore.inf b/UefiCpuPkg/SecCore/SecCore.inf
> index cab69b8b97f3..4f732cccb7fc 100644
> --- a/UefiCpuPkg/SecCore/SecCore.inf
> +++ b/UefiCpuPkg/SecCore/SecCore.inf
> @@ -13,7 +13,7 @@
>  ##
>  
>  [Defines]
> -  INF_VERSION                    = 0x00010005
> +  INF_VERSION                    = 1.30
>    BASE_NAME                      = SecCore
>    MODULE_UNI_FILE                = SecCore.uni
>    FILE_GUID                      = 1BA0062E-C779-4582-8566-336AE8F78F09
> diff --git a/UefiCpuPkg/SecCore/SecCoreNative.inf b/UefiCpuPkg/SecCore/SecCoreNative.inf
> index fa241cca94d4..454a3629e505 100644
> --- a/UefiCpuPkg/SecCore/SecCoreNative.inf
> +++ b/UefiCpuPkg/SecCore/SecCoreNative.inf
> @@ -13,7 +13,7 @@
>  ##
>  
>  [Defines]
> -  INF_VERSION                    = 0x00010005
> +  INF_VERSION                    = 1.30
>    BASE_NAME                      = SecCoreNative
>    MODULE_UNI_FILE                = SecCore.uni
>    FILE_GUID                      = 43CA74CA-7D29-49A0-B3B9-20F84015B27D
> diff --git a/UefiCpuPkg/SecCore/SecMain.h b/UefiCpuPkg/SecCore/SecMain.h
> index b50d96e45b33..81c561424e3b 100644
> --- a/UefiCpuPkg/SecCore/SecMain.h
> +++ b/UefiCpuPkg/SecCore/SecMain.h
> @@ -101,18 +101,6 @@ FindAndReportEntryPoints (
>    OUT EFI_PEI_CORE_ENTRY_POINT    *PeiCoreEntryPoint
>    );
>  
> -/**
> -  Auto-generated function that calls the library constructors for all of the module's
> -  dependent libraries.  This function must be called by the SEC Core once a stack has
> -  been established.
> -
> -**/
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> -  VOID
> -  );
> -
>  /**
>    Implementation of the PlatformInformation service in EFI_SEC_PLATFORM_INFORMATION_PPI.
>  
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116457): https://edk2.groups.io/g/devel/message/116457
Mute This Topic: https://groups.io/mt/104742529/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-