From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E04B87803CC for ; Wed, 6 Mar 2024 21:10:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tbYS3mrXZkVuwpXjs8Cp+0HFOgonN6Xh2ZCtHYovhHs=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709759401; v=1; b=qDj3cHc9neT9Pjbo/d/GFTYkt1RujVxCJVqUMUo4ZgT0pbMoTBUvg0OD/FVUGgWkX9VvUg2H U0BkBlgrq8EesfTsblM1HJi4sSizy9uEkCBFfziasVcEDc5aGirTdtezhp9K+25+THqNKTyu8Eo wNahk2rOrHn9Xq6jrkzKeXRSSbyhxWdu3cgNiz9UmBdarUQc+T0/m+N+DFeFDANZc+YL62rnP2G 2MEgEGgE60a4Sj8I7ddYL1zfym/kvxC3uuFWpyIQ3P06neL8Y0xXBYfm73DqoX4PfkwgjAv0Dsn 7WuU0Dtm8O0kKGOlgnZi0o1SXC03+hBUCOyyUOqz2aeNQ== X-Received: by 127.0.0.2 with SMTP id rxYlYY7687511xoO6RXVz1vi; Wed, 06 Mar 2024 13:10:01 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7276.1709759400993544604 for ; Wed, 06 Mar 2024 13:10:01 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-C1_f_573NVqwpPpF3e37lA-1; Wed, 06 Mar 2024 16:09:56 -0500 X-MC-Unique: C1_f_573NVqwpPpF3e37lA-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A0033185A786; Wed, 6 Mar 2024 21:09:55 +0000 (UTC) X-Received: from [10.39.192.14] (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96AF240C6CB5; Wed, 6 Mar 2024 21:09:54 +0000 (UTC) Message-ID: <77f1e9eb-5d5e-d6cb-7b62-15e5a95363f6@redhat.com> Date: Wed, 06 Mar 2024 13:10:01 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Catharine West , Gerd Hoffmann , Rahul Kumar , Ray Ni Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20240305113843.68812-1-lersek@redhat.com> <20240305113843.68812-10-lersek@redhat.com> In-Reply-To: <20240305113843.68812-10-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: E4E37Ka794s2BgyeHzux0mOmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=qDj3cHc9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Can I please get a quick R-b for this patch -- it's urgent because of . Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). >=20 > Build-tested with: >=20 > build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCore.inf \ > -p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5 >=20 > build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCoreNative.inf \ > -p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5 >=20 > Cc: Catharine West > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Ray Ni > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 > Signed-off-by: Laszlo Ersek > --- > UefiCpuPkg/SecCore/SecCore.inf | 2 +- > UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +- > UefiCpuPkg/SecCore/SecMain.h | 12 ------------ > 3 files changed, 2 insertions(+), 14 deletions(-) >=20 > diff --git a/UefiCpuPkg/SecCore/SecCore.inf b/UefiCpuPkg/SecCore/SecCore.= inf > index cab69b8b97f3..4f732cccb7fc 100644 > --- a/UefiCpuPkg/SecCore/SecCore.inf > +++ b/UefiCpuPkg/SecCore/SecCore.inf > @@ -13,7 +13,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D SecCore > MODULE_UNI_FILE =3D SecCore.uni > FILE_GUID =3D 1BA0062E-C779-4582-8566-336AE8F78F0= 9 > diff --git a/UefiCpuPkg/SecCore/SecCoreNative.inf b/UefiCpuPkg/SecCore/Se= cCoreNative.inf > index fa241cca94d4..454a3629e505 100644 > --- a/UefiCpuPkg/SecCore/SecCoreNative.inf > +++ b/UefiCpuPkg/SecCore/SecCoreNative.inf > @@ -13,7 +13,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D SecCoreNative > MODULE_UNI_FILE =3D SecCore.uni > FILE_GUID =3D 43CA74CA-7D29-49A0-B3B9-20F84015B27= D > diff --git a/UefiCpuPkg/SecCore/SecMain.h b/UefiCpuPkg/SecCore/SecMain.h > index b50d96e45b33..81c561424e3b 100644 > --- a/UefiCpuPkg/SecCore/SecMain.h > +++ b/UefiCpuPkg/SecCore/SecMain.h > @@ -101,18 +101,6 @@ FindAndReportEntryPoints ( > OUT EFI_PEI_CORE_ENTRY_POINT *PeiCoreEntryPoint > ); > =20 > -/** > - Auto-generated function that calls the library constructors for all of= the module's > - dependent libraries. This function must be called by the SEC Core onc= e a stack has > - been established. > - > -**/ > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - VOID > - ); > - > /** > Implementation of the PlatformInformation service in EFI_SEC_PLATFORM_= INFORMATION_PPI. > =20 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116457): https://edk2.groups.io/g/devel/message/116457 Mute This Topic: https://groups.io/mt/104742529/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-