* [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf
2024-07-31 16:33 [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Ard Biesheuvel
@ 2024-07-31 16:33 ` Ard Biesheuvel
2024-08-01 15:25 ` Nhi Pham via groups.io
2024-08-05 19:14 ` Marcin Juszkiewicz
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 2/2] Platform AARCH64: Move PrePi users to PeilessSec.inf Ard Biesheuvel
` (2 subsequent siblings)
3 siblings, 2 replies; 21+ messages in thread
From: Ard Biesheuvel @ 2024-07-31 16:33 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie,
Jeremy Linton, Ling Jia, Peng Xie, Yiqi Shu
PrePeiCore has been superseded by Sec.inf, which is a more common naming
for the SEC module, aligned with other architectures. No functional
changes intended.
Switch all users to Sec.inf so the old implementation can be retired
from EDK2.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 +-
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 2 +-
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 +-
Silicon/NXP/NxpQoriqLs.dsc.inc | 2 +-
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 +-
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 2 +-
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 2 +-
Platform/Hisilicon/D03/D03.dsc | 2 +-
Platform/Hisilicon/D05/D05.dsc | 2 +-
Platform/Hisilicon/D06/D06.dsc | 2 +-
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 2 +-
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 +-
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 +-
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 2 +-
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 +-
Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 2 +-
Platform/ARM/Morello/MorelloPlatformFvp.fdf | 2 +-
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 2 +-
Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +-
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +-
Platform/Ampere/JadePkg/Jade.fdf | 2 +-
Platform/Hisilicon/D03/D03.fdf | 2 +-
Platform/Hisilicon/D05/D05.fdf | 2 +-
Platform/Hisilicon/D06/D06.fdf | 2 +-
Platform/LeMaker/CelloBoard/CelloBoard.fdf | 2 +-
Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 2 +-
Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf | 2 +-
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 2 +-
Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 2 +-
Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 2 +-
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 2 +-
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 2 +-
Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 2 +-
34 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
index 5407185e853c..2ecc937d292e 100644
--- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
+++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
@@ -145,7 +145,7 @@ [Components.common]
# PEI Phase modules
ArmPkg/Drivers/CpuPei/CpuPei.inf
ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
ArmPlatformPkg/PlatformPei/PlatformPeim.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index 87dcfbc4ce32..1bf9457fe99b 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -219,7 +219,7 @@ [Components.common]
#
ArmPkg/Drivers/CpuPei/CpuPei.inf
ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
ArmPlatformPkg/PlatformPei/PlatformPeim.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index e9c97a353a98..71a33f9ff36a 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -520,7 +520,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 385543fbd56e..b8eefc329071 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -417,7 +417,7 @@ [PcdsDynamicExDefault.common.DEFAULT]
[Components.common]
# PEI Phase modules
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
index 58666621a47e..a359f4c5c22d 100644
--- a/Silicon/NXP/NxpQoriqLs.dsc.inc
+++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
@@ -310,7 +310,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 3e9f6d46b796..3acd3e281ce4 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -503,7 +503,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
index 63e885320651..ba8b624fde38 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
@@ -174,7 +174,7 @@ [Components.common]
# PEI Phase modules
ArmPkg/Drivers/CpuPei/CpuPei.inf
ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
ArmPlatformPkg/PlatformPei/PlatformPeim.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
index e1e85b4f2ec2..2a812f4ac7aa 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
@@ -234,7 +234,7 @@ [Components.common]
}
!else
# UEFI lives in FLASH and copies itself to RAM
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index 458004830fd8..bfdcaed92cad 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -282,7 +282,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
index 37e826fda3d0..0b9972bf7c02 100644
--- a/Platform/Hisilicon/D05/D05.dsc
+++ b/Platform/Hisilicon/D05/D05.dsc
@@ -415,7 +415,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf
Platform/Hisilicon/D05/Drivers/Ipmi/IpmiInterfacePei/IpmiInterfacePei.inf
diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index 2bc7206438f1..7196365041bf 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -230,7 +230,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 7f54c41ac11c..f5389e3d3c1b 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -456,7 +456,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 089a639184e3..07e8768dde6b 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -596,7 +596,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 98f9e603755c..71d7abe63e0a 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -261,7 +261,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
index 12d4962bc3a3..a9058cfdec54 100644
--- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
+++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
@@ -430,7 +430,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 5b9e4730505f..bdc3972e571f 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -445,7 +445,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ ArmPlatformPkg/Sec/Sec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
index 15b5b1bc317f..d70031c39b87 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
@@ -252,7 +252,7 @@ [FV.STYX_EFI]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
INF Silicon/AMD/Styx/AmdModulePkg/Iscp/IscpPei.inf
diff --git a/Platform/ARM/Morello/MorelloPlatformFvp.fdf b/Platform/ARM/Morello/MorelloPlatformFvp.fdf
index 581579270488..90826dbf5eaa 100644
--- a/Platform/ARM/Morello/MorelloPlatformFvp.fdf
+++ b/Platform/ARM/Morello/MorelloPlatformFvp.fdf
@@ -187,7 +187,7 @@ [FV.FVMAIN_COMPACT]
INF ArmPkg/Drivers/CpuPei/CpuPei.inf
INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
index 7b7eda51c70c..573e427bfd05 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
@@ -193,7 +193,7 @@ [FV.FVMAIN_COMPACT]
INF ArmPkg/Drivers/CpuPei/CpuPei.inf
INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
index 4558e886f863..33c660c50046 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
+++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
@@ -225,7 +225,7 @@ [FV.FVMAIN_COMPACT]
INF ArmPkg/Drivers/CpuPei/CpuPei.inf
INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
index 612535caa7ee..df58b04778ff 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
@@ -236,7 +236,7 @@ [FV.FVMAIN_COMPACT]
!if $(EDK2_SKIP_PEICORE) == 1
INF ArmPlatformPkg/PrePi/PeiUniCore.inf
!else
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf
index 2745ee44c20a..4091e4c06300 100644
--- a/Platform/Ampere/JadePkg/Jade.fdf
+++ b/Platform/Ampere/JadePkg/Jade.fdf
@@ -148,7 +148,7 @@ [FV.FVMAIN_COMPACT]
INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
}
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF UefiCpuPkg/CpuIoPei/CpuIoPei.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
index 0545961d64e3..366d6d351003 100644
--- a/Platform/Hisilicon/D03/D03.fdf
+++ b/Platform/Hisilicon/D03/D03.fdf
@@ -303,7 +303,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf
index 547d86ade0ee..4075247fd5b8 100644
--- a/Platform/Hisilicon/D05/D05.fdf
+++ b/Platform/Hisilicon/D05/D05.fdf
@@ -312,7 +312,7 @@ [FV.FVMAIN_COMPACT]
APRIORI PEI {
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
}
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf
index 4d796f6ece2f..1c4b37599f77 100644
--- a/Platform/Hisilicon/D06/D06.fdf
+++ b/Platform/Hisilicon/D06/D06.fdf
@@ -302,7 +302,7 @@ [FV.FVMAIN_COMPACT]
APRIORI PEI {
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
}
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.fdf b/Platform/LeMaker/CelloBoard/CelloBoard.fdf
index 80c760464f20..2ee719dafe10 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.fdf
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.fdf
@@ -238,7 +238,7 @@ [FV.STYX_EFI]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
INF Silicon/AMD/Styx/AmdModulePkg/Iscp/IscpPei.inf
diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
index dd31b45b4d78..063739af915f 100644
--- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
+++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
@@ -173,7 +173,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
INF MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
diff --git a/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf b/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf
index 34c4e5a02516..a4cea07e6a73 100755
--- a/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf
+++ b/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf
@@ -165,7 +165,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
INF MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
index 06805658a7b1..8d4001303303 100644
--- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
+++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
@@ -203,7 +203,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
INF MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
index 51a1ef8519f9..73b71e01b28b 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
@@ -296,7 +296,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
index 5dd5e4b5c0c1..5741db99c882 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
@@ -285,7 +285,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
index 91771895245d..d3227e96f087 100644
--- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
+++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
@@ -243,7 +243,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
index 6a9226476bab..8a0bc21f50f5 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
@@ -234,7 +234,7 @@ [FV.STYX_EFI]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
INF Silicon/AMD/Styx/AmdModulePkg/Iscp/IscpPei.inf
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
index ffde102dcfc0..ec3783c552fa 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
@@ -243,7 +243,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+ INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
--
2.46.0.rc1.232.g9752f9e123-goog
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120154): https://edk2.groups.io/g/devel/message/120154
Mute This Topic: https://groups.io/mt/107649434/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf Ard Biesheuvel
@ 2024-08-01 15:25 ` Nhi Pham via groups.io
2024-08-05 19:14 ` Marcin Juszkiewicz
1 sibling, 0 replies; 21+ messages in thread
From: Nhi Pham via groups.io @ 2024-08-01 15:25 UTC (permalink / raw)
To: Ard Biesheuvel, devel
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Paul Grimes, Rebecca Cran,
Sami Mujawar, Thomas Abraham, Wenyi Xie, Jeremy Linton, Ling Jia,
Peng Xie, Yiqi Shu
For Silicon/Ampere/AmpereAltraPkg,
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
Tested-by: Nhi Pham <nhi@os.amperecomputing.com>
Thanks,
Nhi
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120186): https://edk2.groups.io/g/devel/message/120186
Mute This Topic: https://groups.io/mt/107649434/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf Ard Biesheuvel
2024-08-01 15:25 ` Nhi Pham via groups.io
@ 2024-08-05 19:14 ` Marcin Juszkiewicz
2024-08-06 14:08 ` Leif Lindholm
1 sibling, 1 reply; 21+ messages in thread
From: Marcin Juszkiewicz @ 2024-08-05 19:14 UTC (permalink / raw)
To: Ard Biesheuvel, devel
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Wojtas, Meenakshi Aggarwal,
Narinder Dhillon, Nhi Pham, Paul Grimes, Rebecca Cran,
Sami Mujawar, Thomas Abraham, Wenyi Xie, Jeremy Linton, Ling Jia,
Peng Xie, Yiqi Shu
On 31.07.2024 18:33, Ard Biesheuvel wrote:
> PrePeiCore has been superseded by Sec.inf, which is a more common naming
> for the SEC module, aligned with other architectures. No functional
> changes intended.
>
> Switch all users to Sec.inf so the old implementation can be retired
> from EDK2.
>
> Signed-off-by: Ard Biesheuvel<ardb@kernel.org>
For Qemu/SbsaQemu:
Reviewed-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
SbsaQemu does not boot without this patch applied:
UEFI firmware (version 1.0 built at 21:12:07 on Aug 5 2024)
add-symbol-file
/home/marcin/devel/linaro/sbsa-qemu/code/Build/SbsaQemu/DEBUG_CLANGDWARF/AARCH64/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore/DEBUG/ArmPlatformPrePeiCore.dll
0x10000800
add-symbol-file
/home/marcin/devel/linaro/sbsa-qemu/code/Build/SbsaQemu/DEBUG_CLANGDWARF/AARCH64/MdeModulePkg/Core/Pei/PeiMain/DEBUG/PeiCore.dll
0x10007240
Synchronous Exception at 0x0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120241): https://edk2.groups.io/g/devel/message/120241
Mute This Topic: https://groups.io/mt/107649434/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf
2024-08-05 19:14 ` Marcin Juszkiewicz
@ 2024-08-06 14:08 ` Leif Lindholm
0 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2024-08-06 14:08 UTC (permalink / raw)
To: devel, marcin.juszkiewicz
Cc: Ard Biesheuvel, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Wojtas, Meenakshi Aggarwal,
Narinder Dhillon, Nhi Pham, Paul Grimes, Rebecca Cran,
Sami Mujawar, Thomas Abraham, Wenyi Xie, Jeremy Linton, Ling Jia,
Peng Xie, Yiqi Shu
On Mon, Aug 05, 2024 at 21:14:33 +0200, Marcin Juszkiewicz wrote:
> On 31.07.2024 18:33, Ard Biesheuvel wrote:
> > PrePeiCore has been superseded by Sec.inf, which is a more common naming
> > for the SEC module, aligned with other architectures. No functional
> > changes intended.
> >
> > Switch all users to Sec.inf so the old implementation can be retired
> > from EDK2.
> >
> > Signed-off-by: Ard Biesheuvel<ardb@kernel.org>
>
> For Qemu/SbsaQemu:
>
> Reviewed-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Thanks!
> SbsaQemu does not boot without this patch applied:
>
> UEFI firmware (version 1.0 built at 21:12:07 on Aug 5 2024)
> add-symbol-file /home/marcin/devel/linaro/sbsa-qemu/code/Build/SbsaQemu/DEBUG_CLANGDWARF/AARCH64/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore/DEBUG/ArmPlatformPrePeiCore.dll
> 0x10000800
> add-symbol-file /home/marcin/devel/linaro/sbsa-qemu/code/Build/SbsaQemu/DEBUG_CLANGDWARF/AARCH64/MdeModulePkg/Core/Pei/PeiMain/DEBUG/PeiCore.dll
> 0x10007240
> Synchronous Exception at 0x0
Because of this breakage, I've pushed 1/2 separately as a3c898956a4d.
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120251): https://edk2.groups.io/g/devel/message/120251
Mute This Topic: https://groups.io/mt/107649434/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* [edk2-devel] [PATCH edk2-platforms 2/2] Platform AARCH64: Move PrePi users to PeilessSec.inf
2024-07-31 16:33 [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Ard Biesheuvel
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf Ard Biesheuvel
@ 2024-07-31 16:33 ` Ard Biesheuvel
2024-08-01 9:21 ` [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Sami Mujawar
2024-08-01 13:49 ` Jeremy Linton
3 siblings, 0 replies; 21+ messages in thread
From: Ard Biesheuvel @ 2024-07-31 16:33 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie,
Jeremy Linton, Ling Jia, Peng Xie, Yiqi Shu
PrePi has been superseded by PeilessSec.inf, which is a more common
naming for the SEC module, aligned with other architectures. No
functional changes intended.
Switch all users to PeilessSec.inf so the old implementation can be
retired from EDK2. No ArmPlatformStackLib resolution is needed in this
case, so drop those as well.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 -
Silicon/Hisilicon/Hisilicon.dsc.inc | 1 -
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 -
Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +-
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 2 +-
Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
Platform/Hisilicon/HiKey960/HiKey960.dsc | 2 +-
Platform/Phytium/DurianPkg/DurianPkg.dsc | 2 +-
Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +--
Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +--
Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +-
Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
Platform/Hisilicon/HiKey960/HiKey960.fdf | 2 +-
Platform/Phytium/DurianPkg/DurianPkg.fdf | 2 +-
Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +-
Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +-
17 files changed, 14 insertions(+), 19 deletions(-)
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index 8b9be9e0d372..eba2f2cf9f73 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -86,7 +86,6 @@ [LibraryClasses.common]
ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf
ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
ArmGicArchLib|ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
- ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf
diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index 652bc4d375e1..5db85841c5dc 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -55,7 +55,6 @@ [LibraryClasses.common]
ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf
ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
ArmGicArchLib|ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
- ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
index 78612d933ba7..988dddff06d9 100644
--- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
+++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
@@ -15,7 +15,6 @@ [LibraryClasses.common]
ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf
ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
ArmGicArchLib|ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
- ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf
ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
index 93ec9f129972..d3b1398d884c 100644
--- a/Platform/ARM/JunoPkg/ArmJuno.dsc
+++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
@@ -238,7 +238,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePi/PeiUniCore.inf
+ ArmPlatformPkg/PeilessSec/PeilessSec.inf
#
# DXE
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
index 2a812f4ac7aa..d57304699e83 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
@@ -228,7 +228,7 @@ [Components.common]
#
!ifdef EDK2_SKIP_PEICORE
# UEFI is placed in RAM by bootloader
- ArmPlatformPkg/PrePi/PeiUniCore.inf {
+ ArmPlatformPkg/PeilessSec/PeilessSec.inf {
<LibraryClasses>
ArmPlatformLib|Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf
}
diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
index c26df673afe9..bfbc5c120bef 100644
--- a/Platform/Hisilicon/HiKey/HiKey.dsc
+++ b/Platform/Hisilicon/HiKey/HiKey.dsc
@@ -163,7 +163,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePi/PeiUniCore.inf
+ ArmPlatformPkg/PeilessSec/PeilessSec.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf
diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
index 9e7c209716bc..08e8118539b6 100644
--- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
+++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
@@ -154,7 +154,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePi/PeiUniCore.inf
+ ArmPlatformPkg/PeilessSec/PeilessSec.inf
#
# DXE
diff --git a/Platform/Phytium/DurianPkg/DurianPkg.dsc b/Platform/Phytium/DurianPkg/DurianPkg.dsc
index 1232b5856d6c..04fc869b6c00 100644
--- a/Platform/Phytium/DurianPkg/DurianPkg.dsc
+++ b/Platform/Phytium/DurianPkg/DurianPkg.dsc
@@ -148,7 +148,7 @@ [Components.common]
OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
}
- ArmPlatformPkg/PrePi/PeiUniCore.inf {
+ ArmPlatformPkg/PeilessSec/PeilessSec.inf {
<LibraryClasses>
ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
}
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index f8cb82f9e2e6..da4976e4949e 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -123,7 +123,6 @@ [LibraryClasses.common]
ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf
DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf
TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
- ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf
@@ -583,7 +582,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePi/PeiUniCore.inf {
+ ArmPlatformPkg/PeilessSec/PeilessSec.inf {
<LibraryClasses>
SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.inf
}
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 113d08bc8448..92a54559df60 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -123,7 +123,6 @@ [LibraryClasses.common]
ArmGicArchLib|ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf
TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
- ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf
@@ -603,7 +602,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePi/PeiUniCore.inf {
+ ArmPlatformPkg/PeilessSec/PeilessSec.inf {
<LibraryClasses>
SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.inf
}
diff --git a/Platform/ARM/JunoPkg/ArmJuno.fdf b/Platform/ARM/JunoPkg/ArmJuno.fdf
index 0c5a50e968e1..dd743e04ef2f 100644
--- a/Platform/ARM/JunoPkg/ArmJuno.fdf
+++ b/Platform/ARM/JunoPkg/ArmJuno.fdf
@@ -270,7 +270,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePi/PeiUniCore.inf
+ INF ArmPlatformPkg/PeilessSec/PeilessSec.inf
FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
index df58b04778ff..c642761dc617 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
@@ -234,7 +234,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_STATUS = TRUE
!if $(EDK2_SKIP_PEICORE) == 1
- INF ArmPlatformPkg/PrePi/PeiUniCore.inf
+ INF ArmPlatformPkg/PeilessSec/PeilessSec.inf
!else
INF ArmPlatformPkg/Sec/Sec.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf b/Platform/Hisilicon/HiKey/HiKey.fdf
index d9fe481527fb..ad27f0cc29a9 100644
--- a/Platform/Hisilicon/HiKey/HiKey.fdf
+++ b/Platform/Hisilicon/HiKey/HiKey.fdf
@@ -207,7 +207,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePi/PeiUniCore.inf
+ INF ArmPlatformPkg/PeilessSec/PeilessSec.inf
FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {
diff --git a/Platform/Hisilicon/HiKey960/HiKey960.fdf b/Platform/Hisilicon/HiKey960/HiKey960.fdf
index dcb3105d6e77..ab4473045e24 100644
--- a/Platform/Hisilicon/HiKey960/HiKey960.fdf
+++ b/Platform/Hisilicon/HiKey960/HiKey960.fdf
@@ -195,7 +195,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePi/PeiUniCore.inf
+ INF ArmPlatformPkg/PeilessSec/PeilessSec.inf
FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {
diff --git a/Platform/Phytium/DurianPkg/DurianPkg.fdf b/Platform/Phytium/DurianPkg/DurianPkg.fdf
index 95db4ac6f183..476e35610899 100644
--- a/Platform/Phytium/DurianPkg/DurianPkg.fdf
+++ b/Platform/Phytium/DurianPkg/DurianPkg.fdf
@@ -222,7 +222,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePi/PeiUniCore.inf
+ INF ArmPlatformPkg/PeilessSec/PeilessSec.inf
FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {
diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf
index 090c4a621e90..bd719573918e 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.fdf
+++ b/Platform/RaspberryPi/RPi3/RPi3.fdf
@@ -321,7 +321,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePi/PeiUniCore.inf
+ INF ArmPlatformPkg/PeilessSec/PeilessSec.inf
FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {
SECTION FV_IMAGE = FVMAIN
diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
index 080e1638c1c5..6da2d4e3d74d 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.fdf
+++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
@@ -333,7 +333,7 @@ [FV.FVMAIN_COMPACT]
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
- INF ArmPlatformPkg/PrePi/PeiUniCore.inf
+ INF ArmPlatformPkg/PeilessSec/PeilessSec.inf
FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {
SECTION FV_IMAGE = FVMAIN
--
2.46.0.rc1.232.g9752f9e123-goog
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120155): https://edk2.groups.io/g/devel/message/120155
Mute This Topic: https://groups.io/mt/107649440/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-07-31 16:33 [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Ard Biesheuvel
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf Ard Biesheuvel
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 2/2] Platform AARCH64: Move PrePi users to PeilessSec.inf Ard Biesheuvel
@ 2024-08-01 9:21 ` Sami Mujawar
2024-08-01 13:49 ` Jeremy Linton
3 siblings, 0 replies; 21+ messages in thread
From: Sami Mujawar @ 2024-08-01 9:21 UTC (permalink / raw)
To: Ard Biesheuvel, devel
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
Hi Ard,
Thank you for this patch series.
For Platform/ARM/*, these changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120161): https://edk2.groups.io/g/devel/message/120161
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 1114 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-07-31 16:33 [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Ard Biesheuvel
` (2 preceding siblings ...)
2024-08-01 9:21 ` [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Sami Mujawar
@ 2024-08-01 13:49 ` Jeremy Linton
2024-08-01 14:11 ` Ard Biesheuvel
3 siblings, 1 reply; 21+ messages in thread
From: Jeremy Linton @ 2024-08-01 13:49 UTC (permalink / raw)
To: Ard Biesheuvel, devel
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
Hi,
On 7/31/24 11:33, Ard Biesheuvel wrote:
> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> to the new versions called Sec or PeilessSec - these have been cleaned
> up and stripped of obsolete functionality related to multicore boot,
> which is not something UEFI should concern itself with.
>
> This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> can be retired.
Hi,
Thanks for cleaning this up, but the rpi4 fails with:
Decompress GetInfo Failed - Invalid Parameter
ASSERT_EFI_ERROR (Status = Not Found)
ASSERT [PeilessSec]
/home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
!(((INTN)(RETURN_STATUS)(Status)) < 0)
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Graeme Gregory <graeme@xora.org.uk>
> Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Narinder Dhillon <ndhillon@marvell.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Cc: Paul Grimes <paul.grimes@amd.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Ling Jia <jialing@phytium.com.cn>
> Cc: Peng Xie <xiepeng@phytium.com.cn>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Yiqi Shu <shuyiqi@phytium.com.cn>
>
> Ard Biesheuvel (2):
> Platform AARCH64: Move PrePeiCore users to Sec.inf
> Platform AARCH64: Move PrePi users to PeilessSec.inf
>
> Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 +-
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 -
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 2 +-
> Silicon/Hisilicon/Hisilicon.dsc.inc | 1 -
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 +-
> Silicon/NXP/NxpQoriqLs.dsc.inc | 2 +-
> Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 -
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 +-
> Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +-
> Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 4 ++--
> Platform/Hisilicon/D03/D03.dsc | 2 +-
> Platform/Hisilicon/D05/D05.dsc | 2 +-
> Platform/Hisilicon/D06/D06.dsc | 2 +-
> Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
> Platform/Hisilicon/HiKey960/HiKey960.dsc | 2 +-
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 2 +-
> Platform/Phytium/DurianPkg/DurianPkg.dsc | 2 +-
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 +-
> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +--
> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +--
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 +-
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 2 +-
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 +-
> Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 2 +-
> Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
> Platform/ARM/Morello/MorelloPlatformFvp.fdf | 2 +-
> Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 2 +-
> Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 4 ++--
> Platform/Ampere/JadePkg/Jade.fdf | 2 +-
> Platform/Hisilicon/D03/D03.fdf | 2 +-
> Platform/Hisilicon/D05/D05.fdf | 2 +-
> Platform/Hisilicon/D06/D06.fdf | 2 +-
> Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
> Platform/Hisilicon/HiKey960/HiKey960.fdf | 2 +-
> Platform/LeMaker/CelloBoard/CelloBoard.fdf | 2 +-
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 2 +-
> Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf | 2 +-
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 2 +-
> Platform/Phytium/DurianPkg/DurianPkg.fdf | 2 +-
> Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 2 +-
> Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +-
> Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +-
> Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 2 +-
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 2 +-
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 2 +-
> Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 2 +-
> 49 files changed, 48 insertions(+), 53 deletions(-)
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120174): https://edk2.groups.io/g/devel/message/120174
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 13:49 ` Jeremy Linton
@ 2024-08-01 14:11 ` Ard Biesheuvel
2024-08-01 14:44 ` Ard Biesheuvel
0 siblings, 1 reply; 21+ messages in thread
From: Ard Biesheuvel @ 2024-08-01 14:11 UTC (permalink / raw)
To: Jeremy Linton
Cc: devel, Leif Lindholm, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> Hi,
>
> On 7/31/24 11:33, Ard Biesheuvel wrote:
> > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> > to the new versions called Sec or PeilessSec - these have been cleaned
> > up and stripped of obsolete functionality related to multicore boot,
> > which is not something UEFI should concern itself with.
> >
> > This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> > After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> > can be retired.
>
>
> Hi,
>
> Thanks for cleaning this up, but the rpi4 fails with:
>
> Decompress GetInfo Failed - Invalid Parameter
>
> ASSERT_EFI_ERROR (Status = Not Found)
> ASSERT [PeilessSec]
> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> !(((INTN)(RETURN_STATUS)(Status)) < 0)
>
Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
I'll look into it.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120176): https://edk2.groups.io/g/devel/message/120176
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 14:11 ` Ard Biesheuvel
@ 2024-08-01 14:44 ` Ard Biesheuvel
2024-08-01 15:19 ` Jeremy Linton
0 siblings, 1 reply; 21+ messages in thread
From: Ard Biesheuvel @ 2024-08-01 14:44 UTC (permalink / raw)
To: Jeremy Linton
Cc: devel, Leif Lindholm, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > Hi,
> >
> > On 7/31/24 11:33, Ard Biesheuvel wrote:
> > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> > > to the new versions called Sec or PeilessSec - these have been cleaned
> > > up and stripped of obsolete functionality related to multicore boot,
> > > which is not something UEFI should concern itself with.
> > >
> > > This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> > > After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> > > can be retired.
> >
> >
> > Hi,
> >
> > Thanks for cleaning this up, but the rpi4 fails with:
> >
> > Decompress GetInfo Failed - Invalid Parameter
> >
> > ASSERT_EFI_ERROR (Status = Not Found)
> > ASSERT [PeilessSec]
> > /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> > !(((INTN)(RETURN_STATUS)(Status)) < 0)
> >
>
> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
>
> I'll look into it.
The below should fix it - I'll update all DSCs with this if it works
for you as well.
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -193,7 +193,6 @@ [LibraryClasses.common.SEC]
MemoryInitPeiLib|Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf
PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
- LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
@@ -604,6 +603,7 @@ [Components.common]
#
ArmPlatformPkg/PeilessSec/PeilessSec.inf {
<LibraryClasses>
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.inf
}
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120177): https://edk2.groups.io/g/devel/message/120177
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 14:44 ` Ard Biesheuvel
@ 2024-08-01 15:19 ` Jeremy Linton
2024-08-01 15:43 ` Ard Biesheuvel
2024-08-06 14:10 ` Leif Lindholm
0 siblings, 2 replies; 21+ messages in thread
From: Jeremy Linton @ 2024-08-01 15:19 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: devel, Leif Lindholm, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
Hi,
On 8/1/24 09:44, Ard Biesheuvel wrote:
> On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
>>
>> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
>>>
>>> Hi,
>>>
>>> On 7/31/24 11:33, Ard Biesheuvel wrote:
>>>> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
>>>> to the new versions called Sec or PeilessSec - these have been cleaned
>>>> up and stripped of obsolete functionality related to multicore boot,
>>>> which is not something UEFI should concern itself with.
>>>>
>>>> This series can be merged once Tianocore/edk2 PR #5997 is merged first.
>>>> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
>>>> can be retired.
>>>
>>>
>>> Hi,
>>>
>>> Thanks for cleaning this up, but the rpi4 fails with:
>>>
>>> Decompress GetInfo Failed - Invalid Parameter
>>>
>>> ASSERT_EFI_ERROR (Status = Not Found)
>>> ASSERT [PeilessSec]
>>> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
>>> !(((INTN)(RETURN_STATUS)(Status)) < 0)
>>>
>>
>> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
>>
>> I'll look into it.
>
> The below should fix it - I'll update all DSCs with this if it works
> for you as well.
That fixes the problem above. Thanks!
I just spent an hour hunting a sd stall heisenbug I've never seen before
too, which initially I thought might be related to the set from earlier
this week, but it seems doubtful since the controller stalled far to
late in the firmware boot for it to be related. Looks like it just
glitched out and stopped responding to commands, and I either got
impatient and power cycled it to soon, or the reset/recovery logic isn't
right, but I don't know since I killed it to quickly and now can't
reproduce it.
>
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -193,7 +193,6 @@ [LibraryClasses.common.SEC]
> MemoryInitPeiLib|Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf
> PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> - LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
> @@ -604,6 +603,7 @@ [Components.common]
> #
> ArmPlatformPkg/PeilessSec/PeilessSec.inf {
> <LibraryClasses>
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.inf
> }
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120183): https://edk2.groups.io/g/devel/message/120183
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 15:19 ` Jeremy Linton
@ 2024-08-01 15:43 ` Ard Biesheuvel
2024-08-01 15:50 ` Rebecca Cran
2024-08-06 14:10 ` Leif Lindholm
1 sibling, 1 reply; 21+ messages in thread
From: Ard Biesheuvel @ 2024-08-01 15:43 UTC (permalink / raw)
To: devel, jeremy.linton
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On Thu, 1 Aug 2024 at 17:19, Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> Hi,
>
>
> On 8/1/24 09:44, Ard Biesheuvel wrote:
> > On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
> >>
> >> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >>>
> >>> Hi,
> >>>
> >>> On 7/31/24 11:33, Ard Biesheuvel wrote:
> >>>> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> >>>> to the new versions called Sec or PeilessSec - these have been cleaned
> >>>> up and stripped of obsolete functionality related to multicore boot,
> >>>> which is not something UEFI should concern itself with.
> >>>>
> >>>> This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> >>>> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> >>>> can be retired.
> >>>
> >>>
> >>> Hi,
> >>>
> >>> Thanks for cleaning this up, but the rpi4 fails with:
> >>>
> >>> Decompress GetInfo Failed - Invalid Parameter
> >>>
> >>> ASSERT_EFI_ERROR (Status = Not Found)
> >>> ASSERT [PeilessSec]
> >>> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> >>> !(((INTN)(RETURN_STATUS)(Status)) < 0)
> >>>
> >>
> >> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
> >>
> >> I'll look into it.
> >
> > The below should fix it - I'll update all DSCs with this if it works
> > for you as well.
>
> That fixes the problem above. Thanks!
>
>
>
> I just spent an hour hunting a sd stall heisenbug I've never seen before
> too, which initially I thought might be related to the set from earlier
> this week, but it seems doubtful since the controller stalled far to
> late in the firmware boot for it to be related. Looks like it just
> glitched out and stopped responding to commands, and I either got
> impatient and power cycled it to soon, or the reset/recovery logic isn't
> right, but I don't know since I killed it to quickly and now can't
> reproduce it.
>
Haven't noticed this one myself. The only issue I hit once in a while
(but only with DEBUG builds as far as I am aware) is an ASSERT() on
some XhciDxe control register read (or perhaps a timeout?)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120188): https://edk2.groups.io/g/devel/message/120188
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 15:43 ` Ard Biesheuvel
@ 2024-08-01 15:50 ` Rebecca Cran
2024-08-01 15:54 ` Ard Biesheuvel
2024-08-01 18:50 ` Jeremy Linton
0 siblings, 2 replies; 21+ messages in thread
From: Rebecca Cran @ 2024-08-01 15:50 UTC (permalink / raw)
To: devel, ardb, jeremy.linton
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On 8/1/24 9:43 AM, Ard Biesheuvel wrote:
> Haven't noticed this one myself. The only issue I hit once in a while
> (but only with DEBUG builds as far as I am aware) is an ASSERT() on
> some XhciDxe control register read (or perhaps a timeout?)
This might be the XHCI bug where there's missing error handling around a
controller reset failure. I have a patch to send to fix it.
--
Rebecca
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120190): https://edk2.groups.io/g/devel/message/120190
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 15:50 ` Rebecca Cran
@ 2024-08-01 15:54 ` Ard Biesheuvel
2024-08-01 18:50 ` Jeremy Linton
1 sibling, 0 replies; 21+ messages in thread
From: Ard Biesheuvel @ 2024-08-01 15:54 UTC (permalink / raw)
To: devel, rebecca
Cc: jeremy.linton, Leif Lindholm, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On Thu, 1 Aug 2024 at 17:50, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> On 8/1/24 9:43 AM, Ard Biesheuvel wrote:
>
> > Haven't noticed this one myself. The only issue I hit once in a while
> > (but only with DEBUG builds as far as I am aware) is an ASSERT() on
> > some XhciDxe control register read (or perhaps a timeout?)
>
> This might be the XHCI bug where there's missing error handling around a
> controller reset failure. I have a patch to send to fix it.
>
Please do.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120192): https://edk2.groups.io/g/devel/message/120192
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 15:50 ` Rebecca Cran
2024-08-01 15:54 ` Ard Biesheuvel
@ 2024-08-01 18:50 ` Jeremy Linton
2024-08-02 11:44 ` Rebecca Cran
1 sibling, 1 reply; 21+ messages in thread
From: Jeremy Linton @ 2024-08-01 18:50 UTC (permalink / raw)
To: Rebecca Cran, devel, ardb
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On 8/1/24 10:50, Rebecca Cran wrote:
> On 8/1/24 9:43 AM, Ard Biesheuvel wrote:
>
>> Haven't noticed this one myself. The only issue I hit once in a while
>> (but only with DEBUG builds as far as I am aware) is an ASSERT() on
>> some XhciDxe control register read (or perhaps a timeout?)
>
> This might be the XHCI bug where there's missing error handling around a
> controller reset failure. I have a patch to send to fix it.
>
>
I would second the please send the patch request. I've got a USB raid
enclosure I carried a patch for a few years similar to the one in this
discussion: https://edk2.groups.io/g/devel/message/58193
Plugging a jmicron based yottamaster JBOD into an edk2/xhci setup is
still a 100% guaranteed crash, and with the recent rework in
UsbIoPortReset()/etc now fails like:
https://paste.centos.org/view/fbff41dc
UsbIoPortReset: Failed to set configuration - Out of Resources
Synchronous Exception at 0x0000000036A5635C
PC 0x000036A5635C (0x000036A55000+0x0000135C) [ 0] UsbBusDxe.dll
PC 0x000036A576D0 (0x000036A55000+0x000026D0) [ 0] UsbBusDxe.dll
PC 0x000036A44E00 (0x000036A42000+0x00002E00) [ 1] UsbMassStorageDxe.dll
PC 0x000036A45888 (0x000036A42000+0x00003888) [ 1] UsbMassStorageDxe.dll
PC 0x000036A46D74 (0x000036A42000+0x00004D74) [ 1] UsbMassStorageDxe.dll
PC 0x000036A46F00 (0x000036A42000+0x00004F00) [ 1] UsbMassStorageDxe.dll
PC 0x000036CC0EBC (0x000036CBD000+0x00003EBC) [ 2] DiskIoDxe.dll
PC 0x000036CB82CC (0x000036CB3000+0x000052CC) [ 3] PartitionDxe.dll
PC 0x000036CB590C (0x000036CB3000+0x0000290C) [ 3] PartitionDxe.dll
PC 0x000039F37FAC (0x000039F33000+0x00004FAC) [ 4] DxeCore.dll
PC 0x000039F38250 (0x000039F33000+0x00005250) [ 4] DxeCore.dll
PC 0x000036A5A748 (0x000036A55000+0x00005748) [ 5] UsbBusDxe.dll
PC 0x000036A5B1D0 (0x000036A55000+0x000061D0) [ 5] UsbBusDxe.dll
PC 0x000036A5CBA4 (0x000036A55000+0x00007BA4) [ 5] UsbBusDxe.dll
PC 0x000036A5CDF0 (0x000036A55000+0x00007DF0) [ 5] UsbBusDxe.dll
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120193): https://edk2.groups.io/g/devel/message/120193
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 18:50 ` Jeremy Linton
@ 2024-08-02 11:44 ` Rebecca Cran
2024-08-05 16:17 ` Jeremy Linton
0 siblings, 1 reply; 21+ messages in thread
From: Rebecca Cran @ 2024-08-02 11:44 UTC (permalink / raw)
To: Jeremy Linton, devel, ardb
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On 8/1/24 12:50, Jeremy Linton wrote:
> On 8/1/24 10:50, Rebecca Cran wrote:
>> On 8/1/24 9:43 AM, Ard Biesheuvel wrote:
>>
>>> Haven't noticed this one myself. The only issue I hit once in a while
>>> (but only with DEBUG builds as far as I am aware) is an ASSERT() on
>>> some XhciDxe control register read (or perhaps a timeout?)
>>
>> This might be the XHCI bug where there's missing error handling around
>> a controller reset failure. I have a patch to send to fix it.
>>
>>
>
> I would second the please send the patch request. I've got a USB raid
> enclosure I carried a patch for a few years similar to the one in this
> discussion: https://edk2.groups.io/g/devel/message/58193
I've created a PR with the patch:
https://github.com/tianocore/edk2/pull/6033
--
Rebecca
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120211): https://edk2.groups.io/g/devel/message/120211
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-02 11:44 ` Rebecca Cran
@ 2024-08-05 16:17 ` Jeremy Linton
0 siblings, 0 replies; 21+ messages in thread
From: Jeremy Linton @ 2024-08-05 16:17 UTC (permalink / raw)
To: Rebecca Cran, devel, ardb
Cc: Leif Lindholm, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
Hi,
On 8/2/24 06:44, Rebecca Cran wrote:
> On 8/1/24 12:50, Jeremy Linton wrote:
>> On 8/1/24 10:50, Rebecca Cran wrote:
>>> On 8/1/24 9:43 AM, Ard Biesheuvel wrote:
>>>
>>>> Haven't noticed this one myself. The only issue I hit once in a while
>>>> (but only with DEBUG builds as far as I am aware) is an ASSERT() on
>>>> some XhciDxe control register read (or perhaps a timeout?)
>>>
>>> This might be the XHCI bug where there's missing error handling
>>> around a controller reset failure. I have a patch to send to fix it.
>>>
>>>
>>
>> I would second the please send the patch request. I've got a USB raid
>> enclosure I carried a patch for a few years similar to the one in this
>> discussion: https://edk2.groups.io/g/devel/message/58193
>
> I've created a PR with the patch:
> https://github.com/tianocore/edk2/pull/6033
>
Hi, so that patch doesn't fix the USB/XHCI error I posted last week, and
that's largely because its not fixing the out of resources issues which
happen when the controller is repeatedly reset. Which itself is in
error, because the returned check condition is valid, but indicating the
device doesn't support the requested command. So the usb subsystem
should _NOT_ be repeatedly resetting, rather it should be trying to use
a different command, or simply ignoring the device since reset implies
there is something wrong with the device/communications channel. Which
isn't the case, the device is perfectly happy, its simply refusing the
requested command.
Also, I hit the MMC error again on the rpi, it seems to be a block size
overflow that isn't being handled correctly. The request is for more
data than a single write the SD card I have seems to support. So, then
it should be sending the remaining block, but its getting stuck sending
MMC_CMD13, presumably waiting for the previous write to complete, which
never happens.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120236): https://edk2.groups.io/g/devel/message/120236
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-01 15:19 ` Jeremy Linton
2024-08-01 15:43 ` Ard Biesheuvel
@ 2024-08-06 14:10 ` Leif Lindholm
2024-08-27 16:37 ` Ard Biesheuvel via groups.io
1 sibling, 1 reply; 21+ messages in thread
From: Leif Lindholm @ 2024-08-06 14:10 UTC (permalink / raw)
To: Jeremy Linton
Cc: Ard Biesheuvel, devel, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote:
> Hi,
>
>
> On 8/1/24 09:44, Ard Biesheuvel wrote:
> > On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
> > >
> > > On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > On 7/31/24 11:33, Ard Biesheuvel wrote:
> > > > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> > > > > to the new versions called Sec or PeilessSec - these have been cleaned
> > > > > up and stripped of obsolete functionality related to multicore boot,
> > > > > which is not something UEFI should concern itself with.
> > > > >
> > > > > This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> > > > > After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> > > > > can be retired.
> > > >
> > > >
> > > > Hi,
> > > >
> > > > Thanks for cleaning this up, but the rpi4 fails with:
> > > >
> > > > Decompress GetInfo Failed - Invalid Parameter
> > > >
> > > > ASSERT_EFI_ERROR (Status = Not Found)
> > > > ASSERT [PeilessSec]
> > > > /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> > > > !(((INTN)(RETURN_STATUS)(Status)) < 0)
> > > >
> > >
> > > Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
> > >
> > > I'll look into it.
> >
> > The below should fix it - I'll update all DSCs with this if it works
> > for you as well.
>
> That fixes the problem above. Thanks!
Can I take that as an R-b on the Rpi changes in this set?
Regards,
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120252): https://edk2.groups.io/g/devel/message/120252
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-06 14:10 ` Leif Lindholm
@ 2024-08-27 16:37 ` Ard Biesheuvel via groups.io
2024-08-28 3:54 ` Jeremy Linton
0 siblings, 1 reply; 21+ messages in thread
From: Ard Biesheuvel via groups.io @ 2024-08-27 16:37 UTC (permalink / raw)
To: devel, quic_llindhol
Cc: Jeremy Linton, Abdul Lateef Attar, Abner Chang, Chuong Tran,
Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On Tue, 6 Aug 2024 at 16:10, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote:
> > Hi,
> >
> >
> > On 8/1/24 09:44, Ard Biesheuvel wrote:
> > > On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
> > > >
> > > > On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On 7/31/24 11:33, Ard Biesheuvel wrote:
> > > > > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> > > > > > to the new versions called Sec or PeilessSec - these have been cleaned
> > > > > > up and stripped of obsolete functionality related to multicore boot,
> > > > > > which is not something UEFI should concern itself with.
> > > > > >
> > > > > > This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> > > > > > After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> > > > > > can be retired.
> > > > >
> > > > >
> > > > > Hi,
> > > > >
> > > > > Thanks for cleaning this up, but the rpi4 fails with:
> > > > >
> > > > > Decompress GetInfo Failed - Invalid Parameter
> > > > >
> > > > > ASSERT_EFI_ERROR (Status = Not Found)
> > > > > ASSERT [PeilessSec]
> > > > > /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> > > > > !(((INTN)(RETURN_STATUS)(Status)) < 0)
> > > > >
> > > >
> > > > Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
> > > >
> > > > I'll look into it.
> > >
> > > The below should fix it - I'll update all DSCs with this if it works
> > > for you as well.
> >
> > That fixes the problem above. Thanks!
>
> Can I take that as an R-b on the Rpi changes in this set?
>
In the interest of progress on the EDK2 side, I intend to merge the
remaining 2/2 of this set tomorrow, on the basis that it is primarily
a code refactoring change that works correctly on the platforms that I
can readily test (RPi3 / RPi4).
If anyone objects to this, please leave a reply on the thread.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120417): https://edk2.groups.io/g/devel/message/120417
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-27 16:37 ` Ard Biesheuvel via groups.io
@ 2024-08-28 3:54 ` Jeremy Linton
2024-08-28 7:54 ` Ard Biesheuvel via groups.io
0 siblings, 1 reply; 21+ messages in thread
From: Jeremy Linton @ 2024-08-28 3:54 UTC (permalink / raw)
To: Ard Biesheuvel, devel, quic_llindhol
Cc: Abdul Lateef Attar, Abner Chang, Chuong Tran, Graeme Gregory,
Marcin Juszkiewicz, Marcin Wojtas, Meenakshi Aggarwal,
Narinder Dhillon, Nhi Pham, Paul Grimes, Rebecca Cran,
Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia, Peng Xie,
Yiqi Shu
On 8/27/24 11:37, Ard Biesheuvel wrote:
> On Tue, 6 Aug 2024 at 16:10, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>>
>> On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote:
>>> Hi,
>>>
>>>
>>> On 8/1/24 09:44, Ard Biesheuvel wrote:
>>>> On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
>>>>>
>>>>> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> On 7/31/24 11:33, Ard Biesheuvel wrote:
>>>>>>> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
>>>>>>> to the new versions called Sec or PeilessSec - these have been cleaned
>>>>>>> up and stripped of obsolete functionality related to multicore boot,
>>>>>>> which is not something UEFI should concern itself with.
>>>>>>>
>>>>>>> This series can be merged once Tianocore/edk2 PR #5997 is merged first.
>>>>>>> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
>>>>>>> can be retired.
>>>>>>
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Thanks for cleaning this up, but the rpi4 fails with:
>>>>>>
>>>>>> Decompress GetInfo Failed - Invalid Parameter
>>>>>>
>>>>>> ASSERT_EFI_ERROR (Status = Not Found)
>>>>>> ASSERT [PeilessSec]
>>>>>> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
>>>>>> !(((INTN)(RETURN_STATUS)(Status)) < 0)
>>>>>>
>>>>>
>>>>> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
>>>>>
>>>>> I'll look into it.
>>>>
>>>> The below should fix it - I'll update all DSCs with this if it works
>>>> for you as well.
>>>
>>> That fixes the problem above. Thanks!
>>
>> Can I take that as an R-b on the Rpi changes in this set?
>>
>
> In the interest of progress on the EDK2 side, I intend to merge the
> remaining 2/2 of this set tomorrow, on the basis that it is primarily
> a code refactoring change that works correctly on the platforms that I
> can readily test (RPi3 / RPi4).
>
> If anyone objects to this, please leave a reply on the thread.
Ok..
For the rpi4 parts
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
and
Tested-by: Jeremy Linton <jeremy.linton@arm.com>
(although EDK doesn't use tested-by does it?)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120421): https://edk2.groups.io/g/devel/message/120421
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
2024-08-28 3:54 ` Jeremy Linton
@ 2024-08-28 7:54 ` Ard Biesheuvel via groups.io
0 siblings, 0 replies; 21+ messages in thread
From: Ard Biesheuvel via groups.io @ 2024-08-28 7:54 UTC (permalink / raw)
To: Jeremy Linton
Cc: devel, quic_llindhol, Abdul Lateef Attar, Abner Chang,
Chuong Tran, Graeme Gregory, Marcin Juszkiewicz, Marcin Wojtas,
Meenakshi Aggarwal, Narinder Dhillon, Nhi Pham, Paul Grimes,
Rebecca Cran, Sami Mujawar, Thomas Abraham, Wenyi Xie, Ling Jia,
Peng Xie, Yiqi Shu
On Wed, 28 Aug 2024 at 06:12, Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> On 8/27/24 11:37, Ard Biesheuvel wrote:
> > On Tue, 6 Aug 2024 at 16:10, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> >>
> >> On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote:
> >>> Hi,
> >>>
> >>>
> >>> On 8/1/24 09:44, Ard Biesheuvel wrote:
> >>>> On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
> >>>>>
> >>>>> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >>>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> On 7/31/24 11:33, Ard Biesheuvel wrote:
> >>>>>>> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> >>>>>>> to the new versions called Sec or PeilessSec - these have been cleaned
> >>>>>>> up and stripped of obsolete functionality related to multicore boot,
> >>>>>>> which is not something UEFI should concern itself with.
> >>>>>>>
> >>>>>>> This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> >>>>>>> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> >>>>>>> can be retired.
> >>>>>>
> >>>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> Thanks for cleaning this up, but the rpi4 fails with:
> >>>>>>
> >>>>>> Decompress GetInfo Failed - Invalid Parameter
> >>>>>>
> >>>>>> ASSERT_EFI_ERROR (Status = Not Found)
> >>>>>> ASSERT [PeilessSec]
> >>>>>> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> >>>>>> !(((INTN)(RETURN_STATUS)(Status)) < 0)
> >>>>>>
> >>>>>
> >>>>> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
> >>>>>
> >>>>> I'll look into it.
> >>>>
> >>>> The below should fix it - I'll update all DSCs with this if it works
> >>>> for you as well.
> >>>
> >>> That fixes the problem above. Thanks!
> >>
> >> Can I take that as an R-b on the Rpi changes in this set?
> >>
> >
> > In the interest of progress on the EDK2 side, I intend to merge the
> > remaining 2/2 of this set tomorrow, on the basis that it is primarily
> > a code refactoring change that works correctly on the platforms that I
> > can readily test (RPi3 / RPi4).
> >
> > If anyone objects to this, please leave a reply on the thread.
>
> Ok..
>
> For the rpi4 parts
>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
>
> and
>
> Tested-by: Jeremy Linton <jeremy.linton@arm.com>
>
> (although EDK doesn't use tested-by does it?)
>
It does. Thanks.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120422): https://edk2.groups.io/g/devel/message/120422
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 21+ messages in thread