From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 379FCAC1BCB for ; Fri, 17 Nov 2023 20:30:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qJIvGvrbfPF/wLze8++pkL6Glyt/ULR2x1xxz5M6iRg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700253010; v=1; b=BUIW0smnOuMO5kYgZ7GEIoJJTOWulUnBtPmunFEmQb7t5etgJ22Io2pVp3rWGntjOLRDYAx4 k0L1XuMuIs4O3PI+8r3j9CkbeaFyKnShztLWEmHULjXZU4dhxuHsvxIaDU4y18qWSW7DBDuxxP+ aIppaMzjjOwg2ZvVOuLoJ/GM= X-Received: by 127.0.0.2 with SMTP id tX9TYY7687511x6NQ8IZyTzn; Fri, 17 Nov 2023 12:30:10 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.5790.1700253010126185662 for ; Fri, 17 Nov 2023 12:30:10 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-cy1yoA3xNXW6rUWFHHasiQ-1; Fri, 17 Nov 2023 15:30:05 -0500 X-MC-Unique: cy1yoA3xNXW6rUWFHHasiQ-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A27C811E82; Fri, 17 Nov 2023 20:30:05 +0000 (UTC) X-Received: from [10.39.192.39] (unknown [10.39.192.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB905492BE0; Fri, 17 Nov 2023 20:30:02 +0000 (UTC) Message-ID: <783347b8-2ea4-7dc4-7793-1d6d871fb47b@redhat.com> Date: Fri, 17 Nov 2023 21:30:01 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation To: Ashish Singhal , "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "ardb+tianocore@kernel.org" , "sami.mujawar@arm.com" , Jeff Brasen Cc: Michael Kinney , "Liming Gao (Byosoft address)" References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sO2X4SCLsFoyrh9atgH5xRBEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BUIW0smn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/17/23 17:37, Ashish Singhal wrote: > > > ------------------------------------------------------------------------ > *From:* Laszlo Ersek > *Sent:* Friday, November 17, 2023 2:20 AM > *To:* devel@edk2.groups.io ; Ashish Singhal > ; quic_llindhol@quicinc.com > ; ardb+tianocore@kernel.org > ; sami.mujawar@arm.com > ; Jeff Brasen > *Cc:* Michael Kinney ; Liming Gao (Byosoft > address) > *Subject:* Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation >   > External email: Use caution opening links or attachments > > > On 11/15/23 04:19, Ashish Singhal via groups.io wrote: >> Just like CPU _UID, ETE UID also needs to be unique so >> use AcpiProcessorUid instead of CpuName >> >> Signed-off-by: Ashish Singhal >> --- >>  .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- >>  1 file changed, 4 insertions(+), 1 deletion(-) > > Is this a fixup for the recent feature > > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support > https://edk2.groups.io/g/devel/message/108996 > > > ? > > If so, then I *think* this qualifies to be merged during the hard > feature freeze (+Liming +Mike), but: > > - I think we should have a "Fixes:" tag in the commit message (for > pointing out the commit that should have contained the code being > added/updated now) > > - I think we should have a BZ too (also linked into the commit message). > > Laszlo > > Hello Laszlo, > > The issue was indeed introduced in the patch series you pointed to and > precisely in the commit > https://github.com/tianocore/edk2/commit/3ee23713e1ce09faa6fa66ee6799e3e336deb58b . This is indeed a bug and should ideally be fixed as soon as possible. Do you need me to file BZ bug and link that in commit message? A BZ ticket would be great, yes. It helps with the release notes (determining the contents of a release). If/when you file the new BZ, please add the old BZ's URL to the See Also field. ... Oh, wait, the original series didn't have a BZ. That's a pity. Thanks Laszlo > > Thanks > Ashish > >> >> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c >> index 8228c7845a..724f33c660 100644 >> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c >> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c >> @@ -359,6 +359,7 @@ CreateAmlCpcNode ( >> >>    @param [in]  Generator    The SSDT Cpu Topology generator. >>    @param [in]  ParentNode   Parent node to attach the Cpu node to. >> +  @param [in]  GicCInfo     CM_ARM_GICC_INFO object used to create the node. >>    @param [in]  CpuName      Value used to generate the node name. >>    @param [out] EtNodePtr   If not NULL, return the created Cpu node. >> >> @@ -372,6 +373,7 @@ EFIAPI >>  CreateAmlEtd ( >>    IN   ACPI_CPU_TOPOLOGY_GENERATOR  *Generator, >>    IN   AML_NODE_HANDLE              ParentNode, >> +  IN   CM_ARM_GICC_INFO             *GicCInfo, >>    IN   UINT32                       CpuName, >>    OUT  AML_OBJECT_NODE_HANDLE       *EtNodePtr OPTIONAL >>    ) >> @@ -397,7 +399,7 @@ CreateAmlEtd ( >> >>    Status = AmlCodeGenNameInteger ( >>               "_UID", >> -             CpuName, >> +             GicCInfo->AcpiProcessorUid, >>               EtNode, >>               NULL >>               ); >> @@ -474,6 +476,7 @@ CreateAmlEtNode ( >>    Status = CreateAmlEtd ( >>               Generator, >>               Node, >> +             GicCInfo, >>               CpuName, >>               NULL >>               ); > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111413): https://edk2.groups.io/g/devel/message/111413 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-