Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

["PierreGondois" <pierre.gondois@arm.com>]

Hello Abdul,
I added some comments.
I think that:
a. patches related to HPET/WSMT should require little work
b. MADT patch needs to redefine the CmObjects it uses,
    but it seems ok otherwise (just need to have the right properties
    in the right objects),
c. FADT patch is re-defining CmObjects that are already existing
    in ArmNameSpaceObjects.h. So there is going to be a clash with
    ongoing DynamicTables objects reorganization...

I think that a. could be sent separately and should quickly go in,
b. might require a bit more checking/reviewing, and c. might need
to wait for the re-org to be finished, unless Sami thinks it's ok
to take the patch,

Regards,
Pierre


On 4/29/24 08:03, Abdul Lateef Attar wrote:
> PR: https://github.com/tianocore/edk2/pull/5500/
> V4: delta changes
>    Added X64 arch specific MADT table generator.
> V3: delta changes
>    Restructure the code as the review comments.
>    Added sanity check for WSMT flags.
>    Added CM object for HPET base address.
> V2: delta changes
>    Addressed review comments
>    Adds ACPI HPET table to add HPET to ACPI namespace
> V1:
> Adds new space for ArchNameSpaceObjects.
> Adds generic FADT table generator.
> Adds generic HPET table generator.
> Adds generic WSMT table generator.
> 
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> 
> Abdul Lateef Attar (5):
>    DynamicTablesPkg: Adds ACPI FADT Table generator
>    DynamicTablesPkg: Adds ACPI HPET Table generator
>    DynamicTablesPkg: Adds ACPI WSMT Table generator
>    DynamicTablesPkg: Adds ACPI SSDT HPET Table generator
>    DynamicTablesPkg: Adds X64 arch MADT Table generator
> 
>   DynamicTablesPkg/DynamicTables.dsc.inc        |  22 +-
>   DynamicTablesPkg/DynamicTablesPkg.ci.yaml     |   4 +-
>   DynamicTablesPkg/Include/AcpiTableGenerator.h |   4 +
>   .../Include/ArchNameSpaceObjects.h            | 237 ++++++
>   .../Include/ConfigurationManagerObject.h      |   7 +
>   .../Include/X64NameSpaceObjects.h             |  48 ++
>   .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf  |  36 +
>   .../Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c |  39 +
>   .../Library/Acpi/AcpiFadtLib/FadtGenerator.c  | 745 ++++++++++++++++++
>   .../Library/Acpi/AcpiFadtLib/FadtUpdate.h     |  26 +
>   .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c |  32 +
>   .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf  |  31 +
>   .../Library/Acpi/AcpiHpetLib/HpetGenerator.c  | 246 ++++++
>   .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf  |  32 +
>   .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c  | 295 +++++++
>   .../Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf  |  30 +
>   .../Library/Acpi/AcpiWsmtLib/WsmtGenerator.c  | 243 ++++++
>   .../X64/AcpiMadtLibX64/AcpiMadtLibX64.inf     |  27 +
>   .../Acpi/X64/AcpiMadtLibX64/MadtGenerator.c   | 375 +++++++++
>   19 files changed, 2477 insertions(+), 2 deletions(-)
>   create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h
>   create mode 100644 DynamicTablesPkg/Include/X64NameSpaceObjects.h
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate.h
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/WsmtGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/AcpiMadtLibX64.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/MadtGenerator.c
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118528): https://edk2.groups.io/g/devel/message/118528
Mute This Topic: https://groups.io/mt/105796049/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-