From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 21419780091 for ; Thu, 2 May 2024 16:35:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=du850zFbzss34OsM4Y5BFNJyLtahbgsrKhMNeUwJQSw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714667756; v=1; b=DBIV4oWOQZt4bQFbyRZtfw+ClqPXH0WhJeQSP/VKRvzfElrNCRCY0ZXTqaefDMiem2x4rDQW II913Ajtc8Tm2GxYN+443EcjHAfCs0J72/l9KJPigytAoPJGAUk2tNjXKQkBrwyUbutcB9gqpYY QTNn8wnUl+R/cNIjO+5ifxJBaAh/qmacwXXHaG2noq/J5+U5qlq8EeJSnUkkrgPHQ/0xOnHYBeg bvRPdLr1uTbgI03XQfU+jjva/fL99TkIYIMxLindDv4YjwdQgxN9/zbLqbHepVZJX71JdrveUXR a0skZAYh1ZezAxGIdBSOYntuzWv2D7hMywZHdFDfoOFAw== X-Received: by 127.0.0.2 with SMTP id yL5jYY7687511xM20tjvGLDj; Thu, 02 May 2024 09:35:56 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.1085.1714667755491938698 for ; Thu, 02 May 2024 09:35:55 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 455252F4; Thu, 2 May 2024 09:36:20 -0700 (PDT) X-Received: from [10.34.111.156] (e126645.nice.Arm.com [10.34.111.156]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E5E923F793; Thu, 2 May 2024 09:35:53 -0700 (PDT) Message-ID: <783a23af-5eec-48c9-bcbd-be1c40518e54@arm.com> Date: Thu, 2 May 2024 18:35:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Sami Mujawar References: From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 09:35:55 -0700 Resent-From: pierre.gondois@arm.com Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OCYZsdmq2EtIUN0I4Gg4vm0Rx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=DBIV4oWO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Abdul, I added some comments. I think that: a. patches related to HPET/WSMT should require little work b. MADT patch needs to redefine the CmObjects it uses, but it seems ok otherwise (just need to have the right properties in the right objects), c. FADT patch is re-defining CmObjects that are already existing in ArmNameSpaceObjects.h. So there is going to be a clash with ongoing DynamicTables objects reorganization... I think that a. could be sent separately and should quickly go in, b. might require a bit more checking/reviewing, and c. might need to wait for the re-org to be finished, unless Sami thinks it's ok to take the patch, Regards, Pierre On 4/29/24 08:03, Abdul Lateef Attar wrote: > PR: https://github.com/tianocore/edk2/pull/5500/ > V4: delta changes > Added X64 arch specific MADT table generator. > V3: delta changes > Restructure the code as the review comments. > Added sanity check for WSMT flags. > Added CM object for HPET base address. > V2: delta changes > Addressed review comments > Adds ACPI HPET table to add HPET to ACPI namespace > V1: > Adds new space for ArchNameSpaceObjects. > Adds generic FADT table generator. > Adds generic HPET table generator. > Adds generic WSMT table generator. >=20 > Cc: Sami Mujawar > Cc: Pierre Gondois > Cc: Abdul Lateef Attar >=20 > Abdul Lateef Attar (5): > DynamicTablesPkg: Adds ACPI FADT Table generator > DynamicTablesPkg: Adds ACPI HPET Table generator > DynamicTablesPkg: Adds ACPI WSMT Table generator > DynamicTablesPkg: Adds ACPI SSDT HPET Table generator > DynamicTablesPkg: Adds X64 arch MADT Table generator >=20 > DynamicTablesPkg/DynamicTables.dsc.inc | 22 +- > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 4 +- > DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 + > .../Include/ArchNameSpaceObjects.h | 237 ++++++ > .../Include/ConfigurationManagerObject.h | 7 + > .../Include/X64NameSpaceObjects.h | 48 ++ > .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf | 36 + > .../Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c | 39 + > .../Library/Acpi/AcpiFadtLib/FadtGenerator.c | 745 ++++++++++++++++++ > .../Library/Acpi/AcpiFadtLib/FadtUpdate.h | 26 + > .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c | 32 + > .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf | 31 + > .../Library/Acpi/AcpiHpetLib/HpetGenerator.c | 246 ++++++ > .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf | 32 + > .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c | 295 +++++++ > .../Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf | 30 + > .../Library/Acpi/AcpiWsmtLib/WsmtGenerator.c | 243 ++++++ > .../X64/AcpiMadtLibX64/AcpiMadtLibX64.inf | 27 + > .../Acpi/X64/AcpiMadtLibX64/MadtGenerator.c | 375 +++++++++ > 19 files changed, 2477 insertions(+), 2 deletions(-) > create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h > create mode 100644 DynamicTablesPkg/Include/X64NameSpaceObjects.h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/Arm/FadtUp= date.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate= .h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUp= date.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSs= dtHpetLib.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/SsdtHp= etGenerator.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/WsmtGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/Acp= iMadtLibX64.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/Mad= tGenerator.c >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118528): https://edk2.groups.io/g/devel/message/118528 Mute This Topic: https://groups.io/mt/105796049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-