From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.101.1605312423291873329 for ; Fri, 13 Nov 2020 16:07:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UaBBpge4; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605312422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FKQjDIu1HMJPj7z8q/D4uyR24G4PJRyGij17FTnrrRw=; b=UaBBpge4VlBD6g36vqqZgI3MTrJOGUq8Gdn6dOuIE4YcMynIOhqDx2S3ELiri0t8HDH/cs iBLqQTRsDSo5jAktdz5Si6H6PmHZgNbDfrTKF1ZnMgR3XtawHPOBl6KAeaUG6eFf+Lj9pR oeUinr6hk/Xhwis35IXIfMOSREB96v4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-573-kzjX84vCOHy4J1F7isQbng-1; Fri, 13 Nov 2020 19:07:00 -0500 X-MC-Unique: kzjX84vCOHy4J1F7isQbng-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78551184C5E5; Sat, 14 Nov 2020 00:06:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-113.ams2.redhat.com [10.36.112.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 882245C70C; Sat, 14 Nov 2020 00:06:58 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V4 10/13] OvmfPkg/OvmfXen.dsc: Enable MD5 while enable iSCSI To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Ard Biesheuvel , Leif Lindholm References: <20201112055558.2348-1-zhichao.gao@intel.com> <20201112055558.2348-11-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: <7846c4b9-a9f2-1aad-d739-3715fda9f1e8@redhat.com> Date: Sat, 14 Nov 2020 01:06:57 +0100 MIME-Version: 1.0 In-Reply-To: <20201112055558.2348-11-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/12/20 06:55, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 > > There is a plan to make MD5 disable as default. > The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES > would be introduced to enable MD5. Make the > definition ahead of the change to avoid build > error after the MACRO changed. > > Enable iSCSI. > > Signed-off-by: Zhichao Gao > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > --- > OvmfPkg/OvmfXen.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 34c9de19df..83e1e9bbfd 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -38,6 +38,7 @@ > DEFINE NETWORK_IP6_ENABLE = FALSE > DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > + DEFINE NETWORK_ISCSI_ENABLE = TRUE > > !include NetworkPkg/NetworkDefines.dsc.inc > > @@ -80,6 +81,8 @@ > INTEL:*_*_*_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES > GCC:*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > +!include NetworkPkg/NetworkBuildOptions.dsc.inc > + > [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > XCODE:*_*_*_DLINK_FLAGS = -seg1addr 0x1000 -segalign 0x1000 > Reviewed-by: Laszlo Ersek Build-tested-by: Laszlo Ersek