Re: [edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator

["PierreGondois" <pierre.gondois@arm.com>]

(follow-up)

On 3/11/24 15:16, Pierre Gondois wrote:
> Hello Abdul,
> 
> On 3/4/24 16:43, Abdul Lateef Attar wrote:
>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>>
>> Adds generic ACPI SSDT HPET table generator library.
>> Register/Deregister HPET table.
>> Adds ACPI namespace object for HPET device.
>> Adds Address space for HPET device.
>>
>> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>`
>> ---
>>    DynamicTablesPkg/DynamicTables.dsc.inc        |   2 +
>>    DynamicTablesPkg/Include/AcpiTableGenerator.h |   2 +
>>    .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf  |  36 +++
>>    .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c  | 266 ++++++++++++++++++
>>    4 files changed, 306 insertions(+)
>>    create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf
>>    create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c
>>
>> diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/DynamicTables.dsc.inc
>> index 477dc6b6a9..fc2ac5962e 100644
>> --- a/DynamicTablesPkg/DynamicTables.dsc.inc
>> +++ b/DynamicTablesPkg/DynamicTables.dsc.inc
>> @@ -36,6 +36,7 @@
>>      DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf
>>      DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf
>>      DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf
>> +  DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf
> 
> (note for later):
> The HPET table seems to be intel specific actually,
and the WSMT is generic. So the tables might be built depending
on the ARCH.

Tables common to all ARCHs should be part of all the different
   DynamicTableFactoryDxe.inf
drivers, and ARCH specificat tables should not be in the
   [Components.common]
section. Sorry for not realizing the HPET table was not common
to all ARCHs earlier.


This section will change after the Arm/Arch common namespace update
and will have to be rebased. So I assume it can be left as is for now.

[snip]


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116635): https://edk2.groups.io/g/devel/message/116635
Mute This Topic: https://groups.io/mt/104724534/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-