From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E9D47803DE for ; Mon, 11 Mar 2024 14:22:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=klnWIuJCHacSt/FgjR2Km29SrNGkxYJsft5M+OUV994=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710166934; v=1; b=xtspoAb6cwaIR9CM16lv+BoOkxQoShIi34wGc9VVsQ0J/nFHPee5GPxu5wqXpx+RUO++GFfC bIvZb20WHpTWOtTJE7qtN4X4gbg/VUE2tYGy4SWRaWJfepQp4xhqJJDFRTMWwW+pYtAVmtz/Vn4 /TXqZ1tImyxgueCkw2Q2ogcU85dN0OJ9+KW2oVkMMsWkRERyzxOh/ygGqYQYQ4rkNjIHDOcv4D4 PBFwjff5E6CjOW/LGXPiYLOLzAEDXAYcDzYePPvS6YkW7Kh+cyOsB6bMbog9+ExqWQz8yygfD2P ZeUNYU89K6whwWdm46eob5+LjtVDHwMO2FattjadkJlng== X-Received: by 127.0.0.2 with SMTP id RHjZYY7687511x5eGHyNvIld; Mon, 11 Mar 2024 07:22:14 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.63986.1710166933518686063 for ; Mon, 11 Mar 2024 07:22:13 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8974FEC; Mon, 11 Mar 2024 07:22:49 -0700 (PDT) X-Received: from [10.34.100.133] (e126645.nice.arm.com [10.34.100.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53A8F3F762; Mon, 11 Mar 2024 07:22:12 -0700 (PDT) Message-ID: <78622704-e311-43ee-9f0e-e67dfd033710@arm.com> Date: Mon, 11 Mar 2024 07:22:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator From: "PierreGondois" To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Sami Mujawar References: <514bf3127bf6d19396d323dda1d67672095a7b18.1709566848.git.AbdulLateef.Attar@amd.com> <405fb4ba-bfde-41a2-9f79-078d5c895d78@arm.com> In-Reply-To: <405fb4ba-bfde-41a2-9f79-078d5c895d78@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OWtV0FVupOusupAyWKwC06CSx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=xtspoAb6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io (follow-up) On 3/11/24 15:16, Pierre Gondois wrote: > Hello Abdul, >=20 > On 3/4/24 16:43, Abdul Lateef Attar wrote: >> From: Abdul Lateef Attar >> >> Adds generic ACPI SSDT HPET table generator library. >> Register/Deregister HPET table. >> Adds ACPI namespace object for HPET device. >> Adds Address space for HPET device. >> >> Cc: Sami Mujawar >> Cc: Pierre Gondois >> Signed-off-by: Abdul Lateef Attar ` >> --- >> DynamicTablesPkg/DynamicTables.dsc.inc | 2 + >> DynamicTablesPkg/Include/AcpiTableGenerator.h | 2 + >> .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf | 36 +++ >> .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c | 266 +++++++++++++++++= + >> 4 files changed, 306 insertions(+) >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/Acpi= SsdtHpetLib.inf >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/Ssdt= HpetGenerator.c >> >> diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/D= ynamicTables.dsc.inc >> index 477dc6b6a9..fc2ac5962e 100644 >> --- a/DynamicTablesPkg/DynamicTables.dsc.inc >> +++ b/DynamicTablesPkg/DynamicTables.dsc.inc >> @@ -36,6 +36,7 @@ >> DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf >> DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf >> DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf >> + DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf >=20 > (note for later): > The HPET table seems to be intel specific actually, and the WSMT is generic. So the tables might be built depending on the ARCH. Tables common to all ARCHs should be part of all the different DynamicTableFactoryDxe.inf drivers, and ARCH specificat tables should not be in the [Components.common] section. Sorry for not realizing the HPET table was not common to all ARCHs earlier. This section will change after the Arm/Arch common namespace update and will have to be rebased. So I assume it can be left as is for now. [snip] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116635): https://edk2.groups.io/g/devel/message/116635 Mute This Topic: https://groups.io/mt/104724534/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-