From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web12.7111.1649169113668185436 for ; Tue, 05 Apr 2022 07:31:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=C6xwoJqX; spf=pass (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649169113; x=1680705113; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=o4wyfiz5XtcUh7IiAouBtAjjHcirUrRjSi4YhYPUaVI=; b=C6xwoJqXckrtnx1rBdBLbhfl3lr884pCePsVN7Tr4LdseISr6OXuSUDa 1IwveIdDIdF6+3i/LfO6oB+QmBc+6z4sv4LTCESRoFtMV9xHtCsE31fag qaK3DbGeXBgslUfWlMqWgpiY2NsMLlVipxy0ovnleEGFjm98FXnV7JD4o A=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 05 Apr 2022 07:31:53 -0700 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 07:31:37 -0700 Received: from [10.110.39.192] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 5 Apr 2022 07:31:36 -0700 Message-ID: <788b70e7-3d38-dbd1-35a9-39eab17ac0fd@quicinc.com> Date: Tue, 5 Apr 2022 08:31:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default To: Michael Kubacki , CC: Michael D Kinney , Liming Gao , Sean Brogan , Bret Barkelew References: <20220210161927.1847-1-mikuback@linux.microsoft.com> <7ab3cb92-85e1-c8ec-fc4e-20ae84a65c2f@quicinc.com> From: "Rebecca Cran" In-Reply-To: Return-Path: quic_rcran@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit So your change in 56530dec1105f17455752675e4c90fb859c64836 didn't fix anything, because we don't output TestSuites.xml to the console: if I introduce a code style issue into a branch, CI still only prints the following: PROGRESS - --Running ArmPkg: Uncrustify Coding Standard Test NO-TARGET -- WARNING - A file header template is not specified in the config file. WARNING - A function header template is not specified in the config file. ERROR - /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET returned 1 ERROR - Overall Build Status: Error PROGRESS - There were 1 failures out of 13 attempts Could we get the diff printed *there* too? -- Rebecca Cran On 2/25/22 14:18, Michael Kubacki wrote: > Hi Rebecca, > > Sorry for the delay, I was out of office. > > The diff will appear in /Build/TestSuites.xml. Here, I have > intentionally introduced an error in > UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c: > >  Uncrustify executed against 21 files in UnitTestFrameworkPkg in 0.19 > seconds. >  Files with formatting errors: >  Formatting errors in > Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c >  --- > D:\src\edk2\UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c >  +++ > D:\src\edk2\UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c.uncrustify_plugin >  @@ -13,7 +13,7 @@ >  #include <Library/UnitTestLib.h> >  #include <Library/PrintLib.h> > >  -#define UNIT_TEST_NAME        "Sample Unit Test" >  +#define UNIT_TEST_NAME     "Sample Unit Test" >  #define UNIT_TEST_VERSION  "0.1" > >  /// > >   > > Thanks, > Michael > > On 2/23/2022 12:48 PM, Rebecca Cran wrote: >> This doesn't appear to work. If I change >> MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c to introduce an >> error, then I get the following output (with verbose mode): >> >> >> INFO - ------------------------------------------------ >> INFO - --------------Cmd Output Finished--------------- >> INFO - --------- Running Time (mm:ss): 00:07 ---------- >> INFO - ----------- Return Code: 0x00000000 ------------ >> INFO - ------------------------------------------------ >> INFO - Uncrustify executed against 1035 files in MdeModulePkg in 7.67 >> seconds. >> >> INFO - Calculating file diffs. This might take a while... >> ERROR - .../edk2/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c >> ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET >> returned 1 >> PROGRESS - --Running MdeModulePkg: Spell Check Test NO-TARGET -- >> >> So it's seeing that _output_file_diffs is True, but it appears that >> there aren't any formatted_files? >> >>