From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 22 Jul 2019 15:30:21 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D832308429D; Mon, 22 Jul 2019 22:30:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-23.ams2.redhat.com [10.36.117.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 42FC560852; Mon, 22 Jul 2019 22:30:19 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Jian Wang , Leif Lindholm , Ting Ye Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20190719164319.9070-1-lersek@redhat.com> Message-ID: <789255e1-c28a-299f-e056-8cba8e4a8834@redhat.com> Date: Tue, 23 Jul 2019 00:30:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190719164319.9070-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 22 Jul 2019 22:30:20 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/19/19 18:43, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: internal_hdrs > > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF > file", 2019-06-10) logs some (non-fatal) warnings about unlisted > internal header files. List those files explicitly. > > Note: header files are added in lexicographical order only if the > underlying INF file already keeps the [Sources] and [LibraryClasses] > sections in lexicographical order. Otherwise, header files are added in > rough "logical" order. > > The set of INF files to update was determined as follows: > > - build the OVMF and ArmVirt platforms > > - collect all the warnings > > - exclude all warnings that refer to "CryptoPkg/Library/OpensslLib" > (parts of those INF files are generated, so it's likely that the > generator should be updated -- but that's for someone else) > > - for each remaining INF file, check if there are *other* INF files in > the same directory (possibly unused by OVMF and ArmVirt platforms) > > - fix up each collected INF file as needed (check if at least one C file > listed in [Sources] actually includes the reported header) > > The series was validated as follows: > > - build the OVMF and ArmVirt platforms > > - rebuild each modified INF with the "-m" switch, via its own package > platform DSC (not via OVMF / ArmVirt) > > - wherever [Sources] is split between arches, rebuild the INF for all > relevant arches > > - ascertain the warnings are gone > > Cc: Ard Biesheuvel > Cc: Jian Wang > Cc: Leif Lindholm > Cc: Ting Ye > > Thanks > Laszlo > > Laszlo Ersek (4): > ArmPkg: list module-internal header files in INF [Sources] > ArmPlatformPkg: list module-internal header files in INF [Sources] > CryptoPkg/BaseCryptLib: list module-internal header files in INF > [Sources] > EmbeddedPkg: list module-internal header files in INF [Sources] > > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 1 + > ArmPkg/Library/ArmLib/ArmBaseLib.inf | 3 +++ > ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf | 1 + > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf | 1 + > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 1 + > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 1 + > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 + > EmbeddedPkg/Library/FdtLib/FdtLib.inf | 1 + > EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 1 + > 12 files changed, 14 insertions(+) > Pushed: bb824f685d76..f6f1e0b7c292. Thanks! Laszlo