public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Hiber He" <hiberhe@163.com>
To: devel <devel@edk2.groups.io>, "leif.lindholm" <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed
Date: Fri, 5 Jul 2019 19:26:24 +0800 (GMT+08:00)	[thread overview]
Message-ID: <78ad489c.74f6.16bc1e2a34f.Coremail.hiberhe@163.com> (raw)
In-Reply-To: <20190705103426.1423-1-leif.lindholm@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

Hi,


    I think the license of FCE is not correct(Should be BSD-2-Clause-Patent). And the logic for ARCH("ifndef ARCH") can be deleted.


   I deleted the ARCH related lines and it did built. 


Best Regards,
Hiber


      


On 07/05/2019 18:34, Leif Lindholm wrote:
Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool
that is always built. Pre-existing tools locate the makefile includes
with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency
on having sourced edksetup.sh before building BaseTools.

Change FCE GNUmakefile to match other tools.

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---

This broke our CI setup, so I'd appreciate if it could be merged quickly.

BaseTools/Source/C/FCE/GNUmakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GNUmakefile
index 3e1b6a85e2..7a7e1ef4b8 100644
--- a/BaseTools/Source/C/FCE/GNUmakefile
+++ b/BaseTools/Source/C/FCE/GNUmakefile
@@ -42,7 +42,7 @@ endif
export ARCH
export HOST_ARCH=$(ARCH)

-MAKEROOT ?= $(EDK_TOOLS_PATH)/Source/C
+MAKEROOT ?= ..

APPNAME = FCE

--
2.11.0




[-- Attachment #2: Type: text/html, Size: 2446 bytes --]

  reply	other threads:[~2019-07-05 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 10:34 [PATCH] BaseTools: fix FCE build when edksetup not executed Leif Lindholm
2019-07-05 11:26 ` Hiber He [this message]
2019-07-05 13:41   ` [edk2-devel] " Liming Gao
2019-07-05 14:01     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ad489c.74f6.16bc1e2a34f.Coremail.hiberhe@163.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox