From: "Rebecca Cran" <rebecca@bsdio.com>
To: Yuwei Chen <yuwei.chen@intel.com>, devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>, Bob Feng <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
Date: Wed, 20 Dec 2023 15:12:28 -0700 [thread overview]
Message-ID: <78af5d24-310c-49b1-b2dd-edca25e946cb@bsdio.com> (raw)
In-Reply-To: <20231215091151.62-1-yuwei.chen@intel.com>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
On 12/15/2023 2:11 AM, Yuwei Chen wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
>
> Currently, Python FMMT tool does not support automatically
> select FMMTConf.ini file which saves GuidTool settings.
> This patch supports this features.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> index a25681709b..f6bdeffa50 100644
> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> @@ -110,7 +110,7 @@ class GUIDTools:
> if os.environ['FmmtConfPath']:
>
> self.tooldef_file = os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini')
>
> else:
>
> - PathList = os.environ['PATH']
>
> + PathList = os.environ['PATH'].split(os.pathsep)
>
> for CurrentPath in PathList:
>
> if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
>
> self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112771): https://edk2.groups.io/g/devel/message/112771
Mute This Topic: https://groups.io/mt/103187642/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-20 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 9:11 [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling Yuwei Chen
2023-12-19 7:31 ` Guo, Gua
2023-12-19 13:02 ` 回复: " gaoliming via groups.io
2023-12-20 22:17 ` Rebecca Cran
2023-12-20 22:12 ` Rebecca Cran [this message]
[not found] <17A0F657EB4E520F.5876@groups.io>
2023-12-15 9:13 ` Yuwei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78af5d24-310c-49b1-b2dd-edca25e946cb@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox