From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A172C740035 for ; Thu, 16 May 2024 15:17:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ye1Q9pusXrMB7bbwkCoMYa2p0ey6usYdt/7scu9mv44=; c=relaxed/simple; d=groups.io; h=Received-SPF:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715872673; v=1; b=k7ZC+Ht0tkZd1RMVoPZ7yiFWGCKtSDJJM96dxRaw3Bv3xKMemzzhcFkP6ULuIZGpRw6a+B1v KwkXQ36yNtMknttchs9c+LaYMRm+3GLtY8ucbCmasFxQBZQ9sZoOXNOoO9xMWfbBjrhUyiulQgu iiNNSx3llRsl8yz0h8MY4b0BaY6pJZIgcFZu5GdLD3Jp36mJwyWSs1Udphg/6LXV7ywgGV1iymX th45h4eLOqMHppYs1C1DiubHgft3vNnzrIwA8RoHqWGjGwcfW2d52JoD5pTPy/7og8Q06+ZZwfd S1uQ1T0i9Cq9lLCjL5PIowOz6jhfQJ9RDfJJ2QGGmFMaQ== X-Received: by 127.0.0.2 with SMTP id OcIZYY7687511x7UqQqxfxCu; Thu, 16 May 2024 08:17:53 -0700 X-Received: from EUR02-DB5-obe.outbound.protection.outlook.com (EUR02-DB5-obe.outbound.protection.outlook.com [40.107.249.75]) by mx.groups.io with SMTP id smtpd.web10.16688.1715872671837752970 for ; Thu, 16 May 2024 08:17:52 -0700 X-Received: from AS4P251CA0012.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d2::13) by AM8PR08MB5588.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28; Thu, 16 May 2024 15:17:48 +0000 X-Received: from AM3PEPF0000A78E.eurprd04.prod.outlook.com (2603:10a6:20b:5d2:cafe::e2) by AS4P251CA0012.outlook.office365.com (2603:10a6:20b:5d2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28 via Frontend Transport; Thu, 16 May 2024 15:17:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF0000A78E.mail.protection.outlook.com (10.167.16.117) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7587.21 via Frontend Transport; Thu, 16 May 2024 15:17:48 +0000 X-Received: ("Tessian outbound 9d9bf1c5d85a:v315"); Thu, 16 May 2024 15:17:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: af810fa5ecaf72e6 X-CR-MTA-TID: 64aa7808 X-Received: from b789f6856b5c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F060B64E-8401-4CAD-8D3E-9652475BB6D0.1; Thu, 16 May 2024 15:17:37 +0000 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b789f6856b5c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 May 2024 15:17:37 +0000 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBBPR08MB10604.eurprd08.prod.outlook.com (2603:10a6:10:536::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.27; Thu, 16 May 2024 15:17:33 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c%5]) with mapi id 15.20.7587.028; Thu, 16 May 2024 15:17:33 +0000 Message-ID: <78bb6bba-2b3b-4d74-96f3-87b1c80206e4@arm.com> Date: Thu, 16 May 2024 16:17:32 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 02/14] Platform/ARM/NorFlashDxe: Move NorFlashVirtualNotifyEvent To: Sahil Kaushal , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , sahil , "nd@arm.com" References: <20240423055638.1271531-1-Sahil.Kaushal@arm.com> <20240423055638.1271531-3-Sahil.Kaushal@arm.com> From: "Sami Mujawar" In-Reply-To: <20240423055638.1271531-3-Sahil.Kaushal@arm.com> X-ClientProxiedBy: LO2P265CA0360.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::36) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DBBPR08MB10604:EE_|AM3PEPF0000A78E:EE_|AM8PR08MB5588:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dfc1e33-c4b1-4339-25bc-08dc75bb58a1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?Y2xZRllpODFXRU9OTExWclo1SUlXSkpheHE4NkZzUW4zUjVxMk9UR0NvSk9i?= =?utf-8?B?cDRQRTU5Snc4VDRLQTVUL0VrY2pOSHJ6UVd0QVlHdXUyZjVMZWRzcktrRTU5?= =?utf-8?B?bVBnNzdsb0U0cFkvZjg5Y2ZKUjJNd29YQXduNXZRK0czT0lzZk1QVHlhcDZF?= =?utf-8?B?NmFCQjlRSlNCajU5SmFyYlpOV3N5VTR6Z2VjZkRxNDVrQjNibVVKN1ZZSlNZ?= =?utf-8?B?UjhtSnIzZ3I2cFE1d3RYdXcvZC9Qb25kdHhUc2Zyd0V3Q0duM1FnQnZMQUhF?= =?utf-8?B?V1hGOTJ3bllCUW0rRUpPbVo5S2E2ZnFrVDhUd3VQM0lLeFV5WU15TDF2M3F5?= =?utf-8?B?L0hLQmhXNzlqT0F5WitjM214Zlk5K1VvYTZPeVQzSi9wYTNMY2c0RVlmeVZy?= =?utf-8?B?akdFSThjSzZGSnRGaTUvY0pDS1hmbS9SRTNLMHJqREJ2Sk91Q2hoaTJiSEh4?= =?utf-8?B?NFB6SHl0d0JpZVZDbVFobzN3S1F3bU8yb3ZrY2hYd3ZXZDNmbzloMHRiV0Er?= =?utf-8?B?MjRvcUhuZXVWbkRmZTdhN00yNGJmam4vN0dZZGx0VzU5NWZOeUV1cjRRTUJJ?= =?utf-8?B?SEdrZU41SExma2phWDMzaFdIMHdQV2gvRGJta3g2QzJTZTZXQUdGS1ArSDdL?= =?utf-8?B?YXJCdTlIZmdHS1VZekVORExRNVdVcVdIYmdBMjhSMlpKMUtqU0hrdlpERGhF?= =?utf-8?B?TDFUcnhjb1MzOE1LYTdhOUEwWXAwditlOEwvb0laTFNVdTYzaVFCc1NCV3Rr?= =?utf-8?B?cGR5VmJLUnFiVG9hYnd4cUhvS292STBZaHUrSzllWkVnK1dtbndHZlNyS2hw?= =?utf-8?B?ejFmbk5NcCswWGtBV0E5QXpiRTQvaENyM1VwV2ZzdkloditiZHNvdEUxOEpp?= =?utf-8?B?RFJKV3NGMHBVWU9PdEtKNFk5d2FXcjQ4Sm4xQ1g1SXIzVVlRWTdnWjlyK000?= =?utf-8?B?TnFZd2h3Vk9WYXZWdGVNd3psZWd4c0RNSmx1enBVMkxIRy9GMi9NQ3E2N0tS?= =?utf-8?B?a1ZqRFBOektrTlRoM2V0ekdrUENqVjlaNFBjK1BmdEJJTXJOc1hBanRVellq?= =?utf-8?B?R3VaRVFMK0paS1dLZVlqVXZWdGZKQ2lxdGdxYjExZUdVdnRBdjkyQ1RGc1VD?= =?utf-8?B?Sm8wYVRTcGRmUXcvbDZkQkxNYUpJalBFZW5ENktOQldsMUhNb3Z1S0MyeHVh?= =?utf-8?B?QmVCOUl4aXZKazlzQUxBNVN5WG1TZHhya1VTVStGdFB4MS9nbW9qTHhUMDk2?= =?utf-8?B?a3JDZTVta2NuSXQrTGp5clJRZmJlNWtTZHpXdXd2M1hrSUE1TEh1L3djazhQ?= =?utf-8?B?eUh0K2lLY1IrR3Q3d0wxMU90VVRlbENVTC9vWDRQTjZCYUhqeG1WcXBMbWdC?= =?utf-8?B?dUt1MXRLenVINEsyYk4wdklIdFNWaENsMDdkVzJaT0s4eCs2SzlwZ0F1SWQx?= =?utf-8?B?Ym5hSmdHbUI1TGJydjdzaEVneU5FQ0ZvenJPeGNNakNENDdhS0tZSTIyRXRS?= =?utf-8?B?Umthc3ZTNStHSTl6c1Jmbk1hakoxRS9qZjY2OFhmQWtFZlIwU3J6OUZYamlv?= =?utf-8?B?aE9IVk5GNGxjOVRxZlV2dSsxclh4QmU4Vzh4OUJaVVNZTDdKR2drblYzWVVv?= =?utf-8?B?UGw2QVR6N1N0YU9mcldzUHV5MXpmREdwbUF4aFBJVlBkMUZPNnBUaWU1OGR6?= =?utf-8?B?YUpmdXVoditreFdpbUpSVVlEbUZKQlVaWFY0bGMwLzJBZ1JPS2RBY2d3PT0=?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10604 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF0000A78E.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 18f6ccc2-0798-447e-3256-08dc75bb4f8a X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q0Rwdi9kZVV5Zk1pbWsvZ2Y4NGZsdnllVHJTeGovT1l3d3JxSmJzd2MwSWE0?= =?utf-8?B?d3RzSkpWQ3JkRjVmbitqUzFPVldEUC96OUtKOXAzdlRDZm1YWXZPNnkzbEhT?= =?utf-8?B?UmNOczBtWGVvSStWK3luenRsSTJKOVdSUDR4YmJjN29XazlCWncxSVVIaGJw?= =?utf-8?B?WE9JTUxWVkNSVGhGWWdaajlNdUxFbHBuWTJ6dzVQR2VndVhnaU9YZDFBZTFk?= =?utf-8?B?Rmh5NTQ3OVZwQU8rVWlwMStqZ2ZqaFcvcVBMaCtQVHE5Mkg4ZEU3N1ZVWXBK?= =?utf-8?B?cVgyN3FTMWRFRG9aR1IrZUJ1MFR1QVhjd1pHS1hGUUJUUGRGbWJtcXVTaTBR?= =?utf-8?B?cEVtZEpOZldaeHJFdWZoRTlxeDJDczRUTVMzYVZIQ2IrUVlKZDUxMmFWNytO?= =?utf-8?B?enEzSzlDbHcvdll5dVFlenF6RHFaN1B0UlRRbUFhUDFkd2dtaWpuaDd6VklX?= =?utf-8?B?T0xQeEtnSVoyNWZ5ZmxrR1lMZ0dDalBEWUk3bEJmZ1lETHRQMFByOE5HK0tG?= =?utf-8?B?dWo2UjRrd2VGN3JsWC9oM3RGcG1YQWhydFhtUG4zRmppOURjMTRHVGhYMjdP?= =?utf-8?B?YzlseU9FTjF2NktDQU5yNld1d294RkIvZlhtNi9CUjFGaENKR0JQOWVzNC9k?= =?utf-8?B?blozcHJJSGdXRFBLTlBMd3VDQmhISjFyaU9WNzEyWHFZdlhGL29GdXplRjlD?= =?utf-8?B?akErK3FwY0lIWTR2TFRBVnhXeElyZmdxQjhzZDhsWGtnQjI3bkJGQm0rMlla?= =?utf-8?B?U1dIMDhIL1IvQmNvZHR4RTV0dVF5VE9GTFNwZkpKdFcxdWY1QTZ5NXJhOFgy?= =?utf-8?B?RWRIMmpHWXlERjhRVDZNZzBSYU10Sk5MMEVDWDdBNGcxRnV3b0U0OVdCSC9Q?= =?utf-8?B?OW5qU1lyeFFjU05DZm0rbW9ycWlDdnhUaVloYTJiMlgramJOYmUxbXhEMFRx?= =?utf-8?B?TzM4NTJtNlhyTFhCaXE2bFEwWGJBYnZTTmE5cElIMmxqenFBczVEbnNERlhG?= =?utf-8?B?R3FFVkpVN2YyTVFkTk52MHg5VnltUUNhV3FGeHpOOWIvOHdTZ1N0UjdGTE1m?= =?utf-8?B?Y3RxSnlpYWZ3MXFHdHlIKzUrZktHSHBwOHpJcWtNdE9Ud3g1bGdYUCtiUGxO?= =?utf-8?B?c0pHaStEVk43RkpQWWRSNTJXTW5PQktraThoc3ZZWWdVTkpySDZ1LzE4dXRk?= =?utf-8?B?T1RqanlEYVNsdkhLb2JJUHAwbUJtRHVzWGdkTFlvV2ZmY3hiTCtuaWVDWWM3?= =?utf-8?B?cFBBRFRXQm9wVmJ6dzZ5QUJCaWRKb1FSZmdVQ0lzL3FMN3F5K0RhOUJBeXAz?= =?utf-8?B?SngwSE1FV1FnUG14UUpJY1NrbVpzYUs0Z09CWnhURHNWVEtoWDBOK3pTM2Yw?= =?utf-8?B?RGh1N3JnNitWd2xNanV6eElnbHh3Mlk3QWprVHdkSG5nWWRlWVovQjgzSmhq?= =?utf-8?B?R2syR0Z0N0RwRWgvU2FpSER3Vi94ZGJPK2c3aHhyUm9WSzZOK0tLZFdEVW54?= =?utf-8?B?d05DOGJCMHVMQ1prTlQwOWxpb2c5ODFQcVkxb1U5Rm1vcWQydGJ6eGRpbjRh?= =?utf-8?B?VVBNNFJWRlhzWE5TMzdEZ2xKbU1hN0IwakM1UUoyMU5BcWZOTzBXMVQ0V29r?= =?utf-8?B?ekpqMWlrRjdMcndqTWYvUERTNWI2cjljNDUxZTdjNE85RTZSVXpGWm9PNko5?= =?utf-8?B?YUNuUzZKdnQ1OXNoVnhmU3VJQUpNVCtiVEhqZGdPTUJWRGQ5YlVsbnNWaXFq?= =?utf-8?B?bEZxWnJwaFUzcUN3WWd0Y3YyMktqUHZ5NjlycjZPVENmTUkxbTd4OGswR3Vk?= =?utf-8?B?Qm5iNmZiK01GSExGZXdZNCtpOFJhMm1XYko3b2JQSUlxby9aalliQ0tuTkJo?= =?utf-8?Q?GKZ2y6nvIp5BM?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 15:17:48.5276 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6dfc1e33-c4b1-4339-25bc-08dc75bb58a1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A78E.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5588 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 16 May 2024 08:17:52 -0700 Resent-From: sami.mujawar@arm.com Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bxmAhQr1fJgqcrxW2KUbxT5rx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=k7ZC+Ht0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: > From: sahil > > Moving this function from NorFlash.c to NorFlashDxe.c as it is not > dependent on any particular flash implementation. > > Signed-off-by: sahil > --- > Platform/ARM/Drivers/NorFlashDxe/NorFlash.h | 14 +++---- > Platform/ARM/Drivers/NorFlashDxe/NorFlash.c | 44 -------------------= - > Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.c | 44 +++++++++++++++++++= + > 3 files changed, 51 insertions(+), 51 deletions(-) > > diff --git a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.h b/Platform/ARM/D= rivers/NorFlashDxe/NorFlash.h > index c83032e87d9c..d4d97bd22cc5 100644 > --- a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.h > +++ b/Platform/ARM/Drivers/NorFlashDxe/NorFlash.h > @@ -342,6 +342,13 @@ NorFlashFvbInitialize ( > IN NOR_FLASH_INSTANCE *Instance > > ); > > =20 > > +VOID > > +EFIAPI > > +NorFlashVirtualNotifyEvent ( > > + IN EFI_EVENT Event, > > + IN VOID *Context > > + ); > > + > > // > > // NorFlash.c > > // > > @@ -412,11 +419,4 @@ NorFlashWriteSingleWord ( > IN UINT32 WriteData > > ); > > =20 > > -VOID > > -EFIAPI > > -NorFlashVirtualNotifyEvent ( > > - IN EFI_EVENT Event, > > - IN VOID *Context > > - ); > > - > > #endif /* __NOR_FLASH_H__ */ > > diff --git a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.c b/Platform/ARM/D= rivers/NorFlashDxe/NorFlash.c > index 60854ef2a7d0..55f6abd0eef3 100644 > --- a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.c > +++ b/Platform/ARM/Drivers/NorFlashDxe/NorFlash.c > @@ -816,47 +816,3 @@ NorFlashReset ( > SEND_NOR_COMMAND (Instance->DeviceBaseAddress, 0, P30_CMD_READ_ARRAY)= ; > > return EFI_SUCCESS; > > } > > - > > -/** > > - Fixup internal data so that EFI can be call in virtual mode. > > - Call the passed in Child Notify event and convert any pointers in > > - lib to virtual mode. > > - > > - @param[in] Event The Event that is being processed > > - @param[in] Context Event Context > > -**/ > > -VOID > > -EFIAPI > > -NorFlashVirtualNotifyEvent ( > > - IN EFI_EVENT Event, > > - IN VOID *Context > > - ) > > -{ > > - UINTN Index; > > - > > - for (Index =3D 0; Index < mNorFlashDeviceCount; Index++) { > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->DeviceB= aseAddress); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->RegionB= aseAddress); > > - > > - // Convert BlockIo protocol > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.FlushBlocks); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.ReadBlocks); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.Reset); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.WriteBlocks); > > - > > - // Convert Fvb > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.EraseBlocks); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.GetAttributes); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.GetBlockSize); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.GetPhysicalAddress); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.Read); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.SetAttributes); > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.Write); > > - > > - if (mNorFlashInstances[Index]->ShadowBuffer !=3D NULL) { > > - EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->Shado= wBuffer); > > - } > > - } > > - > > - return; > > -} > > diff --git a/Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.c b/Platform/AR= M/Drivers/NorFlashDxe/NorFlashDxe.c > index f7b92de21a57..963af7dcf435 100644 > --- a/Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.c > +++ b/Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.c > @@ -504,3 +504,47 @@ NorFlashFvbInitialize ( > =20 > > return Status; > > } > > + > > +/** > > + Fixup internal data so that EFI can be call in virtual mode. > > + Call the passed in Child Notify event and convert any pointers in > > + lib to virtual mode. > > + > > + @param[in] Event The Event that is being processed > > + @param[in] Context Event Context > > +**/ > > +VOID > > +EFIAPI > > +NorFlashVirtualNotifyEvent ( > > + IN EFI_EVENT Event, > > + IN VOID *Context > > + ) > > +{ > > + UINTN Index; > > + > > + for (Index =3D 0; Index < mNorFlashDeviceCount; Index++) { > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->DeviceB= aseAddress); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->RegionB= aseAddress); > > + > > + // Convert BlockIo protocol > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.FlushBlocks); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.ReadBlocks); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.Reset); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->BlockIo= Protocol.WriteBlocks); > > + > > + // Convert Fvb > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.EraseBlocks); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.GetAttributes); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.GetBlockSize); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.GetPhysicalAddress); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.Read); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.SetAttributes); > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->FvbProt= ocol.Write); > > + > > + if (mNorFlashInstances[Index]->ShadowBuffer !=3D NULL) { > > + EfiConvertPointer (0x0, (VOID **)&mNorFlashInstances[Index]->Shado= wBuffer); > > + } > > + } > > + > > + return; > > +} > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118958): https://edk2.groups.io/g/devel/message/118958 Mute This Topic: https://groups.io/mt/105690937/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-