From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.742.1664315112034730121 for ; Tue, 27 Sep 2022 14:45:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=RXnqJ1Ov; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28RLhK2p023442; Tue, 27 Sep 2022 21:44:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=4HgUjhZpFpA4lmqPfDDCsaR1ZAkg1P3GT/+y8M2eF3w=; b=RXnqJ1OvbPk5ghIBKMW9Xc/8t54xT8ypT1LnXlRS7d+W0d2O/m9HBqjrs8TptFEiMJ+U m3643g2TXOL+PZvXbliHBLM3SdSmubiXQjdYIjO06+F3AljE8StGwQKiQ8XBqPcThXJ/ zRRda6lTbNMdbcoim5P2fCUL8fl7VpbMtk/3r9GOMXdT8eH3nL6gYnn8P1ecwPPPvXNJ 95+3P6QfQS4TdyMX+r9OotBqcV+iCdbRxs9zfSV5vf/jmWVvu56FuRXPPOSB2y/SuOfV 0QkIiw+EnZ5yMLbRb9Tr/TjpycwZaUMqrcmgJU9O1KmwNtTo7P3F/gsbORLp18nJ21R7 6A== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jurq7annx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 21:44:59 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28RLiwL2010699 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 21:44:58 GMT Received: from [10.110.74.120] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 27 Sep 2022 14:44:57 -0700 Message-ID: <78c6ed70-bd7d-7a07-321b-b77de538e4d5@quicinc.com> Date: Tue, 27 Sep 2022 14:44:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [edk2-devel] [PATCH v5 09/21] MdePkg/BaseRngLib: Rename ArmReadIdIsar0() to ArmGetFeatRng() To: , CC: Sami Mujawar , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , "Jiewen Yao" , Jian J Wang References: <20220919192207.637786-1-Pierre.Gondois@arm.com> <20220919192207.637786-10-Pierre.Gondois@arm.com> From: "Rebecca Cran" In-Reply-To: <20220919192207.637786-10-Pierre.Gondois@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: -lLVOSvwefB3FW3kGoM-sh8jFl2wFWsm X-Proofpoint-GUID: -lLVOSvwefB3FW3kGoM-sh8jFl2wFWsm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_11,2022-09-27_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=707 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 clxscore=1015 spamscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209270132 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 9/19/2022 12:21 PM, PierreGondois wrote: > ;/** > @@ -19,11 +19,11 @@ > ;**/ > ;UINT64 > ;EFIAPI > -;ArmReadIdIsar0 ( > +;ArmGetFeatRng ( > ; VOID > ; ); > ; > -ArmReadIdIsar0 > +ArmGetFeatRng > mrs x0, id_aa64isar0_el1 // Read ID_AA64ISAR0 Register > ret > Should we be masking the register value here instead of in BaseRngLibConstructor, to make it more consistent with the new name? -- Rebecca Cran