From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web09.9503.1607531937878609589 for ; Wed, 09 Dec 2020 08:38:57 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=MkYYcQzR; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B9GVbiA050460; Wed, 9 Dec 2020 11:38:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=zhyuIJugUTUpimL7IGkIN+dA3q0H6j8C0kMnTOzzpGk=; b=MkYYcQzRh0G1dmDDabffrote7jAX8S1BhbYya+mNdAYr1ZUTE9sHLWESbjkROeI5zL/b PTgnGy9hwAf3H9S8Mt55UjfKcwLlz2v65BYYuH61at5HNujvqzhg1UrHdpOgW4RXQGA2 niQJ9n6cO8VVXNfhZXntTus01x0PqKrAZmJbDv0MLIRY5a9eiJs4cZpe5JREqpekVrEH +cmicdPxsiQtZ5k6KmSKPGGKLjA5GAZhCYJOmaFWqN/okoEIYrckXrrtuIvc71m+/+q1 zuDgo3LnqkijYvXh7AGABRpJ+aEv9H3OjZOSxeEL4z5JR8HN66XeSKY99Zq349ng0v/f qw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 35b14q2nge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Dec 2020 11:38:52 -0500 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0B9GWXP9058489; Wed, 9 Dec 2020 11:38:52 -0500 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 35b14q2nfq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Dec 2020 11:38:52 -0500 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0B9GWI1T023002; Wed, 9 Dec 2020 16:38:50 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma02wdc.us.ibm.com with ESMTP id 3581u9gwtb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Dec 2020 16:38:50 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0B9Gclpr14418180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Dec 2020 16:38:47 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E20E7805F; Wed, 9 Dec 2020 16:38:47 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2C1F78060; Wed, 9 Dec 2020 16:38:43 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.183.17]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 9 Dec 2020 16:38:43 +0000 (GMT) Message-ID: <78d5f9704e4a643d1c6d4669c2c5cae672cfaecf.camel@linux.ibm.com> Subject: Re: [edk2-devel] [PATCH v3 6/6] OvmfPkg/AmdSev: Expose the Sev Secret area using a configuration table From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: "Yao, Jiewen" , "devel@edk2.groups.io" Cc: "dovmurik@linux.vnet.ibm.com" , "Dov.Murik1@il.ibm.com" , "ashish.kalra@amd.com" , "brijesh.singh@amd.com" , "tobin@ibm.com" , "david.kaplan@amd.com" , "jon.grimm@amd.com" , "thomas.lendacky@amd.com" , "frankeh@us.ibm.com" , "Dr . David Alan Gilbert" , Laszlo Ersek , "Justen, Jordan L" , Ard Biesheuvel Date: Wed, 09 Dec 2020 08:38:42 -0800 In-Reply-To: References: <20201130202819.3910-1-jejb@linux.ibm.com> <20201130202819.3910-7-jejb@linux.ibm.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2020-12-09_13:2020-12-09,2020-12-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090112 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id 0B9GVbiA050460 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2020-12-09 at 16:33 +0000, Yao, Jiewen wrote: > Thanks. ConfidentialComputing seems a better name. >=20 > I agree with you that OVMF might not need understand the data > structure. But I am not sure if the grub is the only boot loader we > want to support. To be clear: grub is just using it to get the disk password. I do anticipate we'll also use it for provisioning keys directly into the linux kernel as well, so multiple consumers were anticipated. > I think it might be a better idea to define the data structure > clearly in OVMF. As such, any boot loader can parse the data > structure to decrypt the disk. They don=E2=80=99t need refer to grub. I'll defer to what OVMF people want, but defining a table inside OVMF that it doesn't actually use at all seems to be doing it at the wrong layer. James