From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B09FF2095DFF5 for ; Wed, 23 Aug 2017 16:01:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 910A5C04B31B; Wed, 23 Aug 2017 23:04:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 910A5C04B31B Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-43.phx2.redhat.com [10.3.116.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3781B68B39; Wed, 23 Aug 2017 23:04:22 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1503490967-5559-1-git-send-email-brijesh.singh@amd.com> <1503490967-5559-20-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <79036479-b9bb-25be-f11d-8a73f3d6a639@redhat.com> Date: Thu, 24 Aug 2017 01:04:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503490967-5559-20-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 23 Aug 2017 23:04:23 +0000 (UTC) Subject: Re: [PATCH v3 19/23] OvmfPkg/Virtio10: define VIRITO_F_IOMMU_PLATFORM feature bit X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 23:01:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit (1) The subject line contains a super-sneaky typo which I missed in my previous review: VIR-I-T-O vs. VIR-T-I-O. vv VIRITO_F_IOMMU_PLATFORM VIRTIO_F_IOMMU_PLATFORM ^^ The code is correct. With the subject fixed (which I plan to do): Reviewed-by: Laszlo Ersek Thanks Laszlo On 08/23/17 14:22, Brijesh Singh wrote: > This feature indicates that the device is behind an IOMMU that translates > bus addresses from the device into physical addresses in memory. If this > feature bit is set to 0, then the device emits physical addresses which > are not translated further, even though an IOMMU may be present. > see [1] for more infromation > > [1] https://lists.oasis-open.org/archives/virtio-dev/201610/msg00121.html > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Include/IndustryStandard/Virtio10.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/Include/IndustryStandard/Virtio10.h b/OvmfPkg/Include/IndustryStandard/Virtio10.h > index 4c9b62a3cf59..c5efb5cfcb8a 100644 > --- a/OvmfPkg/Include/IndustryStandard/Virtio10.h > +++ b/OvmfPkg/Include/IndustryStandard/Virtio10.h > @@ -2,6 +2,7 @@ > Definitions from the VirtIo 1.0 specification (csprd05). > > Copyright (C) 2016, Red Hat, Inc. > + Copyright (C) 2017, AMD, Inc. > > This program and the accompanying materials are licensed and made available > under the terms and conditions of the BSD License which accompanies this > @@ -81,6 +82,7 @@ typedef struct { > // > // VirtIo 1.0 reserved (device-independent) feature bits > // > -#define VIRTIO_F_VERSION_1 BIT32 > +#define VIRTIO_F_VERSION_1 BIT32 > +#define VIRTIO_F_IOMMU_PLATFORM BIT33 > > #endif // _VIRTIO_1_0_H_ >