From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.2245.1575407069872908141 for ; Tue, 03 Dec 2019 13:04:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CyBjSOiE; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575407068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EJ5GrimE4gxYZb0eapJMhTuyWQKzCto0rd51CEOhz1c=; b=CyBjSOiEH6BSJxpEuFeFUNV/kGox6gOvpzy77U8W1xv+SykJlJz9l/rbZRwjcuoZThmDN9 WY5DqSMuCepyV3huDuEjo8CXp75UOG7IxJyDL0qSf4gyYJLXdTeY++vvMDTkqv6T2U7yyR OrDaJxSFod8X0ALGd02vZAlXGxTRbC4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-329-fzEyM1Q-McCBJeeidwGJmg-1; Tue, 03 Dec 2019 16:04:27 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70D20477; Tue, 3 Dec 2019 21:04:26 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-183.ams2.redhat.com [10.36.117.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C16F600CC; Tue, 3 Dec 2019 21:04:22 +0000 (UTC) Subject: Re: [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos To: Philippe Mathieu-Daude , devel@edk2.groups.io Cc: Antoine Coeur , Eric Dong , Ray Ni References: <20191203161602.15969-1-philmd@redhat.com> <20191203161602.15969-79-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: <7919ad90-cd8c-5a96-3b0d-1757548653d7@redhat.com> Date: Tue, 3 Dec 2019 22:04:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191203161602.15969-79-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: fzEyM1Q-McCBJeeidwGJmg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 12/03/19 17:16, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++++++------ > UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c | 2 +- > UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 ++-- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 ++-- > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +++--- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +- > 9 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index daf977f654b4..7f5a0b2b267a 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -272,7 +272,7 @@ extern UINT8 mSmmSaveStateRegisterLma; > > @retval EFI_SUCCESS The register was read from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -296,7 +296,7 @@ SmmReadSaveState ( > > @retval EFI_SUCCESS The register was written from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor > - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct > + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct > > **/ > EFI_STATUS > @@ -324,7 +324,7 @@ This function supports reading a CPU Save State register in SMBase relocation ha > > @retval EFI_SUCCESS The register was read from Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. > -@retval EFI_INVALID_PARAMTER This or Buffer is NULL. > +@retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -351,7 +351,7 @@ This function supports writing a CPU Save State register in SMBase relocation ha > > @retval EFI_SUCCESS The register was written to Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. > -@retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct. > +@retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct. > > **/ > EFI_STATUS > @@ -1251,7 +1251,7 @@ EdkiiSmmGetMemoryAttributes ( > > /** > This function fixes up the address of the global variable or function > - referred in SmmInit assembly files to be the absoute address. > + referred in SmmInit assembly files to be the absolute address. > **/ > VOID > EFIAPI > @@ -1260,7 +1260,7 @@ PiSmmCpuSmmInitFixupAddress ( > > /** > This function fixes up the address of the global variable or function > - referred in SmiEntry assembly files to be the absoute address. > + referred in SmiEntry assembly files to be the absolute address. > **/ > VOID > EFIAPI > diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > index 5d09130e5591..68e5003ad4c2 100644 > --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > @@ -366,7 +366,7 @@ Communicate ( > @param FileHandle Handle of the file being invoked. > @param PeiServices Pointer to PEI Services table. > > - @retval EFI_SUCEESS > + @retval EFI_SUCCESS > @return Others Some error occurs. > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c > index 6be12d6c14cd..30f7d57bdd91 100644 > --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c > +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c > @@ -155,7 +155,7 @@ AllocateAcpiNvsMemoryBelow4G ( > @param[in] ImageHandle Image handle of this driver. > @param[in] SystemTable A Pointer to the EFI System Table. > > - @retval EFI_SUCEESS > + @retval EFI_SUCCESS > @return Others Some error occurs. > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index 723fd5042ff4..db68e1316ec5 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -215,7 +215,7 @@ DumpModuleInfoByIp ( > > @retval EFI_SUCCESS The register was read from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -287,7 +287,7 @@ SmmReadSaveState ( > > @retval EFI_SUCCESS The register was written from Save State > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor > - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct > + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct > > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > index 55090e9c3e4f..9c5a92af6479 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > @@ -465,7 +465,7 @@ ConvertMemoryPageAttributes ( > } > > // > - // Below logic is to check 2M/4K page to make sure we donot waist memory. > + // Below logic is to check 2M/4K page to make sure we do not waste memory. > // > while (Length != 0) { > PageEntry = GetPageTableEntry (BaseAddress, &PageAttribute); > @@ -1065,7 +1065,7 @@ IsUefiPageNotPresent ( > } > > /** > - Merge continous memory map entries whose type is > + Merge continuous memory map entries whose type is > EfiLoaderCode/Data, EfiBootServicesCode/Data, EfiConventionalMemory, > EfiUnusableMemory, EfiACPIReclaimMemory, because the memory described by > these entries will be set as NOT present in SMM page table. > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c > index b1a492725a0c..661cc51f361a 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c > @@ -260,7 +260,7 @@ GetRegisterIndex ( > > @retval EFI_SUCCESS The register was read from Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -343,7 +343,7 @@ ReadSaveStateRegisterByIndex ( > > @retval EFI_SUCCESS The register was read from Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. > - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. > + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. > > **/ > EFI_STATUS > @@ -455,7 +455,7 @@ ReadSaveStateRegister ( > > @retval EFI_SUCCESS The register was written to Save State. > @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. > - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct. > + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct. > > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c > index ce1bf9fb541c..8c9de1fdae70 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c > @@ -58,7 +58,7 @@ SemaphoreHook ( > ); > > // > - // Use temp value to fix ICC complier warning > + // Use temp value to fix ICC compiler warning > // > TempValue = (UINTN)&mSmmRelocationOriginalAddress; > PatchInstructionX86 ( > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > index db06d22d51f4..8bfba55b5d08 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > @@ -16,7 +16,7 @@ > %include "Nasm.inc" > > ; > -; Variables referrenced by C code > +; Variables referenced by C code > ; > > %define MSR_IA32_S_CET 0x6A2 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm > index 8d81582bb1dd..9cf3a6dcf9d5 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm > @@ -72,7 +72,7 @@ BITS 64 > ASM_PFX(gPatchSmmInitStack): > and sp, 0xfff0 ; make sure RSP is 16-byte aligned > ; > - ; Accoring to X64 calling convention, XMM0~5 are volatile, we need to save > + ; According to X64 calling convention, XMM0~5 are volatile, we need to save > ; them before calling C-function. > ; > sub rsp, 0x60 > Reviewed-by: Laszlo Ersek